From: Ido Schimmel <idosch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, mkubecek@suse.cz, johannes@sipsolutions.net
Subject: Re: [PATCH net-next v2 6/6] ethtool: report missing header via ext_ack in the default handler
Date: Thu, 25 Aug 2022 15:19:02 +0300 [thread overview]
Message-ID: <Ywdotl9Zn2MlBhCF@shredder> (raw)
In-Reply-To: <20220825024122.1998968-7-kuba@kernel.org>
On Wed, Aug 24, 2022 at 07:41:22PM -0700, Jakub Kicinski wrote:
> The actual presence check for the header is in
> ethnl_parse_header_dev_get() but it's a few layers in,
> and already has a ton of arguments so let's just pick
> the low handing fruit and check for missing header in
s/handing/hanging/
> the default request handler.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: idosch@nvidia.com
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Nice idea. Wanted to ask why you kept the error messages for some of the
devlink attributes, but then I figured that user space first needs to
learn to interpret 'NLMSGERR_ATTR_MISS_TYPE' and
'NLMSGERR_ATTR_MISS_NEST'. Do you plan to patch iproute2/ethtool after
the kernel patches are accepted?
next prev parent reply other threads:[~2022-08-25 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 2:41 [PATCH net-next v2 0/6] netlink: support reporting missing attributes Jakub Kicinski
2022-08-25 2:41 ` [PATCH net-next v2 1/6] netlink: factor out extack composition Jakub Kicinski
2022-08-25 6:47 ` Johannes Berg
2022-08-25 2:41 ` [PATCH net-next v2 2/6] netlink: add support for ext_ack missing attributes Jakub Kicinski
2022-08-25 6:49 ` Johannes Berg
2022-08-25 2:41 ` [PATCH net-next v2 3/6] netlink: add helpers for extack attr presence checking Jakub Kicinski
2022-08-25 2:41 ` [PATCH net-next v2 4/6] devlink: use missing attribute ext_ack Jakub Kicinski
2022-08-25 2:41 ` [PATCH net-next v2 5/6] ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack Jakub Kicinski
2022-08-25 2:41 ` [PATCH net-next v2 6/6] ethtool: report missing header via ext_ack in the default handler Jakub Kicinski
2022-08-25 12:19 ` Ido Schimmel [this message]
2022-08-25 15:34 ` Jakub Kicinski
2022-08-25 6:51 ` [PATCH net-next v2 0/6] netlink: support reporting missing attributes Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywdotl9Zn2MlBhCF@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.