From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2E9ECAA24 for ; Thu, 25 Aug 2022 17:22:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A41B84EADE; Thu, 25 Aug 2022 13:22:05 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@linux.dev Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vX9+AMaPlBOn; Thu, 25 Aug 2022 13:22:04 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8F03B4EADF; Thu, 25 Aug 2022 13:22:04 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DECED4EADD for ; Thu, 25 Aug 2022 13:22:02 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p9FHXbdCMGmF for ; Thu, 25 Aug 2022 13:22:01 -0400 (EDT) Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A153A4EAD1 for ; Thu, 25 Aug 2022 13:22:01 -0400 (EDT) Date: Thu, 25 Aug 2022 10:21:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661448120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fv5uLAiqTfJ7ki0m8vXx4vs+Jg/Y+MlltpOcaffBFAo=; b=hCNBLE8xOnvioAmSw1qaKUFLJI121ieWuU2y0LduHX7bASykDCdmx62a9ocDSXMbeikvGv j9Z8YdxxaCxUqCoOgvbiuKT8VIYjypf8Virf/z3Jlq2SKFg0Aki0uQX1f/KhoGfssBZMg7 CD6u0+7mrIRtbaC54AbWc1boPzToqB0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Reiji Watanabe Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions Message-ID: References: <20220825050846.3418868-1-reijiw@google.com> <20220825050846.3418868-5-reijiw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220825050846.3418868-5-reijiw@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Cc: kvm@vger.kernel.org, Marc Zyngier , Andrew Jones , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote: > Add helpers to enable breakpoint and watchpoint exceptions. > > Signed-off-by: Reiji Watanabe > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 25 ++++++++++--------- > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index 183ee16acb7d..713c7240b680 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -128,10 +128,20 @@ static void enable_os_lock(void) > GUEST_ASSERT(read_sysreg(oslsr_el1) & 2); > } > > +static void enable_debug_bwp_exception(void) uber-nit: enable_monitor_debug_exceptions() (more closely matches the definition of MDSCR_EL1.MDE) With that: Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FE60ECAA25 for ; Thu, 25 Aug 2022 17:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CXc+TAXPyAenW7g3RIpjSHPYwdhSWYxC7qu/bU+JNLc=; b=Gap0A5QkhpClUG yfqZUITHesA7d7VDqld4tNEhW637JiZXhMPq8M0h3qgNUtZqBEAx32Z63p5nuG0z1Ks7phIe7yjbk P2ezUAwaiYKoA9u53UTxiD+q7KO0ph+L+G4bpqFKBUG3ntclrytJIG9KNfeFIyKP7YEPAdX4rE9kv 0PGAly9zit9A3qu4CA8TmByhtQtpkwzItMjqyDAcmZAQMiSfssOCLOIWN5fwyQfXDlloDNMfgwYDp 2fjpiz75nb9ADQP9DgGVRwoUbTa7RgVUdC9btU7lFWoGiKkCvxB/Kx9gM8zugl2lpC7F4aTdwBdhw VC/Qfh/mRFgJ1xOS2NoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRGYY-00GpSl-DI; Thu, 25 Aug 2022 17:22:14 +0000 Received: from out0.migadu.com ([94.23.1.103]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRGYU-00GpN4-JD for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 17:22:12 +0000 Date: Thu, 25 Aug 2022 10:21:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661448120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fv5uLAiqTfJ7ki0m8vXx4vs+Jg/Y+MlltpOcaffBFAo=; b=hCNBLE8xOnvioAmSw1qaKUFLJI121ieWuU2y0LduHX7bASykDCdmx62a9ocDSXMbeikvGv j9Z8YdxxaCxUqCoOgvbiuKT8VIYjypf8Virf/z3Jlq2SKFg0Aki0uQX1f/KhoGfssBZMg7 CD6u0+7mrIRtbaC54AbWc1boPzToqB0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Reiji Watanabe Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andrew Jones , Paolo Bonzini , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions Message-ID: References: <20220825050846.3418868-1-reijiw@google.com> <20220825050846.3418868-5-reijiw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220825050846.3418868-5-reijiw@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_102210_806158_B00F5928 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote: > Add helpers to enable breakpoint and watchpoint exceptions. > > Signed-off-by: Reiji Watanabe > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 25 ++++++++++--------- > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index 183ee16acb7d..713c7240b680 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -128,10 +128,20 @@ static void enable_os_lock(void) > GUEST_ASSERT(read_sysreg(oslsr_el1) & 2); > } > > +static void enable_debug_bwp_exception(void) uber-nit: enable_monitor_debug_exceptions() (more closely matches the definition of MDSCR_EL1.MDE) With that: Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58184ECAA27 for ; Thu, 25 Aug 2022 17:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242109AbiHYRWF (ORCPT ); Thu, 25 Aug 2022 13:22:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234511AbiHYRWE (ORCPT ); Thu, 25 Aug 2022 13:22:04 -0400 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E40B9419 for ; Thu, 25 Aug 2022 10:22:02 -0700 (PDT) Date: Thu, 25 Aug 2022 10:21:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661448120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fv5uLAiqTfJ7ki0m8vXx4vs+Jg/Y+MlltpOcaffBFAo=; b=hCNBLE8xOnvioAmSw1qaKUFLJI121ieWuU2y0LduHX7bASykDCdmx62a9ocDSXMbeikvGv j9Z8YdxxaCxUqCoOgvbiuKT8VIYjypf8Virf/z3Jlq2SKFg0Aki0uQX1f/KhoGfssBZMg7 CD6u0+7mrIRtbaC54AbWc1boPzToqB0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Reiji Watanabe Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andrew Jones , Paolo Bonzini , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/9] KVM: arm64: selftests: Add helpers to enable debug exceptions Message-ID: References: <20220825050846.3418868-1-reijiw@google.com> <20220825050846.3418868-5-reijiw@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825050846.3418868-5-reijiw@google.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 24, 2022 at 10:08:41PM -0700, Reiji Watanabe wrote: > Add helpers to enable breakpoint and watchpoint exceptions. > > Signed-off-by: Reiji Watanabe > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 25 ++++++++++--------- > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index 183ee16acb7d..713c7240b680 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -128,10 +128,20 @@ static void enable_os_lock(void) > GUEST_ASSERT(read_sysreg(oslsr_el1) & 2); > } > > +static void enable_debug_bwp_exception(void) uber-nit: enable_monitor_debug_exceptions() (more closely matches the definition of MDSCR_EL1.MDE) With that: Reviewed-by: Oliver Upton -- Thanks, Oliver