From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oRIbu-0006qb-UX for mharc-grub-devel@gnu.org; Thu, 25 Aug 2022 15:33:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRIbs-0006oy-Ue for grub-devel@gnu.org; Thu, 25 Aug 2022 15:33:48 -0400 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]:40716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRIbq-0002ee-CE for grub-devel@gnu.org; Thu, 25 Aug 2022 15:33:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wK3mt2f6eMIaO1EA0hZXgvfFBlp7tn6puQcLKkEl0GI=; b=Y3IC+CmFbEQfyTeR9HEhyQl1/u E9Z8mEulCWf8RN854hn90PLXTCrzBQMdeS2h3BLz40epFpGLH2FH78RxwRhN66XcUHZfeH4MIXebF h6aJIzxOryKSm3dRHJgmiEixQYihBtviwKRHaK6wKD8qSuze/eRGxjxOLNkr03iZorkZ6szoQlSoM wzQopI78/oyvWv2XDxv7O9a+P1PVcVP2uTVuGoMlgbSM87a6FDpnAsgfSSWCeQf/zYFdVj6FJcW5m p9rRZ5YO7sWMxlQ41GtgSLmzBTNX7waA/efuwIyak9TCqX/NMdiLd1zGedXKQV2v5HlVp2Epcg3F5 GhiT3qiA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRIbd-0065dQ-8q; Thu, 25 Aug 2022 19:33:33 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 21795980051; Thu, 25 Aug 2022 21:33:31 +0200 (CEST) Date: Thu, 25 Aug 2022 21:33:31 +0200 From: Peter Zijlstra To: Glenn Washburn Cc: The development of GNU GRUB , Daniel Kiper Subject: Re: [PATCH] term/serial: Add support for PCI serial devices Message-ID: References: <20220824151355.6312d89d@crass-HP-ZBook-15-G2> <20220824183627.62abec4e@crass-HP-ZBook-15-G2> <20220825105129.65b7b9f0@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825105129.65b7b9f0@crass-HP-ZBook-15-G2> Received-SPF: none client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; envelope-from=peterz@infradead.org; helo=desiato.infradead.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2022 19:33:49 -0000 On Thu, Aug 25, 2022 at 10:51:29AM -0500, Glenn Washburn wrote: > On Thu, 25 Aug 2022 09:57:32 +0200 > Peter Zijlstra wrote: > > > On Wed, Aug 24, 2022 at 06:36:27PM -0500, Glenn Washburn wrote: > > > You will need to run the bootstrap script in the root of the repo to > > > rebuild the build scripts before running configure and make. > > > > FWIW bootstrap scribbles INSTALL > > Its been a while since I've looked at this. But I believe that INSTALL > is copied to INSTALL.grub. Is INSTALL getting overwritten with a > default INSTALL not related to GRUB? I'm unsure of what you're really > wanting to convey here. Something actionable? When you do ./bootstrap; git diff returns a fairly sizable diff on INSTALL, which is a bit weird and tends to sneak into patches (had to kill it twice etc..). So either add INSTALL to .gitignore, or fix it so that INSTALL doesn't get scribbled would be my suggestion.