From: Jason Gunthorpe <jgg@nvidia.com>
To: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Cc: leonro@nvidia.com, zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Ratelimit error messages of read_reply()
Date: Fri, 26 Aug 2022 09:28:21 -0300 [thread overview]
Message-ID: <Ywi8ZebmZv+bctrC@nvidia.com> (raw)
In-Reply-To: <20220825110255.658706-1-matsuda-daisuke@fujitsu.com>
On Thu, Aug 25, 2022 at 08:02:55PM +0900, Daisuke Matsuda wrote:
> When responder cannot copy data from a user MR, error messages overflow.
> This is because an incoming RDMA Read request can results in multiple Read
> responses. If the target MR is somehow unavailable, then the error message
> is generated for every Read response.
>
> For the same reason, the error message for packet transmission should also
> be ratelimited.
>
> Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
These lines should be deleted, network packts should never trigger
printing.
Jason
next prev parent reply other threads:[~2022-08-26 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:02 [PATCH] RDMA/rxe: Ratelimit error messages of read_reply() Daisuke Matsuda
2022-08-25 15:55 ` Bob Pearson
2022-08-26 12:28 ` Jason Gunthorpe [this message]
2022-08-29 5:16 ` matsuda-daisuke
2022-08-29 5:44 ` [PATCH] RDMA/rxe: Delete error messages triggered by incoming Read requests Daisuke Matsuda
2022-08-29 5:51 ` Cheng Xu
2022-08-29 6:31 ` Zhu Yanjun
2022-08-29 7:02 ` Leon Romanovsky
2022-08-29 7:13 ` Zhu Yanjun
2022-08-29 7:36 ` Li Zhijian
2022-08-29 10:21 ` matsuda-daisuke
2022-08-30 9:44 ` Li Zhijian
2022-08-30 9:54 ` Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywi8ZebmZv+bctrC@nvidia.com \
--to=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matsuda-daisuke@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.