From: Jason Gunthorpe <jgg@nvidia.com>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
saeedm@nvidia.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
kuba@kernel.org, kevin.tian@intel.com, leonro@nvidia.com,
maorg@nvidia.com, cohuck@redhat.com
Subject: Re: [PATCH V4 vfio 04/10] vfio: Add an IOVA bitmap support
Date: Fri, 26 Aug 2022 10:01:00 -0300 [thread overview]
Message-ID: <YwjEDIT+IyyW5Aok@nvidia.com> (raw)
In-Reply-To: <e78407fa-20db-ed9e-fd3e-a427712f75e7@oracle.com>
On Fri, Aug 26, 2022 at 10:37:26AM +0100, Joao Martins wrote:
> >> It's already wrapped (by my editor) and also at 75 columns. I can do a
> >> bit shorter if that's hurting readability.
> >
> > 78 chars above, but git log indents by another 4 spaces, so they do
> > wrap. Something around 70/72 seems better for commit logs.
> >
> OK, I'll wrap at 70.
We have a documented standard for this:
Documentation/process/submitting-patches.rst:
The canonical patch format
--------------------------
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
Please follow it - it always bugs me when people randomly choose to
wrap at something alot less than 75 columns for some reason.
Jason
next prev parent reply other threads:[~2022-08-26 13:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 15:10 [PATCH V4 vfio 00/10] Add device DMA logging support for mlx5 driver Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 01/10] net/mlx5: Introduce ifc bits for page tracker Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 02/10] net/mlx5: Query ADV_VIRTUALIZATION capabilities Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 03/10] vfio: Introduce DMA logging uAPIs Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 04/10] vfio: Add an IOVA bitmap support Yishai Hadas
2022-08-25 19:27 ` Alex Williamson
2022-08-25 22:24 ` Joao Martins
2022-08-25 23:15 ` Alex Williamson
2022-08-26 9:37 ` Joao Martins
2022-08-26 12:02 ` Alex Williamson
2022-08-26 12:10 ` Joao Martins
2022-08-26 13:01 ` Jason Gunthorpe [this message]
2022-08-26 12:58 ` Jason Gunthorpe
2022-08-15 15:11 ` [PATCH V4 vfio 05/10] vfio: Introduce the DMA logging feature support Yishai Hadas
2022-08-25 20:49 ` Alex Williamson
2022-08-25 22:26 ` Joao Martins
2022-08-25 22:46 ` Alex Williamson
2022-08-26 12:52 ` Jason Gunthorpe
2022-08-28 13:29 ` Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 06/10] vfio/mlx5: Init QP based resources for dirty tracking Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 07/10] vfio/mlx5: Create and destroy page tracker object Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 08/10] vfio/mlx5: Report dirty pages from tracker Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 09/10] vfio/mlx5: Manage error scenarios on tracker Yishai Hadas
2022-08-15 15:11 ` [PATCH V4 vfio 10/10] vfio/mlx5: Set the driver DMA logging callbacks Yishai Hadas
2022-08-25 11:13 ` [PATCH V4 vfio 00/10] Add device DMA logging support for mlx5 driver Yishai Hadas
2022-08-25 19:37 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwjEDIT+IyyW5Aok@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=maorg@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.