From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 858ED409E5 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C7853409DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1M2HrqLpQSUZ6FrdfJ2qAbOLMtoL8Um9KiucawV4qNQ=; b=asEsIQRoq5KZncpva0RB8kkY66U6tRsrJOV0Gr6Z3HqF3jzEoIgh+pSiTijBuxfjFOYrjPe+XNavqcOcUlWEXINsMJOOJc68fBxAwpAsqaP88L1H8yIYJSGZ/JM/r2wOHYuqBLcgI7oKZ5T8hEz0UKWTJkN4Ivb7xb19Bjle/r6b0DgCHhjqCBJ2Lu/ldCqah8sngvURP4eLm6sbpDvDa7zi2hMmyavtn8P+gwQ/EAAKs2KzLeae/MouE9RCGuENk3xLrNxzwOvuAzRV1E5oXdN0RobKVVDn0whynoftc6zelqeztZmejowAcgJZvE+V55ZOJQJJuui5C8bSPqdRkw== Date: Sat, 27 Aug 2022 18:46:04 +0300 From: Ido Schimmel Message-ID: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-3-netdev@kapio-technology.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220826114538.705433-3-netdev@kapio-technology.com> MIME-Version: 1.0 Subject: Re: [Bridge] [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans Schultz Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , bridge@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Christian Marangi , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote: > diff --git a/include/net/switchdev.h b/include/net/switchdev.h > index 7dcdc97c0bc3..437945179373 100644 > --- a/include/net/switchdev.h > +++ b/include/net/switchdev.h > @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info { > const unsigned char *addr; > u16 vid; > u8 added_by_user:1, > + sticky:1, If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1', then the 'sticky' bit can be removed for now (we will need it some day to support sticky entries notified from the bridge). This takes care of the discrepancy Nik mentioned here: https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/ > is_local:1, > + locked:1, > + blackhole:1, > offloaded:1; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8837ECAAD2 for ; Sat, 27 Aug 2022 15:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233506AbiH0PqP (ORCPT ); Sat, 27 Aug 2022 11:46:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbiH0PqO (ORCPT ); Sat, 27 Aug 2022 11:46:14 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15C48696C6; Sat, 27 Aug 2022 08:46:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkqWvtTj8JgrAWHY5AGj2qRP/maBfEnA/FmkcI/Br4/+YQ7r3dGnPQf213CcVq8SPwUJ06BPKTTixjHCvpFyjyJKp9DMqVFp9mN+sm8b+94XWRabdy+HqCU1WC/zPXBBLQsV4arRnXrDCZWIWWDlWLGGpZMxf8t81Hnk/yQpCXyQLf9euHcqG3vebuzotMShfHNXgZ6Od2Fn6nCcyJr6l/4TDuWMz2E/lKacdniUYYkkbPAYlWIKj449sKeg3K8B8EHn9bxlDlrzz4kPKgwhwW2q1eR/0mG98KwoplH4Rf/wTRmb833qwTtLvtjO33XCpOEvHdsWmy3EnKjP9yGIvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1M2HrqLpQSUZ6FrdfJ2qAbOLMtoL8Um9KiucawV4qNQ=; b=VTbOVOi/E6wUKtZfD9FzqcnObK1kysT+7JHPkqK3BsvJ+dTKUJhFEF/vYU1wCgVO4KkfVGy7UdTDNT6rJ67X4Tx3VHsDp6Ts7QnUp+qOHJXNm36JJ5pSe0vJV+utuL1peqDpg+ofUjO5FyFvGFND7aIek+lkIBaOQzeNfhPX++R5dvwluwi2vY8ML8VVUjZWxYX6fGuVJPHf2v8lS+R9OV+4VjlhOiaOAUTgn8B35tQWeVYTanAGtwX3Ilm4+CxkNp+3peU44b0FJHXkL+FbktxSSl57+y2q7UVTAU8FYypw2a94gd0aAHiY7RkxXatOPuRTXVpq9wF948k0PpPtbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1M2HrqLpQSUZ6FrdfJ2qAbOLMtoL8Um9KiucawV4qNQ=; b=asEsIQRoq5KZncpva0RB8kkY66U6tRsrJOV0Gr6Z3HqF3jzEoIgh+pSiTijBuxfjFOYrjPe+XNavqcOcUlWEXINsMJOOJc68fBxAwpAsqaP88L1H8yIYJSGZ/JM/r2wOHYuqBLcgI7oKZ5T8hEz0UKWTJkN4Ivb7xb19Bjle/r6b0DgCHhjqCBJ2Lu/ldCqah8sngvURP4eLm6sbpDvDa7zi2hMmyavtn8P+gwQ/EAAKs2KzLeae/MouE9RCGuENk3xLrNxzwOvuAzRV1E5oXdN0RobKVVDn0whynoftc6zelqeztZmejowAcgJZvE+V55ZOJQJJuui5C8bSPqdRkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH7SPRMB0001.namprd12.prod.outlook.com (2603:10b6:510:13c::20) by BN6PR1201MB0017.namprd12.prod.outlook.com (2603:10b6:405:53::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Sat, 27 Aug 2022 15:46:11 +0000 Received: from PH7SPRMB0001.namprd12.prod.outlook.com ([fe80::3ca6:ba11:2893:980e]) by PH7SPRMB0001.namprd12.prod.outlook.com ([fe80::3ca6:ba11:2893:980e%6]) with mapi id 15.20.5504.025; Sat, 27 Aug 2022 15:46:11 +0000 Date: Sat, 27 Aug 2022 18:46:04 +0300 From: Ido Schimmel To: Hans Schultz Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag Message-ID: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-3-netdev@kapio-technology.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220826114538.705433-3-netdev@kapio-technology.com> X-ClientProxiedBy: VI1PR07CA0271.eurprd07.prod.outlook.com (2603:10a6:803:b4::38) To PH7SPRMB0001.namprd12.prod.outlook.com (2603:10b6:510:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a3feee7-eff7-49e6-d452-08da884343de X-MS-TrafficTypeDiagnostic: BN6PR1201MB0017:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yKBn72tHZc2l9sIX319NFZU2P1wl3LlFtdA68SUDvRJU2phnZ5LNKpuDtoXpjMrbaCzouHUuxMXWySu0sP7ZDairqtAjjlZMjaf1cTBOeIWOioEv9DovcNuTuApQZ8igG5xTZbQh9kGuo/A/7voWi8bbEQOkhrdlx6oju1VJSnYPgiPU6bh/01NLfKLtwj222bfj2T2pnHPXMH0ctooXwSMxIMRkWi4UEoWoP9xOnws8oFMewQ9vnxW8aI9kXgJJJcGn129I8ZvOGpN5//J0xikyofT3QNnhV1oajUlTX9kZMPJ4ySeHcDXD/ukc4xGbp/pVUIMgEKla8mJUcpfWTDwog3Hsfwllh/lrtm/QRke3W0OVoduA3dnRm2bEA4YiXRTxebYJyjXZDo0p41QttSbwTg6YCP7nkspXhxlibXnOcmkHEcBk5YroB0CdC/RlblM4v4KQeVfIydFs/bzN//5/gjwOw7YyFheVUM9P5JUM3NsYeLIBrUkJxIhYQbrvPxB9xt5seTw3MrLqiL8157Zy86ILVXDVyAQAtE9ORZb27/mUaJi8aKksFF2qOpPzjJ5zbX0/wAF67Nogt2leCOVdioPyMEKaPaB3pB+xY4h+sJNbDtxouRccNZF7LGvwQOqKY4MmyYhGAd4NrUYcVBqIHxiN+51FB/AOSNEwTbzqCalhq1Ssw0mW1udNgXdQUetoyLN2StrLbAQBdg7XHX1zgBa5v9DuTxQYUkxXNvR3S7Az2JbKogFj5xEh3JUUDd+exNY98HdkCCOGMKwacO4t4Vh9JSWmk8jh/9du0vw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7SPRMB0001.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(376002)(136003)(396003)(366004)(346002)(39860400002)(7406005)(41300700001)(6666004)(4744005)(6506007)(2906002)(54906003)(6916009)(478600001)(86362001)(4326008)(966005)(6486002)(8676002)(66476007)(316002)(5660300002)(8936002)(66556008)(66946007)(7416002)(83380400001)(186003)(6512007)(9686003)(26005)(38100700002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1UtIJVvGyukyhuZgfpec8cDVFMWgdafHa7aToWDQJWnvg+cljQD/A9k+agaS?= =?us-ascii?Q?Wlo/Rt+DxzKaZ+HlkC3h1JSrEf/RVl7dpQn+MOgzEevoM17o5484kwfJx4UZ?= =?us-ascii?Q?ZSDFc3FW2x4tTYXw1lkUElfwTXbiuEBz3mAJQFXKZBKIwXMkXneXORDLWOfv?= =?us-ascii?Q?8gFpq5aXIPoBzZIi++DGTphAoCtKXaLP1vXesjTYuKeYHcpWzL/j+qGEl5wh?= =?us-ascii?Q?itFC5vMOCPdQQhfgRFVYYBA6AyOYDnj43/Fle2gJTacbPjkxtOuQBap0M+Ra?= =?us-ascii?Q?1DwqPc9l2ie9D1gvNi4yyHAAd7dbmOm8aOY3b957VgMm8UCafKdBHCfHSzhS?= =?us-ascii?Q?hIj02VO8Ho8zD9ZaMq38Bn4R8oU/S6YcwDqkP8+TlaUB8+RXGWJlP4xoEcVQ?= =?us-ascii?Q?nfvqm6jJsc9m+nJkomEwhzmKGQOOeYRtERVmeWlEugk7hEkIoGGIY6nkKnbT?= =?us-ascii?Q?vjvGQwrKjaHrV9BTo7PVpPTk+JzgsQoStDqajbidKGR/RzT1xzlNkG/d6L/d?= =?us-ascii?Q?ZcPJfP/vBIhjuGmg7wEFh52dtn2WOP9S0IN0y1wEW9Bm7G/c08HI4ao7sBc/?= =?us-ascii?Q?A2yKqTICaPFrjvbwoggnaPS4YbR+QYkQG+qVD8fLtcswA2KvnNtx6v43QCuD?= =?us-ascii?Q?9tUWq2cjhv3X5geR+Jo4rOYTkOsqWmw8jSe0o7H2fr4+OATOzYUztshKz4no?= =?us-ascii?Q?cfTDH+lhcZuQYNR3ORnaW7obDRUX+KMazeM3vayKh4kIyXY1S/k4gsltzIMz?= =?us-ascii?Q?gX9uyaA2QyPmOcJ7FEA6LD2wsV9rIN0kPzDi+dKvLAN8Epd+pwgTNl/KrlKJ?= =?us-ascii?Q?6N0ZZ5VLWHj2et0HcDTJfJVLMWCC4cUUEG6dhASPSsyB53604jlgE2RXY8GS?= =?us-ascii?Q?NKl9oTDr3p2Bh/RNSPohcvbGkFZ0kw/ermfzQ6REKJl7ZIc2A/nXay5KR/rY?= =?us-ascii?Q?N2c+W3+nI7r+qfW/b8vD2kLvKhcGUOymkGNE4i4gZMnQPvQYIzia1UI5fSkm?= =?us-ascii?Q?9Oq2/hpeYyUDZPxEWjW4tEZ2ZubS42phqhGHkAB1zFrDWfoYUrCaGH8snuaq?= =?us-ascii?Q?EM70FTHtTgoy4eGJZkv3ZF5NULDKPPu+m8y1jOmJmLF5zoDrbV9emAp9Qkg3?= =?us-ascii?Q?QvC1E3hBTX/Pd+Q5PqxLqO3huoizbt0dTLYHQCtimqVO7QhPMLbsm1RFnwbt?= =?us-ascii?Q?MJifPEKzSp8SJV11/oaTltSXGN6KPujCXjVASZagMjH4mJaL3wCN1gQXkLhH?= =?us-ascii?Q?7HGVhPhPL7TOcHuIbWgqhdzLl/7zjWJlc1ZkgBGQ0pRzW4FUfFyp9dOJUg/v?= =?us-ascii?Q?Iy6o1QL3ukWCfT1detIvWCtwTnLZZWkC0exL+lSDeJSm36RPtFq8U2ixJ83Y?= =?us-ascii?Q?+A+g6b5KNPxV4IJU4DZuDUSOtzLe+FOG0EGazW1iXSkVtQh5yhzFTv3tYmMH?= =?us-ascii?Q?QV+tyU2i7fiXozYls/pARcMw0y78cbR49SvAMm1fd2K0OWBxES98mk7GK0iH?= =?us-ascii?Q?MSNBP3wdWu03kegD/DphSeefX9v8SLu8aJniyULjSCI0HsU75cwCzNmrwdcL?= =?us-ascii?Q?HqSu/70MGP+c4ob67QxielnZ6Yg87/s3DsIjGKIa?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3feee7-eff7-49e6-d452-08da884343de X-MS-Exchange-CrossTenant-AuthSource: PH7SPRMB0001.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 15:46:11.1083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1hEfdPQFV0arqRAHuZ9McMCcLhfkacXaTbvsefUWtnLntj8EjEm3kehV9+zji2aujIrpvoKRFRPsuKY1Ga3CEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0017 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote: > diff --git a/include/net/switchdev.h b/include/net/switchdev.h > index 7dcdc97c0bc3..437945179373 100644 > --- a/include/net/switchdev.h > +++ b/include/net/switchdev.h > @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info { > const unsigned char *addr; > u16 vid; > u8 added_by_user:1, > + sticky:1, If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1', then the 'sticky' bit can be removed for now (we will need it some day to support sticky entries notified from the bridge). This takes care of the discrepancy Nik mentioned here: https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/ > is_local:1, > + locked:1, > + blackhole:1, > offloaded:1; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC6E1ECAAD2 for ; Sat, 27 Aug 2022 15:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aF6yGb/zrtlcPv4Kdp24JSGF2yg+7IcxbzCAThFRpFc=; b=TfM1tFIX204Xa/ +oRtciL9ckqG4rnJmWRt4ZyKpOAOmTf24p2lFD5TPQl12bHQGDhHbzpvq0QRxH0cEROKuwWsaPfo1 n91YGXO0Xxr/M1ztlp1a3T1V1xM86uFqLLOZ5ucu9cumK+W4D/ni6NeO/Qz0X2BL1tCG4ek7rbGVe fBNgc3N2VkmzokxFGdrgXxIGI8crNZyqHE3KMmgm/bv9U2DMz4HuIhSKhuhU10nol1frlHPQ/RQih UnGZjaR5bmt4IN1VJ4+PKytXa5t7anTC9nMR0q4qWPVJvnbFmFdV6f3oGD04GgIUMVG6C/a/d2rn3 at1osvYqZsLvSLOcusbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRy0q-00CcsS-1m; Sat, 27 Aug 2022 15:46:20 +0000 Received: from mail-dm6nam10on2044.outbound.protection.outlook.com ([40.107.93.44] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRy0l-00Cckx-JZ; Sat, 27 Aug 2022 15:46:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkqWvtTj8JgrAWHY5AGj2qRP/maBfEnA/FmkcI/Br4/+YQ7r3dGnPQf213CcVq8SPwUJ06BPKTTixjHCvpFyjyJKp9DMqVFp9mN+sm8b+94XWRabdy+HqCU1WC/zPXBBLQsV4arRnXrDCZWIWWDlWLGGpZMxf8t81Hnk/yQpCXyQLf9euHcqG3vebuzotMShfHNXgZ6Od2Fn6nCcyJr6l/4TDuWMz2E/lKacdniUYYkkbPAYlWIKj449sKeg3K8B8EHn9bxlDlrzz4kPKgwhwW2q1eR/0mG98KwoplH4Rf/wTRmb833qwTtLvtjO33XCpOEvHdsWmy3EnKjP9yGIvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1M2HrqLpQSUZ6FrdfJ2qAbOLMtoL8Um9KiucawV4qNQ=; b=VTbOVOi/E6wUKtZfD9FzqcnObK1kysT+7JHPkqK3BsvJ+dTKUJhFEF/vYU1wCgVO4KkfVGy7UdTDNT6rJ67X4Tx3VHsDp6Ts7QnUp+qOHJXNm36JJ5pSe0vJV+utuL1peqDpg+ofUjO5FyFvGFND7aIek+lkIBaOQzeNfhPX++R5dvwluwi2vY8ML8VVUjZWxYX6fGuVJPHf2v8lS+R9OV+4VjlhOiaOAUTgn8B35tQWeVYTanAGtwX3Ilm4+CxkNp+3peU44b0FJHXkL+FbktxSSl57+y2q7UVTAU8FYypw2a94gd0aAHiY7RkxXatOPuRTXVpq9wF948k0PpPtbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1M2HrqLpQSUZ6FrdfJ2qAbOLMtoL8Um9KiucawV4qNQ=; b=asEsIQRoq5KZncpva0RB8kkY66U6tRsrJOV0Gr6Z3HqF3jzEoIgh+pSiTijBuxfjFOYrjPe+XNavqcOcUlWEXINsMJOOJc68fBxAwpAsqaP88L1H8yIYJSGZ/JM/r2wOHYuqBLcgI7oKZ5T8hEz0UKWTJkN4Ivb7xb19Bjle/r6b0DgCHhjqCBJ2Lu/ldCqah8sngvURP4eLm6sbpDvDa7zi2hMmyavtn8P+gwQ/EAAKs2KzLeae/MouE9RCGuENk3xLrNxzwOvuAzRV1E5oXdN0RobKVVDn0whynoftc6zelqeztZmejowAcgJZvE+V55ZOJQJJuui5C8bSPqdRkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH7SPRMB0001.namprd12.prod.outlook.com (2603:10b6:510:13c::20) by BN6PR1201MB0017.namprd12.prod.outlook.com (2603:10b6:405:53::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Sat, 27 Aug 2022 15:46:11 +0000 Received: from PH7SPRMB0001.namprd12.prod.outlook.com ([fe80::3ca6:ba11:2893:980e]) by PH7SPRMB0001.namprd12.prod.outlook.com ([fe80::3ca6:ba11:2893:980e%6]) with mapi id 15.20.5504.025; Sat, 27 Aug 2022 15:46:11 +0000 Date: Sat, 27 Aug 2022 18:46:04 +0300 From: Ido Schimmel To: Hans Schultz Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 2/6] net: switchdev: add support for offloading of fdb locked flag Message-ID: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-3-netdev@kapio-technology.com> Content-Disposition: inline In-Reply-To: <20220826114538.705433-3-netdev@kapio-technology.com> X-ClientProxiedBy: VI1PR07CA0271.eurprd07.prod.outlook.com (2603:10a6:803:b4::38) To PH7SPRMB0001.namprd12.prod.outlook.com (2603:10b6:510:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a3feee7-eff7-49e6-d452-08da884343de X-MS-TrafficTypeDiagnostic: BN6PR1201MB0017:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yKBn72tHZc2l9sIX319NFZU2P1wl3LlFtdA68SUDvRJU2phnZ5LNKpuDtoXpjMrbaCzouHUuxMXWySu0sP7ZDairqtAjjlZMjaf1cTBOeIWOioEv9DovcNuTuApQZ8igG5xTZbQh9kGuo/A/7voWi8bbEQOkhrdlx6oju1VJSnYPgiPU6bh/01NLfKLtwj222bfj2T2pnHPXMH0ctooXwSMxIMRkWi4UEoWoP9xOnws8oFMewQ9vnxW8aI9kXgJJJcGn129I8ZvOGpN5//J0xikyofT3QNnhV1oajUlTX9kZMPJ4ySeHcDXD/ukc4xGbp/pVUIMgEKla8mJUcpfWTDwog3Hsfwllh/lrtm/QRke3W0OVoduA3dnRm2bEA4YiXRTxebYJyjXZDo0p41QttSbwTg6YCP7nkspXhxlibXnOcmkHEcBk5YroB0CdC/RlblM4v4KQeVfIydFs/bzN//5/gjwOw7YyFheVUM9P5JUM3NsYeLIBrUkJxIhYQbrvPxB9xt5seTw3MrLqiL8157Zy86ILVXDVyAQAtE9ORZb27/mUaJi8aKksFF2qOpPzjJ5zbX0/wAF67Nogt2leCOVdioPyMEKaPaB3pB+xY4h+sJNbDtxouRccNZF7LGvwQOqKY4MmyYhGAd4NrUYcVBqIHxiN+51FB/AOSNEwTbzqCalhq1Ssw0mW1udNgXdQUetoyLN2StrLbAQBdg7XHX1zgBa5v9DuTxQYUkxXNvR3S7Az2JbKogFj5xEh3JUUDd+exNY98HdkCCOGMKwacO4t4Vh9JSWmk8jh/9du0vw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7SPRMB0001.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(376002)(136003)(396003)(366004)(346002)(39860400002)(7406005)(41300700001)(6666004)(4744005)(6506007)(2906002)(54906003)(6916009)(478600001)(86362001)(4326008)(966005)(6486002)(8676002)(66476007)(316002)(5660300002)(8936002)(66556008)(66946007)(7416002)(83380400001)(186003)(6512007)(9686003)(26005)(38100700002)(33716001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1UtIJVvGyukyhuZgfpec8cDVFMWgdafHa7aToWDQJWnvg+cljQD/A9k+agaS?= =?us-ascii?Q?Wlo/Rt+DxzKaZ+HlkC3h1JSrEf/RVl7dpQn+MOgzEevoM17o5484kwfJx4UZ?= =?us-ascii?Q?ZSDFc3FW2x4tTYXw1lkUElfwTXbiuEBz3mAJQFXKZBKIwXMkXneXORDLWOfv?= =?us-ascii?Q?8gFpq5aXIPoBzZIi++DGTphAoCtKXaLP1vXesjTYuKeYHcpWzL/j+qGEl5wh?= =?us-ascii?Q?itFC5vMOCPdQQhfgRFVYYBA6AyOYDnj43/Fle2gJTacbPjkxtOuQBap0M+Ra?= =?us-ascii?Q?1DwqPc9l2ie9D1gvNi4yyHAAd7dbmOm8aOY3b957VgMm8UCafKdBHCfHSzhS?= =?us-ascii?Q?hIj02VO8Ho8zD9ZaMq38Bn4R8oU/S6YcwDqkP8+TlaUB8+RXGWJlP4xoEcVQ?= =?us-ascii?Q?nfvqm6jJsc9m+nJkomEwhzmKGQOOeYRtERVmeWlEugk7hEkIoGGIY6nkKnbT?= =?us-ascii?Q?vjvGQwrKjaHrV9BTo7PVpPTk+JzgsQoStDqajbidKGR/RzT1xzlNkG/d6L/d?= =?us-ascii?Q?ZcPJfP/vBIhjuGmg7wEFh52dtn2WOP9S0IN0y1wEW9Bm7G/c08HI4ao7sBc/?= =?us-ascii?Q?A2yKqTICaPFrjvbwoggnaPS4YbR+QYkQG+qVD8fLtcswA2KvnNtx6v43QCuD?= =?us-ascii?Q?9tUWq2cjhv3X5geR+Jo4rOYTkOsqWmw8jSe0o7H2fr4+OATOzYUztshKz4no?= =?us-ascii?Q?cfTDH+lhcZuQYNR3ORnaW7obDRUX+KMazeM3vayKh4kIyXY1S/k4gsltzIMz?= =?us-ascii?Q?gX9uyaA2QyPmOcJ7FEA6LD2wsV9rIN0kPzDi+dKvLAN8Epd+pwgTNl/KrlKJ?= =?us-ascii?Q?6N0ZZ5VLWHj2et0HcDTJfJVLMWCC4cUUEG6dhASPSsyB53604jlgE2RXY8GS?= =?us-ascii?Q?NKl9oTDr3p2Bh/RNSPohcvbGkFZ0kw/ermfzQ6REKJl7ZIc2A/nXay5KR/rY?= =?us-ascii?Q?N2c+W3+nI7r+qfW/b8vD2kLvKhcGUOymkGNE4i4gZMnQPvQYIzia1UI5fSkm?= =?us-ascii?Q?9Oq2/hpeYyUDZPxEWjW4tEZ2ZubS42phqhGHkAB1zFrDWfoYUrCaGH8snuaq?= =?us-ascii?Q?EM70FTHtTgoy4eGJZkv3ZF5NULDKPPu+m8y1jOmJmLF5zoDrbV9emAp9Qkg3?= =?us-ascii?Q?QvC1E3hBTX/Pd+Q5PqxLqO3huoizbt0dTLYHQCtimqVO7QhPMLbsm1RFnwbt?= =?us-ascii?Q?MJifPEKzSp8SJV11/oaTltSXGN6KPujCXjVASZagMjH4mJaL3wCN1gQXkLhH?= =?us-ascii?Q?7HGVhPhPL7TOcHuIbWgqhdzLl/7zjWJlc1ZkgBGQ0pRzW4FUfFyp9dOJUg/v?= =?us-ascii?Q?Iy6o1QL3ukWCfT1detIvWCtwTnLZZWkC0exL+lSDeJSm36RPtFq8U2ixJ83Y?= =?us-ascii?Q?+A+g6b5KNPxV4IJU4DZuDUSOtzLe+FOG0EGazW1iXSkVtQh5yhzFTv3tYmMH?= =?us-ascii?Q?QV+tyU2i7fiXozYls/pARcMw0y78cbR49SvAMm1fd2K0OWBxES98mk7GK0iH?= =?us-ascii?Q?MSNBP3wdWu03kegD/DphSeefX9v8SLu8aJniyULjSCI0HsU75cwCzNmrwdcL?= =?us-ascii?Q?HqSu/70MGP+c4ob67QxielnZ6Yg87/s3DsIjGKIa?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3feee7-eff7-49e6-d452-08da884343de X-MS-Exchange-CrossTenant-AuthSource: PH7SPRMB0001.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2022 15:46:11.1083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1hEfdPQFV0arqRAHuZ9McMCcLhfkacXaTbvsefUWtnLntj8EjEm3kehV9+zji2aujIrpvoKRFRPsuKY1Ga3CEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0017 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220827_084615_673849_BA7E55EF X-CRM114-Status: UNSURE ( 9.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 26, 2022 at 01:45:34PM +0200, Hans Schultz wrote: > diff --git a/include/net/switchdev.h b/include/net/switchdev.h > index 7dcdc97c0bc3..437945179373 100644 > --- a/include/net/switchdev.h > +++ b/include/net/switchdev.h > @@ -247,7 +247,10 @@ struct switchdev_notifier_fdb_info { > const unsigned char *addr; > u16 vid; > u8 added_by_user:1, > + sticky:1, If mv88e6xxx reports entries with 'is_local=1, locked=1, blackhole=1', then the 'sticky' bit can be removed for now (we will need it some day to support sticky entries notified from the bridge). This takes care of the discrepancy Nik mentioned here: https://lore.kernel.org/netdev/d1de0337-ae16-7dca-b212-1a4e85129c31@blackwall.org/ > is_local:1, > + locked:1, > + blackhole:1, > offloaded:1; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel