From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CDC8ECAAD1 for ; Sat, 27 Aug 2022 19:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yFP6ImySiJBxcHQnvqFcSKocNn3dpZnbrh7w+P06kxM=; b=P6tbdvgSNz6u29 T1h0okkv4+zHd+opfxAbPsbsHk4FC5e6/Z7zjC8MdaumE5tnXT10txyN8r8Ef7rPgoNjIO7KR5bLb tH9cnT6Q3OGZL/tPdU0YPBHhyRA3Ie4dGBHayRw8qQniDFEQJrzmfc2KhtNZnFa8Pd6+Nv1WSGD2c f02jkBOnlbatsmA7/EA8xZirWGFewUpRo+rukEgTq2CC5GVTVg9Ah0u4avc7gmhdWvpx2xBFGnDLQ YGk81i9yx6Rki/wmNHRfMhiOWvbvlE6VLioMLHlwzDNr8HJNcvTzr9YlR3ZRRX1pRdsCqntXPiWJv aijAdXtG66n2hdzQSzTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oS1Tt-0001Ug-0J; Sat, 27 Aug 2022 19:28:33 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oS1Tq-0001Tb-MO for linux-arm-kernel@lists.infradead.org; Sat, 27 Aug 2022 19:28:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=64hvREkNh53C/RDviN6vUPQLGsTZMfqdbVZdTxQHdgc=; b=HBVeLjjxnhb1n+GOr4/0fMgkc1 WoVAyTEjg2tvG5HSL4lF4fcaeff2C7FSUA2TsHYvFFUlWrYTo7+diaMW3P/MlP+lv18t3UCB1fIsI J6LwhvK08IPcvJX4AEm6zkz6qqOgrgy9aAhW+eggAEGqZYh4VfphzUMFn1G1gOA7Uv3E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oS1Th-00Enbk-4H; Sat, 27 Aug 2022 21:28:21 +0200 Date: Sat, 27 Aug 2022 21:28:21 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v3 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Message-ID: References: <20220826154650.615582-1-maxime.chevallier@bootlin.com> <20220826154650.615582-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220826154650.615582-2-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220827_122830_749283_9CC714C0 X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static void ipqess_get_strings(struct net_device *netdev, u32 stringset, > + u8 *data) > +{ > + u8 *p = data; > + u32 i; > + > + switch (stringset) { > + case ETH_SS_STATS: > + for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++) { > + memcpy(p, ipqess_stats[i].string, > + min((size_t)ETH_GSTRING_LEN, > + strlen(ipqess_stats[i].string) + 1)); That looks pretty similar to strlcpy(). > +static int ipqess_get_settings(struct net_device *netdev, > + struct ethtool_link_ksettings *cmd) It would be traditional to have the k in the name. > +{ > + struct ipqess *ess = netdev_priv(netdev); > + > + return phylink_ethtool_ksettings_get(ess->phylink, cmd); > +} > + > +static int ipqess_set_settings(struct net_device *netdev, > + const struct ethtool_link_ksettings *cmd) > +{ Here too. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F47ECAAD1 for ; Sat, 27 Aug 2022 19:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbiH0T22 (ORCPT ); Sat, 27 Aug 2022 15:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbiH0T21 (ORCPT ); Sat, 27 Aug 2022 15:28:27 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F9E54BA57; Sat, 27 Aug 2022 12:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=64hvREkNh53C/RDviN6vUPQLGsTZMfqdbVZdTxQHdgc=; b=HBVeLjjxnhb1n+GOr4/0fMgkc1 WoVAyTEjg2tvG5HSL4lF4fcaeff2C7FSUA2TsHYvFFUlWrYTo7+diaMW3P/MlP+lv18t3UCB1fIsI J6LwhvK08IPcvJX4AEm6zkz6qqOgrgy9aAhW+eggAEGqZYh4VfphzUMFn1G1gOA7Uv3E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oS1Th-00Enbk-4H; Sat, 27 Aug 2022 21:28:21 +0200 Date: Sat, 27 Aug 2022 21:28:21 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v3 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Message-ID: References: <20220826154650.615582-1-maxime.chevallier@bootlin.com> <20220826154650.615582-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220826154650.615582-2-maxime.chevallier@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > +static void ipqess_get_strings(struct net_device *netdev, u32 stringset, > + u8 *data) > +{ > + u8 *p = data; > + u32 i; > + > + switch (stringset) { > + case ETH_SS_STATS: > + for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++) { > + memcpy(p, ipqess_stats[i].string, > + min((size_t)ETH_GSTRING_LEN, > + strlen(ipqess_stats[i].string) + 1)); That looks pretty similar to strlcpy(). > +static int ipqess_get_settings(struct net_device *netdev, > + struct ethtool_link_ksettings *cmd) It would be traditional to have the k in the name. > +{ > + struct ipqess *ess = netdev_priv(netdev); > + > + return phylink_ethtool_ksettings_get(ess->phylink, cmd); > +} > + > +static int ipqess_set_settings(struct net_device *netdev, > + const struct ethtool_link_ksettings *cmd) > +{ Here too. Andrew