From: Leon Romanovsky <leon@kernel.org>
To: Shiraz Saleem <shiraz.saleem@intel.com>
Cc: jgg@nvidia.com, linux-rdma@vger.kernel.org,
Kamal Heib <kamalheib1@gmail.com>
Subject: Re: [PATCH for-rc] RDMA/irdma: Fix drain SQ hang with no completion
Date: Sun, 28 Aug 2022 12:44:18 +0300 [thread overview]
Message-ID: <Yws48tBf3aIv5Neo@unreal> (raw)
In-Reply-To: <20220824154358.117-1-shiraz.saleem@intel.com>
On Wed, Aug 24, 2022 at 10:43:59AM -0500, Shiraz Saleem wrote:
> SW generated completions for outstanding WRs posted on SQ
> after QP is in error target the wrong CQ. This causes the
> ib_drain_sq to hang with no completion.
>
> Fix this to generate completions on the right CQ.
>
> [ 863.969340] INFO: task kworker/u52:2:671 blocked for more than 122 seconds.
> [ 863.979224] Not tainted 5.14.0-130.el9.x86_64 #1
> [ 863.986588] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> [ 863.996997] task:kworker/u52:2 state:D stack: 0 pid: 671 ppid: 2 flags:0x00004000
> [ 864.007272] Workqueue: xprtiod xprt_autoclose [sunrpc]
> [ 864.014056] Call Trace:
> [ 864.017575] __schedule+0x206/0x580
> [ 864.022296] schedule+0x43/0xa0
> [ 864.026736] schedule_timeout+0x115/0x150
> [ 864.032185] __wait_for_common+0x93/0x1d0
> [ 864.037717] ? usleep_range_state+0x90/0x90
> [ 864.043368] __ib_drain_sq+0xf6/0x170 [ib_core]
> [ 864.049371] ? __rdma_block_iter_next+0x80/0x80 [ib_core]
> [ 864.056240] ib_drain_sq+0x66/0x70 [ib_core]
> [ 864.062003] rpcrdma_xprt_disconnect+0x82/0x3b0 [rpcrdma]
> [ 864.069365] ? xprt_prepare_transmit+0x5d/0xc0 [sunrpc]
> [ 864.076386] xprt_rdma_close+0xe/0x30 [rpcrdma]
> [ 864.082593] xprt_autoclose+0x52/0x100 [sunrpc]
> [ 864.088718] process_one_work+0x1e8/0x3c0
> [ 864.094170] worker_thread+0x50/0x3b0
> [ 864.099109] ? rescuer_thread+0x370/0x370
> [ 864.104473] kthread+0x149/0x170
> [ 864.109022] ? set_kthread_struct+0x40/0x40
> [ 864.114713] ret_from_fork+0x22/0x30
>
> Fixes: 81091d7696ae ("RDMA/irdma: Add SW mechanism to generate completions on error")
> Reported-by: Kamal Heib <kamalheib1@gmail.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks, applied.
prev parent reply other threads:[~2022-08-28 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:43 [PATCH for-rc] RDMA/irdma: Fix drain SQ hang with no completion Shiraz Saleem
2022-08-28 9:44 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yws48tBf3aIv5Neo@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.