From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Michael Guralnik <michaelgur@nvidia.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-rc] RDMA/cma: Fix arguments order in net device validation
Date: Mon, 29 Aug 2022 11:17:02 +0300 [thread overview]
Message-ID: <Ywx1/uZZUXrtgxOI@unreal> (raw)
In-Reply-To: <1c1ec2277a131d277ebcceec987fd338d35b775f.1661251872.git.leonro@nvidia.com>
On Tue, Aug 23, 2022 at 01:51:50PM +0300, Leon Romanovsky wrote:
> From: Michael Guralnik <michaelgur@nvidia.com>
>
> Fix the order of source and destination addresses when resolving the
> route between server and client to validate use of correct net device.
>
> The reverse order we had so far didn't actually validate the net device
> as the server would try to resolve the route to itself, thus always
> getting the server's net device.
>
> The issue was discovered when running cm applications on a single host
> between 2 interfaces with same subnet and source based routing rules.
> When resolving the reverse route the source based route rules were
> ignored.
>
> Fixes: f887f2ac87c2 ("IB/cma: Validate routing of incoming requests")
> Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/cma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Thanks, applied.
prev parent reply other threads:[~2022-08-29 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 10:51 [PATCH rdma-rc] RDMA/cma: Fix arguments order in net device validation Leon Romanovsky
2022-08-29 8:17 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywx1/uZZUXrtgxOI@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.