From: Mike Rapoport <rppt@kernel.org>
To: Song Chen <chensong_2000@189.cn>
Cc: karolinadrobnik@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] tools/testing/memblock: define pr_warn_ratelimited
Date: Mon, 29 Aug 2022 11:24:56 +0300 [thread overview]
Message-ID: <Ywx32C4/kE2WgR75@kernel.org> (raw)
In-Reply-To: <1661755140-3331-1-git-send-email-chensong_2000@189.cn>
On Mon, Aug 29, 2022 at 02:39:00PM +0800, Song Chen wrote:
> Commit 14d9a675fd0d("mm: Ratelimited mirrored memory related warning
> messages") introduced pr_warn_ratelimited in memblock.c, which breaks
> tools/test/memblock, below is the message:
>
> /usr/bin/ld: memblock.o: in function `memblock_find_in_range.constprop.0':
> memblock.c:(.text+0x4603): undefined reference to `pr_warn_ratelimited'
> /usr/bin/ld: memblock.o: in function `memblock_alloc_range_nid':
> memblock.c:(.text+0x786a): undefined reference to `pr_warn_ratelimited'
> collect2: error: ld returned 1 exit status
>
> A fake pr_warn_ratelimited needs to be defined in printk.h like other
> prink functions.
This is fixed by commit 0a7e91528202 ("memblock tests: fix compilation errors")
> Signed-off-by: Song Chen <chensong_2000@189.cn>
> ---
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2022-08-29 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 6:39 [PATCH 2/2] tools/testing/memblock: define pr_warn_ratelimited Song Chen
2022-08-29 8:24 ` Mike Rapoport [this message]
2022-08-29 8:32 ` Song Chen
2022-08-29 8:45 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywx32C4/kE2WgR75@kernel.org \
--to=rppt@kernel.org \
--cc=chensong_2000@189.cn \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.