From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Adri??n Larumbe <adrian.larumbe@collabora.com>
Cc: alyssa.rosenzweig@collabora.com, dri-devel@lists.freedesktop.org,
steven.price@arm.com
Subject: Re: [PATCH] drm/panfrost: Give name to anonymous coredump object union
Date: Mon, 12 Sep 2022 18:59:37 -0400 [thread overview]
Message-ID: <Yx+52RO7cmClypn2@maud> (raw)
In-Reply-To: <20220912164413.2181937-1-adrian.larumbe@collabora.com>
Have we checked that this actually fixes the Mesa build? If so, R-b.
> Commit 730c2bf4ad39 ("drm/panfrost: Add support for devcoredump")
> introduces one such union, breaking the Mesa build.
>
> Give it a name, and also rename pan_reg_hdr structure because it will
> always be prefixed by the union name.
>
> Bug: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7195
>
> Signed-off-by: Adri??n Larumbe <adrian.larumbe@collabora.com>
In Mesa, we would add a trailer "Fixes: 730c2bf4ad39 ("drm/panfrost: Add
support for devcoredump")". If the kernel does the same (I don't
remember), we should do that here, seeing as the panfrost uapi headers
do need to build as C++.
next prev parent reply other threads:[~2022-09-12 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 16:44 [PATCH] drm/panfrost: Give name to anonymous coredump object union Adrián Larumbe
2022-09-12 22:59 ` Alyssa Rosenzweig [this message]
2022-09-13 8:45 ` Steven Price
2022-09-19 6:44 ` Adrián Larumbe
2022-09-20 13:26 ` Steven Price
2022-09-20 14:58 ` Alyssa Rosenzweig
2022-09-20 21:15 ` [PATCH 1/2] drm/panfrost: Remove type name from internal structs Adrián Larumbe
2022-09-20 21:15 ` [PATCH 2/2] drm/panfrost: replace endian-specific types with generic ones Adrián Larumbe
2022-09-20 22:13 ` Alyssa Rosenzweig
2022-09-21 8:48 ` Steven Price
2022-09-21 9:55 ` Robin Murphy
2022-09-21 12:26 ` Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx+52RO7cmClypn2@maud \
--to=alyssa@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.