From: Jules Irenge <jbi.octave@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] fs: Add missing annotation for __wait_on_freeing_inode()
Date: Sun, 11 Sep 2022 22:09:26 +0100 [thread overview]
Message-ID: <Yx5OhttjvyPDPB7B@playground> (raw)
Sparse reports a warning at __wait_on_freeing_inode()
warning: context imbalance in __wait_on_freeing_inode - unexpected unlock
The root cause is a missing annotation at __wait_on_freeing_inode()
Add the missing __releases(&inode->i_lock)
__must_hold(&inode_hash_lock) annotations
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
fs/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/inode.c b/fs/inode.c
index a1dd9a976add..b3ef550227b6 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2219,6 +2219,7 @@ EXPORT_SYMBOL(inode_needs_sync);
* will DTRT.
*/
static void __wait_on_freeing_inode(struct inode *inode)
+ __releases(&inode->i_lock) __must_hold(&inode_hash_lock)
{
wait_queue_head_t *wq;
DEFINE_WAIT_BIT(wait, &inode->i_state, __I_NEW);
--
2.35.1
reply other threads:[~2022-09-11 21:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx5OhttjvyPDPB7B@playground \
--to=jbi.octave@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.