From: Jacob Stopak <jacob@initialcommit.io>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] Documentation: fix various repeat word typos
Date: Mon, 12 Sep 2022 10:58:05 -0700 [thread overview]
Message-ID: <Yx9zLYf3AmkiVn3S.jacob@initialcommit.io> (raw)
In-Reply-To: <xmqq1qsgh8n0.fsf@gitster.g>
On Mon, Sep 12, 2022 at 09:14:59AM -0700, Junio C Hamano wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
> > On Sun, Sep 11, 2022 at 6:26 AM Jacob Stopak <jacob@initialcommit.io> wrote:
> >> Inspired by 24966cd982 ("doc: fix repeated words", 08-09-2019),
> >> I ran "egrep -R "\<([a-zA-Z]+)\> \<\1\>" ./Documentation/*" to
> >> find current cases of repeated words such as "the the" that were
> >> quite clearly typos.
> >>
> >> There were many false positives reported, such as "really really"
> >> or valid uses of "that that" which I left alone.
> >>
> >> Signed-off-by: Jacob Stopak <jacob@initialcommit.io>
> >> ---
> >> diff --git a/Documentation/howto/keep-canonical-history-correct.txt b/Documentation/howto/keep-canonical-history-correct.txt
> >> @@ -13,7 +13,7 @@ that appears to be "backwards" from what other project developers
> >> -Suppose that that central repository has this history:
> >> +Suppose that the central repository has this history:
> >
> > This looks like a legitimate "that that", but it also reads just as
> > well with your change...
> >
> > The the rest rest of of the the patch patch looks looks fine fine.
>
> Yup, that matches the result of my scanning, too. Thanks for being
> a careful reviewer.
>
Thank you both! Should I submit a v2 patch to undo the change to
"that that"? Or is it ok as is?
Best,
Jack
next prev parent reply other threads:[~2022-09-12 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 10:23 [PATCH 0/1] Documentation: fix various repeat word typos Jacob Stopak
2022-09-11 10:23 ` [PATCH 1/1] " Jacob Stopak
2022-09-11 16:36 ` Eric Sunshine
2022-09-12 16:14 ` Junio C Hamano
2022-09-12 17:58 ` Jacob Stopak [this message]
2022-09-12 18:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx9zLYf3AmkiVn3S.jacob@initialcommit.io \
--to=jacob@initialcommit.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.