Re: [LTP] [PATCH] README: Add missing configure in openposix step

[Petr Vorel <pvorel@suse.cz>]

Hi Xu,

[ Cc Joerg ]

> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
> , we need to use configure firstly.

nit: there should be Fixes: below:
Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")

Then you can use just 8071ba7 in the text.

> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  README.md | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

> diff --git a/README.md b/README.md
> index d45d1ee44..d0ca5f4d4 100644
> --- a/README.md
> +++ b/README.md
> @@ -79,11 +79,13 @@ $ cd ../commands/foo
>  $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
>  ```

> -Open Posix Testsuite has it's own build system which needs Makefiles to be
> -generated first, then compilation should work in subdirectories as well.
> +Open Posix Testsuite has it's own configure and build system which needs
> +Makefiles to be generated first, then compilation should work in subdirectories
> +as well.

>  ```
>  $ cd testcases/open_posix_testsuite/

You miss:
$ make autotools
as this creates configure

> +$ ./configure
But if you run make autotools && ./configure in the top level, none of these two
is needed to be run in open posix directory. Maybe document it (not sure about
the comments)?

$ [ -f ./configure ] || make autotools # not needed if run in the top level
$ [ -f include/mk/config.mk ] || ./configure # not needed if the top level configure is run

Kind regards,
Petr

>  $ make generate-makefiles
>  $ cd conformance/interfaces/foo
>  $ make

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp