From: Jason Gunthorpe <jgg@nvidia.com>
To: joao.m.martins@oracle.com
Cc: Alex Williamson <alex.williamson@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
saeedm@nvidia.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
kuba@kernel.org, kevin.tian@intel.com, leonro@nvidia.com,
maorg@nvidia.com, cohuck@redhat.com
Subject: Re: [PATCH V5 vfio 04/10] vfio: Add an IOVA bitmap support
Date: Thu, 1 Sep 2022 20:15:13 -0300 [thread overview]
Message-ID: <YxE9Aco0Wz2vBYfF@nvidia.com> (raw)
In-Reply-To: <b3916258-bd64-5cc8-7cbe-f7338a96bf58@oracle.com>
On Thu, Sep 01, 2022 at 08:39:40PM +0100, joao.m.martins@oracle.com wrote:
> > There's no sanity testing here that the caller provided an iova within
> > the mapped ranged. Thanks,
> >
>
> Much of the bitmap helpers don't check that the offset is within the range
> of the passed ulong array. So I followed the same thinking and the
> caller is /provided/ with the range that the IOVA bitmap covers. The intention
> was minimizing the number of operations given that this function sits on the
> hot path. I can add this extra check.
I wouldn't add sanity testing on these hot paths..
Jason
next prev parent reply other threads:[~2022-09-01 23:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 9:38 [PATCH V5 vfio 00/10] Add device DMA logging support for mlx5 driver Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 01/10] net/mlx5: Introduce ifc bits for page tracker Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 02/10] net/mlx5: Query ADV_VIRTUALIZATION capabilities Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 03/10] vfio: Introduce DMA logging uAPIs Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 04/10] vfio: Add an IOVA bitmap support Yishai Hadas
2022-09-01 18:47 ` Alex Williamson
2022-09-01 19:39 ` joao.m.martins
2022-09-01 20:36 ` Alex Williamson
2022-09-01 23:16 ` Jason Gunthorpe
2022-09-02 17:53 ` Joao Martins
2022-09-02 9:42 ` Joao Martins
2022-09-01 23:15 ` Jason Gunthorpe [this message]
2022-09-02 5:30 ` kernel test robot
2022-09-01 9:38 ` [PATCH V5 vfio 05/10] vfio: Introduce the DMA logging feature support Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 06/10] vfio/mlx5: Init QP based resources for dirty tracking Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 07/10] vfio/mlx5: Create and destroy page tracker object Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 08/10] vfio/mlx5: Report dirty pages from tracker Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 09/10] vfio/mlx5: Manage error scenarios on tracker Yishai Hadas
2022-09-01 9:38 ` [PATCH V5 vfio 10/10] vfio/mlx5: Set the driver DMA logging callbacks Yishai Hadas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxE9Aco0Wz2vBYfF@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=maorg@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.