All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: GUO Zihua <guozihua@huawei.com>
Cc: linux-staging@lists.linux.dev, Larry.Finger@lwfinger.net,
	phil@philpotter.co.uk, paskripkin@gmail.com
Subject: Re: [RESEND PATCH] staging: r8188eu: Fix return type for implementation of ndo_start_xmit
Date: Fri, 2 Sep 2022 10:25:48 +0200	[thread overview]
Message-ID: <YxG+DNzyUcPIjXZC@kroah.com> (raw)
In-Reply-To: <20220902081653.60682-1-guozihua@huawei.com>

On Fri, Sep 02, 2022 at 04:16:53PM +0800, GUO Zihua wrote:
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this might get
> cought out by CFI and cause a panic.
> 
> Use enums from netdev_tx_t as return value instead, then change return
> type to netdev_tx_t.
> 
> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> ---
>  drivers/staging/r8188eu/include/xmit_osdep.h | 2 +-
>  drivers/staging/r8188eu/os_dep/xmit_linux.c  | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Why is this and the other commits, marked as RESEND?

And any reason you didn't cc: the staging maintainer on this commit?

confused,

greg k-h

  reply	other threads:[~2022-09-02  8:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02  8:16 [RESEND PATCH] staging: r8188eu: Fix return type for implementation of ndo_start_xmit GUO Zihua
2022-09-02  8:25 ` Greg KH [this message]
2022-09-05  1:23   ` Guozihua (Scott)
2022-09-05  5:16     ` Greg KH
2022-09-05 13:08       ` Guozihua (Scott)
2022-09-02  9:10 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxG+DNzyUcPIjXZC@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=guozihua@huawei.com \
    --cc=linux-staging@lists.linux.dev \
    --cc=paskripkin@gmail.com \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.