From: Baoquan He <bhe@redhat.com>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Song Liu <song@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments
Date: Sat, 3 Sep 2022 09:54:22 +0800 [thread overview]
Message-ID: <YxKzzsyK99bwnbAy@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CA+KHdyWijMSuNaT4vQ-tqyrJC_GxL++rDj-s1WZMkDi=8m3p1A@mail.gmail.com>
On 09/02/22 at 06:45pm, Uladzislau Rezki wrote:
> > > Even without this patch, the debug path would work correctly. The
> > > difference is just only in
> > > whether roots are hardcoded or passed over function paramter.
> >
> > Calling find_vmap_lowest_match() inside find_vmap_lowest_match_check()
> > will fail compilation because the function interface has been changed.
> >
> Ah. That makes sense, though the commit message has to reflect it.
> So it is only about compilation error if debug is ON.
Indeed, the current patch log sounds like an improvement or normal change.
In fact it's a code fix.
next prev parent reply other threads:[~2022-09-03 1:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 5:27 [PATCH] mm/vmalloc: Extend find_vmap_lowest_match_check with extra arguments Song Liu
2022-08-31 7:37 ` Baoquan He
2022-08-31 15:34 ` Uladzislau Rezki
2022-08-31 23:01 ` Andrew Morton
2022-09-01 0:47 ` Song Liu
2022-09-01 12:16 ` Uladzislau Rezki
2022-09-02 3:39 ` Baoquan He
2022-09-02 16:45 ` Uladzislau Rezki
2022-09-03 1:54 ` Baoquan He [this message]
2022-09-04 9:36 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxKzzsyK99bwnbAy@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.