From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A39F3ECAAD5 for ; Mon, 5 Sep 2022 00:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZC9LMoTVC0OB0H/zaaEGCx6zmKih0BATkfUtv87LMeY=; b=X0QgIwhvll3vnr PdWQF/bLPAYkBQzlsiDps13+o26wzXMdo+wM9a5gdzVmX7G/YOkT4l2npaWGFWz2h150Il4VMlZrC tboaqF9jz3iEAFrwNNP+1tXWATLpGEPHbswemXTh6aXinMEzn3mScqrwUhC8GUmzC4t6DOu0IRDdF /RCNi+REhgdDHnrfj+Zwm2Mx8seD3aK7XGCbntKcfZTm8sFesC7KzEuH6vByLa88JCps9ed8HffSv WUwYlaJL4KYlpLHIrm4RxgfwTtTFi4Ig3Z47ADcR7ivoDGrqL0vITERDobE9OGf3srem5+nZFuSK/ ec2l4UinCskobQTJKTLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUzYh-000ZCN-JX; Mon, 05 Sep 2022 00:01:47 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oUyDv-00EOTp-1I for linux-phy@lists.infradead.org; Sun, 04 Sep 2022 22:36:18 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F62B6BC; Mon, 5 Sep 2022 00:36:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662330967; bh=tC8edg18APeJ5A7lmZCWV3tJ5z6EbUjWKD+4WsZ5GL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHdxmti4uhTPNLDCnSuFAi7XGEcm3J67H/1vEhrc5NjL5PpH2sHossX3IYYy7Sw58 8vlwv07r8lhQ+KmKfwrSbireAIG8A0hDB2NqLjlYXArjiKGuyfovUY/QPy+9VNI8TF g+2ecumJwvT5qChsEFV5YJtUSE7SilGqGGQkjG6w= Date: Mon, 5 Sep 2022 01:35:53 +0300 From: Laurent Pinchart To: Marco Felsch Cc: mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, kishon@ti.com, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl, jacopo@jmondi.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 3/4] media: dt-bindings: add bindings for Toshiba TC358746 Message-ID: References: <20220818143307.967150-1-m.felsch@pengutronix.de> <20220818143307.967150-4-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220818143307.967150-4-m.felsch@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220904_153615_550004_48079BF9 X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org SGkgTWFyY28sCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFRodSwgQXVnIDE4LCAyMDIy IGF0IDA0OjMzOjA2UE0gKzAyMDAsIE1hcmNvIEZlbHNjaCB3cm90ZToKPiBBZGQgdGhlIGJpbmRp bmdzIGZvciB0aGUgVG9zaGliYSBUQzM1ODc0NiBQYXJhbGxlbCA8LT4gTUlQSS1DU0kgYnJpZGdl Cj4gZHJpdmVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hcmNvIEZlbHNjaCA8bS5mZWxzY2hAcGVu Z3V0cm9uaXguZGU+Cj4gLS0tCj4gIC4uLi9iaW5kaW5ncy9tZWRpYS9pMmMvdG9zaGliYSx0YzM1 ODc0Ni55YW1sICB8IDE1NyArKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE1 NyBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvbWVkaWEvaTJjL3Rvc2hpYmEsdGMzNTg3NDYueWFtbAo+IAo+IGRpZmYg LS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvaTJjL3Rvc2hp YmEsdGMzNTg3NDYueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRp YS9pMmMvdG9zaGliYSx0YzM1ODc0Ni55YW1sCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRl eCAwMDAwMDAwMDAwMDAuLjk3ODNjY2EzNjNjNgo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvaTJjL3Rvc2hpYmEsdGMzNTg3NDYu eWFtbAo+IEBAIC0wLDAgKzEsMTU3IEBACj4gKyMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChH UEwtMi4wLW9ubHkgT1IgQlNELTItQ2xhdXNlKQo+ICslWUFNTCAxLjIKPiArLS0tCj4gKyRpZDog aHR0cDovL2RldmljZXRyZWUub3JnL3NjaGVtYXMvbWVkaWEvaTJjL3Rvc2hpYmEsdGMzNTg3NDYu eWFtbCMKPiArJHNjaGVtYTogaHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2NoZW1hcy9jb3Jl LnlhbWwjCj4gKwo+ICt0aXRsZTogVG9zaGliYSBUQzM1ODc0NiBQYXJhbGxlbCB0byBNSVBJIENT STIgQnJpZGdlCj4gKwo+ICttYWludGFpbmVyczoKPiArICAtIE1hcmNvIEZlbHNjaCA8a2VybmVs QHBlbmd1dHJvbml4LmRlPgo+ICsKPiArZGVzY3JpcHRpb246IHwtCj4gKyAgVGhlIFRvc2hpYmEg VEMzNTg3NDYgY29udmVydHMgYSBwYXJhbGxlbCB2aWRlbyBzdHJlYW0gaW50byBhIE1JUEkgQ1NJ LTIKPiArICBzdHJlYW0uIFRoZSBkaXJlY3Rpb24gY2FuIGJlIGVpdGhlciBwYXJhbGxlbC1pbiAt PiBjc2ktb3V0IG9yIGNzaS1pbiAtPgo+ICsgIHBhcmFsbGVsLW91dCBUaGUgY2hpcCBpcyBwcm9n cmFtbWFibGUgdHJvdWdoIEkyQyBhbmQgU1BJIGJ1dCB0aGUgU1BJCj4gKyAgaW50ZXJmYWNlIGlz IG9ubHkgc3VwcG9ydGVkIGluIHBhcmFsbGVsLWluIC0+IGNzaS1vdXQgbW9kZS4KPiArCj4gKyAg Tm90ZSB0aGF0IHRoZSBjdXJyZW50IGRldmljZSB0cmVlIGJpbmRpbmdzIG9ubHkgc3VwcG9ydCB0 aGUKPiArICBwYXJhbGxlbC1pbiAtPiBjc2ktb3V0IHBhdGguCj4gKwo+ICtwcm9wZXJ0aWVzOgo+ ICsgIGNvbXBhdGlibGU6Cj4gKyAgICBjb25zdDogdG9zaGliYSx0YzM1ODc0Ngo+ICsKPiArICBy ZWc6Cj4gKyAgICBtYXhJdGVtczogMQo+ICsKPiArICBjbG9ja3M6Cj4gKyAgICBkZXNjcmlwdGlv bjoKPiArICAgICAgVGhlIHBoYW5kbGUgdG8gdGhlIHJlZmVyZW5jZSBjbG9jayBzb3VyY2UuIFRo aXMgY29ycmVzcG9uZHMgdG8gdGhlCj4gKyAgICAgIGhhcmR3YXJlIHBpbiBSRUZDTEsuCj4gKyAg ICBtYXhJdGVtczogMQo+ICsKPiArICBjbG9jay1uYW1lczoKPiArICAgIGNvbnN0OiByZWZjbGsK CkFzIHRoZXJlJ3MgYSBzaW5nbGUgY2xvY2ssIHNob3VsZCB3ZSBvbWl0IHRoZSBjbG9jayBuYW1l ID8KCj4gKwo+ICsjIFRoZSBicmlkZ2UgY2FuIGFjdCBhcyBjbG9jayBwcm92aWRlciBmb3IgdGhl IHNlbnNvci4gVG8gZW5hYmxlIHRoaXMgc3VwcG9ydAo+ICsjICNjbG9jay1jZWxscyBtdXN0IGJl IHNwZWNpZmllZC4gQXR0ZW50aW9uIGlmIHRoaXMgZmVhdHVyZSBpcyB1c2VkIHRoYW4gdGhlCgpz L3RoYW4vdGhlbi8KCj4gKyMgbWNsayByYXRlIG11c3QgYmUgYXQgbGVhc3Q6ICgyICogbGluay1m cmVxdWVuY3kpIC8gOAo+ICsjICAgICAgICAgICAgICAgICAgICAgICAgICAgICBgLS0tLS0tLS0t LS0tLS0tLS0twrQgICBeCj4gKyMgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludGVybmFs IFBMTCByYXRlICAgc21hbGxlc3QgcG9zc2libGUgbWNsay1kaXYKCkNvdWxkIHRoaXMgYmUgY2Fw dHVyZWQgaW4gdGhlIGRlc2NyaXB0aW9uIG9mIHRoZSBwcm9wZXJ0eSBpbnN0ZWFkIG9mIGEKY29t bWVudCA/Cgo+ICsgICIjY2xvY2stY2VsbHMiOgo+ICsgICAgY29uc3Q6IDAKPiArCj4gKyAgY2xv Y2stb3V0cHV0LW5hbWVzOgo+ICsgICAgZGVzY3JpcHRpb246Cj4gKyAgICAgIFRoZSBjbG9jayBu YW1lIG9mIHRoZSBNQ0xLIG91dHB1dCwgdGhlIGRlZmF1bHQgbmFtZSBpcyB0YzM1ODc0Ni1tY2xr Lgo+ICsgICAgbWF4SXRlbXM6IDEKPiArCj4gKyAgdmRkYy1zdXBwbHk6Cj4gKyAgICBkZXNjcmlw dGlvbjogRGlnaXRhbCBjb3JlIHZvbHRhZ2Ugc3VwcGx5LCAxLjIgdm9sdHMKPiArCj4gKyAgdmRk aW8tc3VwcGx5Ogo+ICsgICAgZGVzY3JpcHRpb246IERpZ2l0YWwgSS9PIHZvbHRhZ2Ugc3VwcGx5 LCAxLjggdm9sdHMKPiArCj4gKyAgdmRkbWlwaS1zdXBwbHk6Cj4gKyAgICBkZXNjcmlwdGlvbjog TUlQSSBDU0kgcGh5IHZvbHRhZ2Ugc3VwcGx5LCAxLjIgdm9sdHMKPiArCj4gKyAgcmVzZXQtZ3Bp b3M6Cj4gKyAgICBkZXNjcmlwdGlvbjoKPiArICAgICAgVGhlIHBoYW5kbGUgYW5kIHNwZWNpZmll ciBmb3IgdGhlIEdQSU8gdGhhdCBjb250cm9scyB0aGUgY2hpcCByZXNldC4KPiArICAgICAgVGhp cyBjb3JyZXNwb25kcyB0byB0aGUgaGFyZHdhcmUgcGluIFJFU1ggd2hpY2ggaXMgcGh5c2ljYWxs eSBhY3RpdmUgbG93Lgo+ICsgICAgbWF4SXRlbXM6IDEKPiArCj4gKyAgcG9ydHM6Cj4gKyAgICAk cmVmOiAvc2NoZW1hcy9ncmFwaC55YW1sIy9wcm9wZXJ0aWVzL3BvcnRzCj4gKyAgICBwcm9wZXJ0 aWVzOgo+ICsgICAgICBwb3J0QDA6Cj4gKyAgICAgICAgJHJlZjogL3NjaGVtYXMvZ3JhcGgueWFt bCMvcHJvcGVydGllcy9wb3J0Cj4gKyAgICAgICAgZGVzY3JpcHRpb246IElucHV0IHBvcnQKCkFy ZSB0aGUgSC9WIHN5bmMgc2lnbmFsIHBvbGFyaXRpZXMgZml4ZWQsIG9yIHNob3VsZCB0aGV5IGJl IHNwZWNpZmllZApoZXJlID8gRG9lcyB0aGUgY2hpcCBzdXBwb3J0IGV4dGVybmFsIHN5bmMgb25s eSwgb3IgYWxzbyBCVC42NTYgPyBJbiB0aGUKbGF0dGVyIGNhc2UgdGhpcyBuZWVkcyBhIGJ1cy10 eXBlLgoKPiArCj4gKyAgICAgIHBvcnRAMToKPiArICAgICAgICAkcmVmOiAvc2NoZW1hcy9ncmFw aC55YW1sIy8kZGVmcy9wb3J0LWJhc2UKPiArICAgICAgICBkZXNjcmlwdGlvbjogT3V0cHV0IHBv cnQKPiArCj4gKyAgICAgICAgcHJvcGVydGllczoKPiArICAgICAgICAgIGVuZHBvaW50Ogo+ICsg ICAgICAgICAgICAkcmVmOiAvc2NoZW1hcy9tZWRpYS92aWRlby1pbnRlcmZhY2VzLnlhbWwjCj4g KyAgICAgICAgICAgIHVuZXZhbHVhdGVkUHJvcGVydGllczogZmFsc2UKPiArCj4gKyAgICAgICAg ICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgICAgICAgZGF0YS1sYW5lczoKPiArICAgICAgICAg ICAgICAgIG1pbkl0ZW1zOiAxCj4gKyAgICAgICAgICAgICAgICBtYXhJdGVtczogNAo+ICsKPiAr ICAgICAgICAgICAgICBjbG9jay1ub25jb250aW51b3VzOiB0cnVlCj4gKyAgICAgICAgICAgICAg bGluay1mcmVxdWVuY2llczogdHJ1ZQo+ICsKPiArICAgICAgICAgICAgcmVxdWlyZWQ6Cj4gKyAg ICAgICAgICAgICAgLSBkYXRhLWxhbmVzCj4gKyAgICAgICAgICAgICAgLSBsaW5rLWZyZXF1ZW5j aWVzCj4gKwo+ICsgICAgcmVxdWlyZWQ6Cj4gKyAgICAgIC0gcG9ydEAwCj4gKyAgICAgIC0gcG9y dEAxCj4gKwo+ICtyZXF1aXJlZDoKPiArICAtIGNvbXBhdGlibGUKPiArICAtIHJlZwo+ICsgIC0g Y2xvY2tzCj4gKyAgLSBjbG9jay1uYW1lcwo+ICsgIC0gdmRkYy1zdXBwbHkKPiArICAtIHZkZGlv LXN1cHBseQo+ICsgIC0gdmRkbWlwaS1zdXBwbHkKPiArICAtIHBvcnRzCj4gKwo+ICthZGRpdGlv bmFsUHJvcGVydGllczogZmFsc2UKPiArCj4gK2V4YW1wbGVzOgo+ICsgIC0gfAo+ICsgICAgI2lu Y2x1ZGUgPGR0LWJpbmRpbmdzL2dwaW8vZ3Bpby5oPgo+ICsKPiArICAgIGkyYyB7Cj4gKyAgICAg ICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICsgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiArCj4g KyAgICAgIGNzaS1icmlkZ2VAZSB7Cj4gKyAgICAgICAgY29tcGF0aWJsZSA9ICJ0b3NoaWJhLHRj MzU4NzQ2IjsKPiArICAgICAgICByZWcgPSA8MHhlPjsKPiArCj4gKyAgICAgICAgY2xvY2tzID0g PCZyZWZjbGs+Owo+ICsgICAgICAgIGNsb2NrLW5hbWVzID0gInJlZmNsayI7Cj4gKwo+ICsgICAg ICAgIHJlc2V0LWdwaW9zID0gPCZncGlvIDIgR1BJT19BQ1RJVkVfTE9XPjsKPiArCj4gKyAgICAg ICAgdmRkYy1zdXBwbHkgPSA8JnYxXzJkPjsKPiArICAgICAgICB2ZGRpby1zdXBwbHkgPSA8JnYx XzhkPjsKPiArICAgICAgICB2ZGRtaXBpLXN1cHBseSA9IDwmdjFfMmQ+Owo+ICsKPiArICAgICAg ICAvKiBzZW5zb3IgbWNsayBwcm92aWRlciAqLwo+ICsgICAgICAgICNjbG9jay1jZWxscyA9IDww PjsKPiArCj4gKyAgICAgICAgcG9ydHMgewo+ICsgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8 MT47Cj4gKyAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiArCj4gKyAgICAgICAgICAvKiBJ bnB1dCAqLwo+ICsgICAgICAgICAgcG9ydEAwIHsKPiArICAgICAgICAgICAgcmVnID0gPDA+Owo+ ICsgICAgICAgICAgICB0YzM1ODc0Nl9pbjogZW5kcG9pbnQgewo+ICsgICAgICAgICAgICAgIHJl bW90ZS1lbmRwb2ludCA9IDwmc2Vuc29yX291dD47Cj4gKyAgICAgICAgICAgICAgfTsKCldyb25n IGluZGVudGF0aW9uIGhlcmUuCgo+ICsgICAgICAgICAgfTsKPiArCj4gKyAgICAgICAgICAvKiBP dXRwdXQgKi8KPiArICAgICAgICAgIHBvcnRAMSB7Cj4gKyAgICAgICAgICAgIHJlZyA9IDwxPjsK PiArICAgICAgICAgICAgdGMzNTg3NDZfb3V0OiBlbmRwb2ludCB7Cj4gKyAgICAgICAgICAgICAg cmVtb3RlLWVuZHBvaW50ID0gPCZtaXBpX2NzaTJfaW4+Owo+ICsgICAgICAgICAgICAgIGRhdGEt bGFuZXMgPSA8MSAyPjsKPiArICAgICAgICAgICAgICBjbG9jay1ub25jb250aW51b3VzOwo+ICsg ICAgICAgICAgICAgIGxpbmstZnJlcXVlbmNpZXMgPSAvYml0cy8gNjQgPDIxNjAwMDAwMD47Cj4g KyAgICAgICAgICAgIH07Cj4gKyAgICAgICAgICB9Owo+ICsgICAgICAgIH07Cj4gKyAgICAgIH07 Cj4gKyAgICB9OwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgotLSAKbGludXgtcGh5 IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744DBECAAD5 for ; Sun, 4 Sep 2022 22:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232064AbiIDWgO (ORCPT ); Sun, 4 Sep 2022 18:36:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231989AbiIDWgO (ORCPT ); Sun, 4 Sep 2022 18:36:14 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A00B326138; Sun, 4 Sep 2022 15:36:09 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F62B6BC; Mon, 5 Sep 2022 00:36:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662330967; bh=tC8edg18APeJ5A7lmZCWV3tJ5z6EbUjWKD+4WsZ5GL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHdxmti4uhTPNLDCnSuFAi7XGEcm3J67H/1vEhrc5NjL5PpH2sHossX3IYYy7Sw58 8vlwv07r8lhQ+KmKfwrSbireAIG8A0hDB2NqLjlYXArjiKGuyfovUY/QPy+9VNI8TF g+2ecumJwvT5qChsEFV5YJtUSE7SilGqGGQkjG6w= Date: Mon, 5 Sep 2022 01:35:53 +0300 From: Laurent Pinchart To: Marco Felsch Cc: mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, kishon@ti.com, sakari.ailus@linux.intel.com, hverkuil@xs4all.nl, jacopo@jmondi.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 3/4] media: dt-bindings: add bindings for Toshiba TC358746 Message-ID: References: <20220818143307.967150-1-m.felsch@pengutronix.de> <20220818143307.967150-4-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220818143307.967150-4-m.felsch@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marco, Thank you for the patch. On Thu, Aug 18, 2022 at 04:33:06PM +0200, Marco Felsch wrote: > Add the bindings for the Toshiba TC358746 Parallel <-> MIPI-CSI bridge > driver. > > Signed-off-by: Marco Felsch > --- > .../bindings/media/i2c/toshiba,tc358746.yaml | 157 ++++++++++++++++++ > 1 file changed, 157 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml > new file mode 100644 > index 000000000000..9783cca363c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.yaml > @@ -0,0 +1,157 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/toshiba,tc358746.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba TC358746 Parallel to MIPI CSI2 Bridge > + > +maintainers: > + - Marco Felsch > + > +description: |- > + The Toshiba TC358746 converts a parallel video stream into a MIPI CSI-2 > + stream. The direction can be either parallel-in -> csi-out or csi-in -> > + parallel-out The chip is programmable trough I2C and SPI but the SPI > + interface is only supported in parallel-in -> csi-out mode. > + > + Note that the current device tree bindings only support the > + parallel-in -> csi-out path. > + > +properties: > + compatible: > + const: toshiba,tc358746 > + > + reg: > + maxItems: 1 > + > + clocks: > + description: > + The phandle to the reference clock source. This corresponds to the > + hardware pin REFCLK. > + maxItems: 1 > + > + clock-names: > + const: refclk As there's a single clock, should we omit the clock name ? > + > +# The bridge can act as clock provider for the sensor. To enable this support > +# #clock-cells must be specified. Attention if this feature is used than the s/than/then/ > +# mclk rate must be at least: (2 * link-frequency) / 8 > +# `------------------ยด ^ > +# internal PLL rate smallest possible mclk-div Could this be captured in the description of the property instead of a comment ? > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + description: > + The clock name of the MCLK output, the default name is tc358746-mclk. > + maxItems: 1 > + > + vddc-supply: > + description: Digital core voltage supply, 1.2 volts > + > + vddio-supply: > + description: Digital I/O voltage supply, 1.8 volts > + > + vddmipi-supply: > + description: MIPI CSI phy voltage supply, 1.2 volts > + > + reset-gpios: > + description: > + The phandle and specifier for the GPIO that controls the chip reset. > + This corresponds to the hardware pin RESX which is physically active low. > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input port Are the H/V sync signal polarities fixed, or should they be specified here ? Does the chip support external sync only, or also BT.656 ? In the latter case this needs a bus-type. > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + description: Output port > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + clock-noncontinuous: true > + link-frequencies: true > + > + required: > + - data-lanes > + - link-frequencies > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - vddc-supply > + - vddio-supply > + - vddmipi-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + csi-bridge@e { > + compatible = "toshiba,tc358746"; > + reg = <0xe>; > + > + clocks = <&refclk>; > + clock-names = "refclk"; > + > + reset-gpios = <&gpio 2 GPIO_ACTIVE_LOW>; > + > + vddc-supply = <&v1_2d>; > + vddio-supply = <&v1_8d>; > + vddmipi-supply = <&v1_2d>; > + > + /* sensor mclk provider */ > + #clock-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* Input */ > + port@0 { > + reg = <0>; > + tc358746_in: endpoint { > + remote-endpoint = <&sensor_out>; > + }; Wrong indentation here. > + }; > + > + /* Output */ > + port@1 { > + reg = <1>; > + tc358746_out: endpoint { > + remote-endpoint = <&mipi_csi2_in>; > + data-lanes = <1 2>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <216000000>; > + }; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart