From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Varsha Teratipally <teratipally@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Davidlohr Bueso <dbueso@suse.de>,
Rafael Aquini <aquini@redhat.com>,
Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: Request to cherry-pick 20401d1058f3f841f35a594ac2fc1293710e55b9 to v5.10 and v5.4
Date: Mon, 5 Sep 2022 07:20:10 +0200 [thread overview]
Message-ID: <YxWHChQpxs9LrCpl@kroah.com> (raw)
In-Reply-To: <b94f08a6-a2e2-c719-37ac-7c412fe1b519@colorfullife.com>
On Sun, Sep 04, 2022 at 07:38:30PM +0200, Manfred Spraul wrote:
> Hi,
>
> On 9/2/22 16:27, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 01:59:11PM +0000, Varsha Teratipally wrote:
> > > Hi all,
> > >
> > > Commit 20401d1058f3f841f35a594ac2fc1293710e55b9("ipc: replace costly
> > > bailout check in sysvipc_find_ipc()" fixes a high cve and optimizes the
> > > costly loop by adding a checkpoint, which I think might be a good
> > > candidate for the stable branches
> > What do you mean by "high cve"?
> >
> > And that feels like it's an artificial benchmark fixup, what real
> > workload benefits from this change?
>
> Standard ipcs end up parsing /proc/sysvipc/*, thus there are real users
> where the performance of /proc/sysvsem/* matters.
What real users are that? What workload needs that becides monitoring
tools?
>
> But:
>
> The performance of the function was bad since 2007, i.e. why is is now
> urgent? I do not see a bug that must be fixed.
Me either.
thanks,
greg k-h
prev parent reply other threads:[~2022-09-05 5:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 13:59 Request to cherry-pick 20401d1058f3f841f35a594ac2fc1293710e55b9 to v5.10 and v5.4 Varsha Teratipally
2022-09-02 13:59 ` [PATCH] ipc: replace costly bailout check in sysvipc_find_ipc() Varsha Teratipally
2022-09-02 14:41 ` kernel test robot
2022-09-02 14:27 ` Request to cherry-pick 20401d1058f3f841f35a594ac2fc1293710e55b9 to v5.10 and v5.4 Greg Kroah-Hartman
2022-09-04 17:38 ` Manfred Spraul
2022-09-05 5:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxWHChQpxs9LrCpl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=aquini@redhat.com \
--cc=dbueso@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=stable@vger.kernel.org \
--cc=teratipally@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.