From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Linus Heckemann <git@sphalerite.org>
Cc: qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>,
Christian Schoenebeck <qemu_oss@crudebyte.com>
Subject: Re: [PATCH] 9pfs: use GHashMap for fid table
Date: Mon, 5 Sep 2022 08:10:59 +0100 [thread overview]
Message-ID: <YxWhA8M4Ul8z2KUj@redhat.com> (raw)
In-Reply-To: <20220903150327.2780127-1-git@sphalerite.org>
In $SUBJECT it is called GHashTable, not GHashMap
On Sat, Sep 03, 2022 at 05:03:27PM +0200, Linus Heckemann wrote:
> The previous implementation would iterate over the fid table for
> lookup operations, resulting in an operation with O(n) complexity on
> the number of open files and poor cache locality -- for nearly every
> open, stat, read, write, etc operation.
>
> This change uses a hashtable for this instead, significantly improving
> the performance of the 9p filesystem. The runtime of NixOS's simple
> installer test, which copies ~122k files totalling ~1.8GiB from 9p,
> decreased by a factor of about 10.
>
> Signed-off-by: Linus Heckemann <git@sphalerite.org>
> ---
> hw/9pfs/9p.c | 130 +++++++++++++++++++++++++++------------------------
> hw/9pfs/9p.h | 2 +-
> 2 files changed, 69 insertions(+), 63 deletions(-)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-09-05 7:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 15:03 [PATCH] 9pfs: use GHashMap for fid table Linus Heckemann
2022-09-04 13:38 ` Philippe Mathieu-Daudé via
2022-09-04 18:06 ` Christian Schoenebeck
2022-09-05 7:10 ` Daniel P. Berrangé [this message]
2022-09-05 8:51 ` Linus Heckemann
2022-09-05 10:26 ` Christian Schoenebeck
2022-09-05 12:18 ` Greg Kurz
2022-09-05 15:03 ` [PATCH] 9pfs: use GHashTable " Linus Heckemann
2022-09-05 15:15 ` [PATCH v2] " Philippe Mathieu-Daudé via
2022-09-06 15:23 ` [PATCH] " Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxWhA8M4Ul8z2KUj@redhat.com \
--to=berrange@redhat.com \
--cc=git@sphalerite.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.