Re: [usb:usb-testing 29/47] drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Sep 05, 2022 at 12:13:03PM +0200, Ard Biesheuvel wrote:
> On Wed, 31 Aug 2022 at 08:00, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 30, 2022 at 01:12:14PM -0400, Alan Stern wrote:
> > > On Wed, Aug 31, 2022 at 12:10:36AM +0800, kernel test robot wrote:
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > > > head:   594b9411b4adceb59ca8a66997eec1eaa3756785
> > > > commit: 5cfdb45657c97315501316657e504298b381ceee [29/47] usb: reduce kernel log spam on driver registration
> > > > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220831/202208310007.6yJMsSYz-lkp@intel.com/config)
> > > > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> > > > reproduce (this is a W=1 build):
> > > >         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=5cfdb45657c97315501316657e504298b381ceee
> > > >         git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> > > >         git fetch --no-tags usb usb-testing
> > > >         git checkout 5cfdb45657c97315501316657e504298b381ceee
> > > >         # save the config file
> > > >         mkdir build_dir && cp config build_dir/.config
> > > >         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/usb/host/
> > > >
> > > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > >> drivers/usb/host/ehci-platform.c:56:19: warning: 'hcd_name' defined but not used [-Wunused-const-variable=]
> > > >       56 | static const char hcd_name[] = "ehci-platform";
> > > >          |                   ^~~~~~~~
> > > > --
> > > > >> drivers/usb/host/ohci-platform.c:44:19: warning: 'hcd_name' defined but not used [-Wunused-const-variable=]
> > > >       44 | static const char hcd_name[] = "ohci-platform";
> > > >          |                   ^~~~~~~~
> > >
> > > This is a side effect from Ard's patch removing the pr_info lines from
> > > these drivers.  It will show up in some of the other drivers too (the
> > > ones that don't initialize their own hc_driver structure).  The solution
> > > is simply to remove the unused definitions.
> > >
> > > Ard, do you want to write a fixup patch to do this?
> >
> > I'll go fix it up...
> >
> 
> Apologies for missing this, I was on vacation last week.
> 
> Is there anything that needs to be done at this point?

Yeah, my fixup patch was incomplete and I'll not have the chance to fix
it up for a few more days due to travel :(

So if you want to send a follow-on patch, like my fixup one but in more
places, that would be great!

thanks,

greg k-h