From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] unlink07: use TST_EXP_FAIL(), docparse format, copyright update and remove redundant headers
Date: Mon, 5 Sep 2022 16:49:26 +0200 [thread overview]
Message-ID: <YxYMdvjkSowhJgl1@pevik> (raw)
In-Reply-To: <20220902062355.19954-1-akumar@suse.de>
Hi Avinesh,
I merged with following diff:
* kept relevant headers (It might be a good practise to keep *relevant headers -
library can be rewritten and headers removed, the build would fail).
* fixed docparse formatting (blank line before list is needed
Thanks!
...
> +++ b/testcases/kernel/syscalls/unlink/unlink07.c
> @@ -1,23 +1,22 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
> + * Copyright (c) Linux Test Project, 2002-2022
> */
> -/*
> - * Description:
> - * The testcase checks the various errnos of the unlink(2).
> - * 1) unlink() returns ENOENT if file doesn't exist.
> - * 2) unlink() returns ENOENT if path is empty.
> - * 3) unlink() returns ENOENT if path contains a non-existent file.
> - * 4) unlink() returns EFAULT if address is invalid.
> - * 5) unlink() returns ENOTDIR if path contains a regular file.
> - * 6) unlink() returns ENAMETOOLONG if path contains a regular file.
> +/*\
> + * [Description]
> + *
> + * Verify that unlink() fails with
blank line is needed here.
> + * - ENOENT when file does not exist
> + * - ENOENT when pathname is empty
> + * - ENOENT when a component in pathname does not exist
> + * - EFAULT when pathname points outside the accessible address space
> + * - ENOTDIR when a component used as a directory in pathname is not,
> + * in fact, a directory
> + * - ENAMETOOLONG when pathname is too long
> */
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-09-05 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 6:23 [LTP] [PATCH v2] unlink07: use TST_EXP_FAIL(), docparse format, copyright update and remove redundant headers Avinesh Kumar
2022-09-05 14:49 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxYMdvjkSowhJgl1@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.