From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Romain Naour <romain.naour@smile.fr>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
bcousson@baylibre.com, Romain Naour <romain.naour@skf.com>
Subject: Re: [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled
Date: Tue, 6 Sep 2022 10:06:02 +0300 [thread overview]
Message-ID: <YxbxWnIcfTszKxTH@atomide.com> (raw)
In-Reply-To: <d986aee3-9fd4-4f3b-f742-725833a70338@kernel.org>
* Roger Quadros <rogerq@kernel.org> [220825 07:01]:
> On 23/08/2022 10:27, Romain Naour wrote:
> > From: Romain Naour <romain.naour@skf.com>
> >
> > Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files")
> > disabled usb4_tm for am5748 devices since USB4 IP is not present
> > in this SoC.
> >
> > The commit log explained the difference between AM5 and DRA7 families:
> >
> > AM5 and DRA7 SoC families have different set of modules in them so the
> > SoC sepecific dtsi files need to be separated.
> >
> > e.g. Some of the major differences between AM576 and DRA76
> >
> > DRA76x AM576x
> >
> > USB3 x
> > USB4 x
> > ATL x
> > VCP x
> > MLB x
> > ISS x
> > PRU-ICSS1 x
> > PRU-ICSS2 x
> >
> > Then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
> > package") removed usb4_tm part from am5748.dtsi and introcuded new
> > ti-sysc errors in dmesg:
> >
> > ti-sysc 48940000.target-module: clock get error for fck: -2
> > ti-sysc: probe of 48940000.target-module failed with error -2
> >
> > Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")
> >
> > Signed-off-by: Romain Naour <romain.naour@skf.com>
> > Signed-off-by: Romain Naour <romain.naour@smile.fr>
> > Cc: Roger Quadros <rogerq@kernel.org>
> > ---
> > Issue reproduced on a AM5749 CPU using a 5.10 kernel from ti-linux-kernel:
> > https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=linux-5.10.y
> >
> > v2: improved commit log to ease patch backport
> > ---
> > arch/arm/boot/dts/am5748.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Applying into fixes thanks.
Tony
prev parent reply other threads:[~2022-09-06 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 7:27 [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled Romain Naour
2022-08-25 7:08 ` Roger Quadros
2022-09-06 7:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxbxWnIcfTszKxTH@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=romain.naour@skf.com \
--cc=romain.naour@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.