From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C978AECAAA1 for ; Tue, 6 Sep 2022 07:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233075AbiIFHGJ (ORCPT ); Tue, 6 Sep 2022 03:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232746AbiIFHGI (ORCPT ); Tue, 6 Sep 2022 03:06:08 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E6B715A2D5; Tue, 6 Sep 2022 00:06:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 99C3A80E1; Tue, 6 Sep 2022 06:58:28 +0000 (UTC) Date: Tue, 6 Sep 2022 10:06:02 +0300 From: Tony Lindgren To: Roger Quadros Cc: Romain Naour , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, bcousson@baylibre.com, Romain Naour Subject: Re: [PATCHv2] ARM: dts: am5748: keep usb4_tm disabled Message-ID: References: <20220823072742.351368-1-romain.naour@smile.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Roger Quadros [220825 07:01]: > On 23/08/2022 10:27, Romain Naour wrote: > > From: Romain Naour > > > > Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files") > > disabled usb4_tm for am5748 devices since USB4 IP is not present > > in this SoC. > > > > The commit log explained the difference between AM5 and DRA7 families: > > > > AM5 and DRA7 SoC families have different set of modules in them so the > > SoC sepecific dtsi files need to be separated. > > > > e.g. Some of the major differences between AM576 and DRA76 > > > > DRA76x AM576x > > > > USB3 x > > USB4 x > > ATL x > > VCP x > > MLB x > > ISS x > > PRU-ICSS1 x > > PRU-ICSS2 x > > > > Then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz > > package") removed usb4_tm part from am5748.dtsi and introcuded new > > ti-sysc errors in dmesg: > > > > ti-sysc 48940000.target-module: clock get error for fck: -2 > > ti-sysc: probe of 48940000.target-module failed with error -2 > > > > Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package") > > > > Signed-off-by: Romain Naour > > Signed-off-by: Romain Naour > > Cc: Roger Quadros > > --- > > Issue reproduced on a AM5749 CPU using a 5.10 kernel from ti-linux-kernel: > > https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=linux-5.10.y > > > > v2: improved commit log to ease patch backport > > --- > > arch/arm/boot/dts/am5748.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > > Reviewed-by: Roger Quadros Applying into fixes thanks. Tony