All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Czerwacki, Eial" <eial.czerwacki@sap.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Arsh, Leonid" <leonid.arsh@sap.com>,
	"Twaig, Oren" <oren.twaig@sap.com>,
	SAP vSMP Linux Maintainer <linux.vsmp@sap.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Andra Paraschiv <andraprs@amazon.com>,
	Borislav Petkov <bp@suse.de>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Eric Biggers <ebiggers@google.com>, Fei Li <fei1.li@intel.com>,
	Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2] drivers/virt/vSMP: new driver
Date: Tue, 6 Sep 2022 15:50:37 +0200	[thread overview]
Message-ID: <YxdQLY3RWRRuFMKd@kroah.com> (raw)
In-Reply-To: <PAXPR02MB731058B69D178E026C578BB481729@PAXPR02MB7310.eurprd02.prod.outlook.com>

On Thu, Aug 25, 2022 at 06:24:02AM +0000, Czerwacki, Eial wrote:
> --- /dev/null
> +++ b/drivers/virt/vsmp/Kconfig
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config VSMP
> +	tristate "vSMP Guest Support"
> +	depends on SYS_HYPERVISOR && X86_64 && PCI
> +	help
> +	  Support for vSMP Guest Driver.
> +
> +	  This driver allows information gathering of data from the vSMP hypervisor when
> +	  running on top of a vSMP-based hypervisor.
> +
> +	  If unsure, say no.

In wanting to test this out, I tried it but this depends line is wrong,
you have to set SYS_HYPERVISOR, you can not depend on it otherwise your
code will never be selected :(

How did you test this?

thanks,

greg k-h

  parent reply	other threads:[~2022-09-06 14:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  6:24 [PATCH v2] drivers/virt/vSMP: new driver Czerwacki, Eial
2022-08-25  7:32 ` Greg Kroah-Hartman
2022-08-25  9:17   ` Czerwacki, Eial
2022-08-25  9:30     ` Greg Kroah-Hartman
2022-08-25 10:16       ` Czerwacki, Eial
2022-08-25 10:24         ` Greg Kroah-Hartman
2022-08-25 10:41           ` Czerwacki, Eial
2022-08-25 11:46             ` Greg Kroah-Hartman
2022-08-25 12:02               ` Czerwacki, Eial
2022-08-25 12:19                 ` Greg Kroah-Hartman
2022-08-25 12:38                   ` Czerwacki, Eial
2022-08-25 12:42                     ` Greg Kroah-Hartman
2022-08-25 12:55                       ` Czerwacki, Eial
2022-08-25 10:46 ` Dan Carpenter
2022-08-25 10:48   ` Czerwacki, Eial
2022-08-25 10:59     ` Borislav Petkov
2022-08-25 11:03       ` Czerwacki, Eial
2022-08-25 12:41 ` Dan Carpenter
2022-08-25 13:04   ` Czerwacki, Eial
2022-09-06 13:50 ` Greg Kroah-Hartman [this message]
2022-09-06 16:47   ` Greg Kroah-Hartman
2022-09-07  6:30     ` Czerwacki, Eial
2022-09-07  6:11   ` Czerwacki, Eial

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxdQLY3RWRRuFMKd@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andraprs@amazon.com \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=bp@suse.de \
    --cc=brijesh.singh@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=ebiggers@google.com \
    --cc=eial.czerwacki@sap.com \
    --cc=fei1.li@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=leonid.arsh@sap.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.vsmp@sap.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=oren.twaig@sap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.