From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D84A1ECAAA1 for ; Tue, 6 Sep 2022 16:07:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA6BD10E030; Tue, 6 Sep 2022 16:07:00 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 108AA10E5B5; Tue, 6 Sep 2022 15:06:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 88D1DB818D4; Tue, 6 Sep 2022 15:06:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A55A4C43470; Tue, 6 Sep 2022 15:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662476808; bh=HKn5OtHPRNYi5Ma7JN4h+bzSjA8wE1EFVOf8KPNOmo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O/Kd9WyvCC8md97D3KyKkPBWv2afnrofuMcsjPEdtM3LpqX6IEbhFZUyCBI8pTwRX 4kgrTKTiHuynGEwtGi+I2IsLenPfIcUGhl8EIuVw87tirpyNRbaSIRWpr57UPqGHC8 T5n9espBQz9VWinK4X2AEBfHHg2x1zEiN7eKQwVA= Date: Tue, 6 Sep 2022 17:06:45 +0200 From: Greg Kroah-Hartman To: Rodrigo Siqueira Jordao Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Message-ID: References: <20220902130105.139138-1-gregkh@linuxfoundation.org> <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> X-Mailman-Approved-At: Tue, 06 Sep 2022 16:06:56 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Jiapeng Chong , Leo Li , dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com, Wenjing Liu , linux-kernel@vger.kernel.org, Patrik Jakobsson , David Airlie , Fangzhi Zuo , hersen wu , amd-gfx@lists.freedesktop.org, Daniel Vetter , Wayne Lin , Alex Deuc her , Bhanuprakash Modem , Yongzhi Liu , Mikita Lipski , Harry Wentland , Christian =?iso-8859-1?Q?K=F6nig?= , Thelford Williams Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs_lookup() the result must have dput() called on it, > > > otherwise the memory will leak over time. Fix this up by properly > > > calling dput(). > > > > > > Cc: Harry Wentland > > > Cc: Leo Li > > > Cc: Rodrigo Siqueira > > > Cc: Alex Deucher > > > Cc: "Christian König" > > > Cc: "Pan, Xinhui" > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: Wayne Lin > > > Cc: hersen wu > > > Cc: Wenjing Liu > > > Cc: Patrik Jakobsson > > > Cc: Thelford Williams > > > Cc: Fangzhi Zuo > > > Cc: Yongzhi Liu > > > Cc: Mikita Lipski > > > Cc: Jiapeng Chong > > > Cc: Bhanuprakash Modem > > > Cc: Sean Paul > > > Cc: amd-gfx@lists.freedesktop.org > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > maintainer add that here, or do you all want me to resend it with that > > item added? > > > > thanks, > > > > greg k-h > > Hi Greg, > > Reviewed-by: Rodrigo Siqueira > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > merge it into amd-staging-drm-next. Yes, please add the cc: stable@ line to the body of the patch, sorry I forgot that. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A153ECAAA1 for ; Tue, 6 Sep 2022 15:06:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E925C10E67E; Tue, 6 Sep 2022 15:06:54 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 108AA10E5B5; Tue, 6 Sep 2022 15:06:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 88D1DB818D4; Tue, 6 Sep 2022 15:06:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A55A4C43470; Tue, 6 Sep 2022 15:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662476808; bh=HKn5OtHPRNYi5Ma7JN4h+bzSjA8wE1EFVOf8KPNOmo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O/Kd9WyvCC8md97D3KyKkPBWv2afnrofuMcsjPEdtM3LpqX6IEbhFZUyCBI8pTwRX 4kgrTKTiHuynGEwtGi+I2IsLenPfIcUGhl8EIuVw87tirpyNRbaSIRWpr57UPqGHC8 T5n9espBQz9VWinK4X2AEBfHHg2x1zEiN7eKQwVA= Date: Tue, 6 Sep 2022 17:06:45 +0200 From: Greg Kroah-Hartman To: Rodrigo Siqueira Jordao Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Message-ID: References: <20220902130105.139138-1-gregkh@linuxfoundation.org> <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Jiapeng Chong , Leo Li , dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com, Wenjing Liu , linux-kernel@vger.kernel.org, David Airlie , Fangzhi Zuo , hersen wu , amd-gfx@lists.freedesktop.org, Wayne Lin , Alex Deuc her , Bhanuprakash Modem , Yongzhi Liu , Mikita Lipski , Christian =?iso-8859-1?Q?K=F6nig?= , Thelford Williams Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs_lookup() the result must have dput() called on it, > > > otherwise the memory will leak over time. Fix this up by properly > > > calling dput(). > > > > > > Cc: Harry Wentland > > > Cc: Leo Li > > > Cc: Rodrigo Siqueira > > > Cc: Alex Deucher > > > Cc: "Christian König" > > > Cc: "Pan, Xinhui" > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: Wayne Lin > > > Cc: hersen wu > > > Cc: Wenjing Liu > > > Cc: Patrik Jakobsson > > > Cc: Thelford Williams > > > Cc: Fangzhi Zuo > > > Cc: Yongzhi Liu > > > Cc: Mikita Lipski > > > Cc: Jiapeng Chong > > > Cc: Bhanuprakash Modem > > > Cc: Sean Paul > > > Cc: amd-gfx@lists.freedesktop.org > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > maintainer add that here, or do you all want me to resend it with that > > item added? > > > > thanks, > > > > greg k-h > > Hi Greg, > > Reviewed-by: Rodrigo Siqueira > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > merge it into amd-staging-drm-next. Yes, please add the cc: stable@ line to the body of the patch, sorry I forgot that. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E8EECAAA1 for ; Tue, 6 Sep 2022 15:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234897AbiIFPvu (ORCPT ); Tue, 6 Sep 2022 11:51:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234358AbiIFPva (ORCPT ); Tue, 6 Sep 2022 11:51:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E73E2125F for ; Tue, 6 Sep 2022 08:06:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE6616156C for ; Tue, 6 Sep 2022 15:06:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A55A4C43470; Tue, 6 Sep 2022 15:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662476808; bh=HKn5OtHPRNYi5Ma7JN4h+bzSjA8wE1EFVOf8KPNOmo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O/Kd9WyvCC8md97D3KyKkPBWv2afnrofuMcsjPEdtM3LpqX6IEbhFZUyCBI8pTwRX 4kgrTKTiHuynGEwtGi+I2IsLenPfIcUGhl8EIuVw87tirpyNRbaSIRWpr57UPqGHC8 T5n9espBQz9VWinK4X2AEBfHHg2x1zEiN7eKQwVA= Date: Tue, 6 Sep 2022 17:06:45 +0200 From: Greg Kroah-Hartman To: Rodrigo Siqueira Jordao Cc: Harry Wentland , Leo Li , Alex Deuc her , Christian =?iso-8859-1?Q?K=F6nig?= , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , Wayne Lin , hersen wu , Wenjing Liu , Patrik Jakobsson , Thelford Williams , Fangzhi Zuo , Yongzhi Liu , Mikita Lipski , Jiapeng Chong , Bhanuprakash Modem , Sean Paul , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Message-ID: References: <20220902130105.139138-1-gregkh@linuxfoundation.org> <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs_lookup() the result must have dput() called on it, > > > otherwise the memory will leak over time. Fix this up by properly > > > calling dput(). > > > > > > Cc: Harry Wentland > > > Cc: Leo Li > > > Cc: Rodrigo Siqueira > > > Cc: Alex Deucher > > > Cc: "Christian König" > > > Cc: "Pan, Xinhui" > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: Wayne Lin > > > Cc: hersen wu > > > Cc: Wenjing Liu > > > Cc: Patrik Jakobsson > > > Cc: Thelford Williams > > > Cc: Fangzhi Zuo > > > Cc: Yongzhi Liu > > > Cc: Mikita Lipski > > > Cc: Jiapeng Chong > > > Cc: Bhanuprakash Modem > > > Cc: Sean Paul > > > Cc: amd-gfx@lists.freedesktop.org > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > maintainer add that here, or do you all want me to resend it with that > > item added? > > > > thanks, > > > > greg k-h > > Hi Greg, > > Reviewed-by: Rodrigo Siqueira > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > merge it into amd-staging-drm-next. Yes, please add the cc: stable@ line to the body of the patch, sorry I forgot that. thanks, greg k-h