From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240DCECAAA1 for ; Tue, 6 Sep 2022 16:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234966AbiIFQUf (ORCPT ); Tue, 6 Sep 2022 12:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232906AbiIFQT6 (ORCPT ); Tue, 6 Sep 2022 12:19:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52F3D326DA; Tue, 6 Sep 2022 08:49:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1F49B818C2; Tue, 6 Sep 2022 15:49:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 603B1C433D6; Tue, 6 Sep 2022 15:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662479354; bh=HyOzm5VMGmYJGCUZJSGax0V3uAmkTmNzZyIR1FAA+RQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OB6QEsUCynTHvPxAqfPNLKgNfjrOnGNuCsjcCMghiOVfEjqklmu+JjF1pE6s740tR o73CbEg5qg4GocYd4ffIXKqn2Vn374C0VE8irVivL//j0IM8oXHcQzfyzS4ff7zLTn 0SF6aY/qx6kzV0f8dBPG8p9iYJiu272Hw8LCBiPwZWHLjQ4tFH2Ysv6JOROT/tfRi9 LsFO2D59VxPZo7JsdEkoJMXCQ82H2gPyFjaiTftXzSBGdw0oL1DIUoIfeoZq7lRk91 7Teieml4YBhcnYEPOdflYkLXh+krGUQfR9276k2zwRoLAzAVEYpig0v2XAA/PtLHWV EpC+kNT2h9nNw== Date: Tue, 6 Sep 2022 16:49:03 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Sergiu.Moga@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com, radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, admin@hifiphile.com, Kavyasree.Kotagiri@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Message-ID: References: <20220817075517.49575-1-sergiu.moga@microchip.com> <20220817075517.49575-3-sergiu.moga@microchip.com> <942accc5-70aa-3bb2-63dd-306a39ee5ea4@linaro.org> <80abf192-0313-aade-7780-604f4c9c6810@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <80abf192-0313-aade-7780-604f4c9c6810@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon, 05 Sep 2022, Krzysztof Kozlowski wrote: > On 05/09/2022 17:22, Sergiu.Moga@microchip.com wrote: > > On 05.09.2022 17:37, Lee Jones wrote: > >> > >> On Fri, 19 Aug 2022, Sergiu.Moga@microchip.com wrote: > >> > >>> On 18.08.2022 11:39, Krzysztof Kozlowski wrote: > >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>>> > >>>> On 17/08/2022 10:55, Sergiu Moga wrote: > >>>>> Convert at91 USART DT Binding for Atmel/Microchip SoCs to > >>>>> json-schema format. > >>>>> > >>>>> Signed-off-by: Sergiu Moga > >>>>> --- > >>>>> .../bindings/mfd/atmel,at91-usart.yaml | 190 ++++++++++++++++++ > >>>>> .../devicetree/bindings/mfd/atmel-usart.txt | 98 --------- > >>>>> 2 files changed, 190 insertions(+), 98 deletions(-) > >>>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml > >>>>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-usart.txt > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..cf15d73fa1e8 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml > >>>> One more thing - I think this should be in serial directory, not mfd, > >>>> even though it includes SPI. MFD is just a Linux naming/wrapper device. > >>>> > >>>> Best regards, > >>>> Krzysztof > >>> > >>> I would rather keep it in this directory, since its corresponding driver > >>> is also in the mfd directory. > >> > >> Looks like a UART driver to me. > >> > >> Which MFD driver does this pertain to? > >> > > > > Hi, > > > > It's this one: drivers/mfd/at91-usart.c[1] > > > > > > [1] > > https://elixir.bootlin.com/linux/v6.0-rc4/source/drivers/mfd/at91-usart.c > > Which is not a "real MFD driver" because it probes exactly one child > (depending on the chosen serial protocol). Aren't MFD supposed to have > more then one child? It's a single piece of silicon which supports multiple functions. There is no stipulation detailing simultaneous usage. Still, happy to receive suggestions on implementing this differently. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E27B0ECAAD5 for ; Tue, 6 Sep 2022 16:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lUMRtz405v0R0T6MBAhDpqHx6nlKOTTh/Y9KFJLSbyc=; b=KVVSeTQ6Khfdjv V/FPIlhj3X03vB/NXGvs6goPjrWSeuipamST6X3sYu8I4R92eaCJSd/S6BTKpFi/9S73RUH3yxPFJ Jsx5182u6tXFF+ldLLLXK943byqAEf6Z7VYwztrA1gsGk23jZ/fcLCa7hNVFFb6pbPA9dej6aIZvA /9j7zTNusbALIv6hhRUx5JRir5XQpgjH9l4GkHKAYUrRaAalchmL7oOit3CpyuQ0Jb5Cy40+Or5EL lQavKNwN7P9yzhyCkV2xJ5yZl7yo+FDtyH/rkvCN0vYNudM9/aXjDNRmQJBo6i5w1og7yy0mlIjuh X8mvN+L899wbKPdDdKog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVbFI-00FHtB-8e; Tue, 06 Sep 2022 16:16:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVap9-00F0JW-Lx for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 15:49:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 92BBE61539; Tue, 6 Sep 2022 15:49:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 603B1C433D6; Tue, 6 Sep 2022 15:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662479354; bh=HyOzm5VMGmYJGCUZJSGax0V3uAmkTmNzZyIR1FAA+RQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OB6QEsUCynTHvPxAqfPNLKgNfjrOnGNuCsjcCMghiOVfEjqklmu+JjF1pE6s740tR o73CbEg5qg4GocYd4ffIXKqn2Vn374C0VE8irVivL//j0IM8oXHcQzfyzS4ff7zLTn 0SF6aY/qx6kzV0f8dBPG8p9iYJiu272Hw8LCBiPwZWHLjQ4tFH2Ysv6JOROT/tfRi9 LsFO2D59VxPZo7JsdEkoJMXCQ82H2gPyFjaiTftXzSBGdw0oL1DIUoIfeoZq7lRk91 7Teieml4YBhcnYEPOdflYkLXh+krGUQfR9276k2zwRoLAzAVEYpig0v2XAA/PtLHWV EpC+kNT2h9nNw== Date: Tue, 6 Sep 2022 16:49:03 +0100 From: Lee Jones To: Krzysztof Kozlowski Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Message-ID: References: <20220817075517.49575-1-sergiu.moga@microchip.com> <20220817075517.49575-3-sergiu.moga@microchip.com> <942accc5-70aa-3bb2-63dd-306a39ee5ea4@linaro.org> <80abf192-0313-aade-7780-604f4c9c6810@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <80abf192-0313-aade-7780-604f4c9c6810@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_084915_879531_96C29788 X-CRM114-Status: GOOD ( 24.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Kavyasree.Kotagiri@microchip.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, linux-spi@vger.kernel.org, Sergiu.Moga@microchip.com, mturquette@baylibre.com, robh+dt@kernel.org, admin@hifiphile.com, krzysztof.kozlowski+dt@linaro.org, linux-serial@vger.kernel.org, sboyd@kernel.org, jirislaby@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNSBTZXAgMjAyMiwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKCj4gT24gMDUv MDkvMjAyMiAxNzoyMiwgU2VyZ2l1Lk1vZ2FAbWljcm9jaGlwLmNvbSB3cm90ZToKPiA+IE9uIDA1 LjA5LjIwMjIgMTc6MzcsIExlZSBKb25lcyB3cm90ZToKPiA+Pgo+ID4+IE9uIEZyaSwgMTkgQXVn IDIwMjIsIFNlcmdpdS5Nb2dhQG1pY3JvY2hpcC5jb20gd3JvdGU6Cj4gPj4KPiA+Pj4gT24gMTgu MDguMjAyMiAxMTozOSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiA+Pj4+IEVYVEVSTkFM IEVNQUlMOiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91 IGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZQo+ID4+Pj4KPiA+Pj4+IE9uIDE3LzA4LzIwMjIgMTA6 NTUsIFNlcmdpdSBNb2dhIHdyb3RlOgo+ID4+Pj4+IENvbnZlcnQgYXQ5MSBVU0FSVCBEVCBCaW5k aW5nIGZvciBBdG1lbC9NaWNyb2NoaXAgU29DcyB0bwo+ID4+Pj4+IGpzb24tc2NoZW1hIGZvcm1h dC4KPiA+Pj4+Pgo+ID4+Pj4+IFNpZ25lZC1vZmYtYnk6IFNlcmdpdSBNb2dhIDxzZXJnaXUubW9n YUBtaWNyb2NoaXAuY29tPgo+ID4+Pj4+IC0tLQo+ID4+Pj4+ICAgIC4uLi9iaW5kaW5ncy9tZmQv YXRtZWwsYXQ5MS11c2FydC55YW1sICAgICAgICB8IDE5MCArKysrKysrKysrKysrKysrKysKPiA+ Pj4+PiAgICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYXRtZWwtdXNhcnQudHh0ICAgfCAg OTggLS0tLS0tLS0tCj4gPj4+Pj4gICAgMiBmaWxlcyBjaGFuZ2VkLCAxOTAgaW5zZXJ0aW9ucygr KSwgOTggZGVsZXRpb25zKC0pCj4gPj4+Pj4gICAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYXRtZWwsYXQ5MS11c2FydC55YW1sCj4gPj4+ Pj4gICAgZGVsZXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9tZmQvYXRtZWwtdXNhcnQudHh0Cj4gPj4+Pj4KPiA+Pj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9hdG1lbCxhdDkxLXVzYXJ0LnlhbWwgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2F0bWVsLGF0OTEtdXNhcnQueWFt bAo+ID4+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPj4+Pj4gaW5kZXggMDAwMDAwMDAwMDAw Li5jZjE1ZDczZmExZTgKPiA+Pj4+PiAtLS0gL2Rldi9udWxsCj4gPj4+Pj4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9hdG1lbCxhdDkxLXVzYXJ0LnlhbWwKPiA+ Pj4+IE9uZSBtb3JlIHRoaW5nIC0gSSB0aGluayB0aGlzIHNob3VsZCBiZSBpbiBzZXJpYWwgZGly ZWN0b3J5LCBub3QgbWZkLAo+ID4+Pj4gZXZlbiB0aG91Z2ggaXQgaW5jbHVkZXMgU1BJLiBNRkQg aXMganVzdCBhIExpbnV4IG5hbWluZy93cmFwcGVyIGRldmljZS4KPiA+Pj4+Cj4gPj4+PiBCZXN0 IHJlZ2FyZHMsCj4gPj4+PiBLcnp5c3p0b2YKPiA+Pj4KPiA+Pj4gSSB3b3VsZCByYXRoZXIga2Vl cCBpdCBpbiB0aGlzIGRpcmVjdG9yeSwgc2luY2UgaXRzIGNvcnJlc3BvbmRpbmcgZHJpdmVyCj4g Pj4+IGlzIGFsc28gaW4gdGhlIG1mZCBkaXJlY3RvcnkuCj4gPj4KPiA+PiBMb29rcyBsaWtlIGEg VUFSVCBkcml2ZXIgdG8gbWUuCj4gPj4KPiA+PiBXaGljaCBNRkQgZHJpdmVyIGRvZXMgdGhpcyBw ZXJ0YWluIHRvPwo+ID4+Cj4gPiAKPiA+IEhpLAo+ID4gCj4gPiBJdCdzIHRoaXMgb25lOiBkcml2 ZXJzL21mZC9hdDkxLXVzYXJ0LmNbMV0KPiA+IAo+ID4gCj4gPiBbMV0gCj4gPiBodHRwczovL2Vs aXhpci5ib290bGluLmNvbS9saW51eC92Ni4wLXJjNC9zb3VyY2UvZHJpdmVycy9tZmQvYXQ5MS11 c2FydC5jCj4gCj4gV2hpY2ggaXMgbm90IGEgInJlYWwgTUZEIGRyaXZlciIgYmVjYXVzZSBpdCBw cm9iZXMgZXhhY3RseSBvbmUgY2hpbGQKPiAoZGVwZW5kaW5nIG9uIHRoZSBjaG9zZW4gc2VyaWFs IHByb3RvY29sKS4gQXJlbid0IE1GRCBzdXBwb3NlZCB0byBoYXZlCj4gbW9yZSB0aGVuIG9uZSBj aGlsZD8KCkl0J3MgYSBzaW5nbGUgcGllY2Ugb2Ygc2lsaWNvbiB3aGljaCBzdXBwb3J0cyBtdWx0 aXBsZSBmdW5jdGlvbnMuCgpUaGVyZSBpcyBubyBzdGlwdWxhdGlvbiBkZXRhaWxpbmcgc2ltdWx0 YW5lb3VzIHVzYWdlLgoKU3RpbGwsIGhhcHB5IHRvIHJlY2VpdmUgc3VnZ2VzdGlvbnMgb24gaW1w bGVtZW50aW5nIHRoaXMgZGlmZmVyZW50bHkuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==