From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-gpio@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")
Date: Wed, 7 Sep 2022 08:08:39 +0200 [thread overview]
Message-ID: <Yxg1Z6YoFiCE8ORo@kroah.com> (raw)
In-Reply-To: <CADVatmNSGSZZNXF7k7YmMqfcoOAiM6JhEfksjoVqoBOLUXfbPQ@mail.gmail.com>
On Tue, Sep 06, 2022 at 10:07:53PM +0100, Sudip Mukherjee wrote:
> Hi Greg,
>
> On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink) wrote:
> > > Hi All,
> > >
> > > The builds of riscv, s390, csky, alpha and loongarch allmodconfig have
> > > failed to build next-20220906 with the error:
> > >
> > >
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> > > 311 | static int pci1xxxx_gpio_resume(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~~~
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> > > 295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~~~~
> > >
> > >
> > > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.").
> > >
> > > I will be happy to test any patch or provide any extra log if needed.
> >
> > Hopefully this commit will fix this:
> > https://lore.kernel.org/r/20220906124951.696776-1-kumaravel.thiagarajan@microchip.com
>
> No, it didn't. :(
>
> Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> "#ifdef CONFIG_PM_SLEEP".
Great, Kumaravel, can you send a fixup patch for this?
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-07 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 14:23 build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.") Sudip Mukherjee (Codethink)
2022-09-06 17:15 ` Greg Kroah-Hartman
2022-09-06 21:07 ` Sudip Mukherjee
2022-09-07 6:08 ` Greg Kroah-Hartman [this message]
2022-09-07 8:41 ` Arnd Bergmann
2022-09-07 12:40 ` Kumaravel.Thiagarajan
2022-09-09 15:12 ` Kumaravel.Thiagarajan
2022-09-09 17:51 ` Sudip Mukherjee
2022-09-12 11:48 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxg1Z6YoFiCE8ORo@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.