From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: will@kernel.org, iommu@lists.linux.dev, subkhankulov@ispras.ru,
khoroshilov@ispras.ru, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/io-pgtable-arm: Remove iommu_dev==NULL special case
Date: Wed, 7 Sep 2022 14:19:04 +0200 [thread overview]
Message-ID: <YxiMOO+8Zz5bnUQ3@8bytes.org> (raw)
In-Reply-To: <e2095eeda305071cb56c2cb8ac8a82dc3bd4dcab.1660580155.git.robin.murphy@arm.com>
On Mon, Aug 15, 2022 at 05:15:55PM +0100, Robin Murphy wrote:
> The special case to allow iommu_dev==NULL in __arm_lpae_alloc_pages() is
> confusing to static checkers (and possibly readers in general), since
> it's not obvious that that is only intended for the selftests. However
> it only serves to get around the dev_to_node() call, and we can easily
> fake up enough to make that work anyway, so let's simply remove this
> consideration from the normal flow and punt the responsibility over to
> the test harness itself.
>
> Reported-by: Rustam Subkhankulov <subkhankulov@ispras.ru>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Applied, thanks.
prev parent reply other threads:[~2022-09-07 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 16:15 [PATCH] iommu/io-pgtable-arm: Remove iommu_dev==NULL special case Robin Murphy
2022-09-07 12:19 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxiMOO+8Zz5bnUQ3@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux.dev \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=subkhankulov@ispras.ru \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.