From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA78C38145 for ; Wed, 7 Sep 2022 12:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbiIGMdG (ORCPT ); Wed, 7 Sep 2022 08:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiIGMdA (ORCPT ); Wed, 7 Sep 2022 08:33:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10A29A7ABF; Wed, 7 Sep 2022 05:33:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D5AD618D6; Wed, 7 Sep 2022 12:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CB53C433D7; Wed, 7 Sep 2022 12:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662553979; bh=+oPcnp8Ehqf+5v9MwAdEHVeVY7vbOQ3ajdywYWvVyKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PbGVjNGQFIBeQlyORikeOGZ023BSRIg/LCmLoOXl+RupSx7yVXJLKwNpNNghwaQx+ 2c9cCoL8ZSLzwG0PPsta9NsFSI7VhSRiZUKu/xlOutzwnV+Ah2Y8wgQ5qbq+KtKClF zbh1++1nCbXnBG+42FRlhocM2eMzPFB2yI/vtpfk= Date: Wed, 7 Sep 2022 14:32:56 +0200 From: Greg KH To: Nipun Gupta Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, puneet.gupta@amd.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kvm@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, aleksandar.radovanovic@amd.com, git@amd.com Subject: Re: [RFC PATCH v3 2/7] bus/cdx: add the cdx bus driver Message-ID: References: <20220803122655.100254-1-nipun.gupta@amd.com> <20220906134801.4079497-1-nipun.gupta@amd.com> <20220906134801.4079497-3-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906134801.4079497-3-nipun.gupta@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Tue, Sep 06, 2022 at 07:17:56PM +0530, Nipun Gupta wrote: > CDX bus supports the scanning and probing of FPGA based > devices. These devices are registers as CDX devices. > > The bus driver sets up the basic infrastructure and fetches > the device related information from the firmware. > > CDX bus is capable of scanning devices dynamically, > supporting rescanning of dynamically added, removed or > updated devices. Really? Then why is the platform driver mess still in here? > --- /dev/null > +++ b/drivers/bus/cdx/cdx.c > @@ -0,0 +1,437 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Platform driver for CDX bus. Again, this should not be a platform driver. Now you can have a CDX "bus" driver, that is a platform driver, but that needs to be in a separate file and as a separate module and totally independant of the CDX bus code entirely. Otherwise this is a mess to try to sift through and determine what is, and is not, going on. Please split that up and get rid of all of the platform driver stuff here and put it in a separate patch that happens after the CDX bus logic is added. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6C84C54EE9 for ; Wed, 7 Sep 2022 12:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wW9EPbosmKI2FC/kK9vFeU/ViJuoEuTmXQHCWMvWxGE=; b=DM69mDhQ4Om9en W7irExR55kMnZHdq0mgDqXM4vQnx0N84qqjPWwHXngZF7zwVp5lsxOCl51aVYBJxIFioiCtzcEWAC 8lDvdUK8EmsCAiEdTrA6cAysp13cHXWB1rfje7bYcSCk9CnK74VrUKk8gElaoO0KuhpwHbhhmRSUh 9Jk5XYOzFioldZkrpX5d5rgdF01OE7tgFfT5VejTlSqLxvqpVHOxGjMn5/16kKNw7ueTWL+rEuvzr 4KqYrK/FE5dsy9sQBz1jgXR5Xojbn7++nid01aN0nWRFdcaBzxdQ8YAlE8KcdnT93YZ/iJZfhCpzs s/XhkwRCqKxU50Jkm51A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVuEs-00685J-8k; Wed, 07 Sep 2022 12:33:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVuEm-00680i-A4 for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 12:33:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D53D618C8; Wed, 7 Sep 2022 12:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CB53C433D7; Wed, 7 Sep 2022 12:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662553979; bh=+oPcnp8Ehqf+5v9MwAdEHVeVY7vbOQ3ajdywYWvVyKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PbGVjNGQFIBeQlyORikeOGZ023BSRIg/LCmLoOXl+RupSx7yVXJLKwNpNNghwaQx+ 2c9cCoL8ZSLzwG0PPsta9NsFSI7VhSRiZUKu/xlOutzwnV+Ah2Y8wgQ5qbq+KtKClF zbh1++1nCbXnBG+42FRlhocM2eMzPFB2yI/vtpfk= Date: Wed, 7 Sep 2022 14:32:56 +0200 From: Greg KH To: Nipun Gupta Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, puneet.gupta@amd.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kvm@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, aleksandar.radovanovic@amd.com, git@amd.com Subject: Re: [RFC PATCH v3 2/7] bus/cdx: add the cdx bus driver Message-ID: References: <20220803122655.100254-1-nipun.gupta@amd.com> <20220906134801.4079497-1-nipun.gupta@amd.com> <20220906134801.4079497-3-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220906134801.4079497-3-nipun.gupta@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_053300_500226_4B6F387A X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 06, 2022 at 07:17:56PM +0530, Nipun Gupta wrote: > CDX bus supports the scanning and probing of FPGA based > devices. These devices are registers as CDX devices. > > The bus driver sets up the basic infrastructure and fetches > the device related information from the firmware. > > CDX bus is capable of scanning devices dynamically, > supporting rescanning of dynamically added, removed or > updated devices. Really? Then why is the platform driver mess still in here? > --- /dev/null > +++ b/drivers/bus/cdx/cdx.c > @@ -0,0 +1,437 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Platform driver for CDX bus. Again, this should not be a platform driver. Now you can have a CDX "bus" driver, that is a platform driver, but that needs to be in a separate file and as a separate module and totally independant of the CDX bus code entirely. Otherwise this is a mess to try to sift through and determine what is, and is not, going on. Please split that up and get rid of all of the platform driver stuff here and put it in a separate patch that happens after the CDX bus logic is added. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel