From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5892FC54EE9 for ; Wed, 7 Sep 2022 14:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BuBX5Ovu7bViDo/8P042CjJM6j0fr0nYVDdpN6hHftQ=; b=sPhWaIMo+DN5mc OBjZWNki9I464o/bgYf97hNz/RlfP9N+t/q3Ze4CZFdpW/nRSq5ZMy+EgUyCS5Z4E0VizmFJ7Abbn J1tAKTVkd0faQkVdG348N1lGEIa181rtb0ctehQcAsRFmjDE0PORPD9HYnOkHSRScnfzgQy1XRAt8 m37kQ+buMSktx/6/Dypk3Daqf2B0udD2Uk473YWFi3+/wy9m2jgRVlkGvxgiNiKWCCiHkZJjNGwQR ZLVdCZ86Eh7OE6qEW9aCOn74KpkopRkbxIcv/8NDbum3F6ATXKpZKqN/20yFosG9N4J87oO7UdcCn vXfVT5OMhYAX10YZTOGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVw0F-006rLe-9R; Wed, 07 Sep 2022 14:26:07 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVvwy-006ovH-IE for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 14:22:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12E2E6192D; Wed, 7 Sep 2022 14:22:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7443C433C1; Wed, 7 Sep 2022 14:22:41 +0000 (UTC) Date: Wed, 7 Sep 2022 15:22:38 +0100 From: Catalin Marinas To: "Russell King (Oracle)" Cc: Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [arm:ktext 16/19] arch/arm64/mm/ktext.c:96:17: error: implicit declaration of function 'clean_dcache_range_nopatch' Message-ID: References: <202208120434.0ibxs7Y5-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_072244_691092_BA8B7A25 X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, Sorry, holidays and lots of emails to go through. On Fri, Aug 12, 2022 at 12:46:55PM +0100, Russell King wrote: > What do you think would be the best way to fix the issue with > clean_dcache_range_nopatch() in this patch set? I see two possible > solutions to it: > > 1) duplicate clean_dcache_range_nopatch() in arch/arm64/mm/ktext.c > 2) make clean_dcache_range_nopatch() globally visible so ktext.c > can call it. > > Neither of these feels like a great solution. > > I've thought about moving the code into arch/arm64/kernel/alternative.c > but that means making other stuff globally visible instead. So it seems > to be a case of what is the lesser of all the evils. > > The patch can be viewed at: > http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=ktext&id=b8557d9117093ebe17320d36dadd47fc742820c9 I'd prefer the second option above. It's easier to maintain in case we have to change this function (errata etc.) You could also pass a function pointer to ktext_replication_* to call for cache maintenance but I'm not sure it's worth it. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel