Re: [PATCH net-next 3/3] nfp: implement xfrm callbacks and expose ipsec offload feature to upper layer

[Leon Romanovsky <leon@kernel.org>]

On Wed, Sep 07, 2022 at 11:47:58AM +0200, Simon Horman wrote:
> From: Huanhuan Wang <huanhuan.wang@corigine.com>
> 
> Xfrm callbacks are implemented to offload SA info into firmware
> by mailbox. It supports 16K SA info in total.
> 
> Expose ipsec offload feature to upper layer, this feature will
> signal the availability of the offload.
> 
> Based on initial work of Norm Bagley <norman.bagley@netronome.com>.
> 
> Signed-off-by: Huanhuan Wang <huanhuan.wang@corigine.com>
> Reviewed-by: Louis Peens <louis.peens@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
> ---
>  .../net/ethernet/netronome/nfp/crypto/ipsec.c | 552 +++++++++++++++++-
>  .../ethernet/netronome/nfp/nfp_net_common.c   |   6 +
>  .../net/ethernet/netronome/nfp/nfp_net_ctrl.h |   4 +-
>  3 files changed, 558 insertions(+), 4 deletions(-)

<...>

> +	if (x->props.flags & XFRM_STATE_ESN)
> +		cfg->ctrl_word.ext_seq = 1;
> +	else
> +		cfg->ctrl_word.ext_seq = 0;

Don't you need to implement xdo_dev_state_advance_esn() too?

Thanks