From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22746C54EE9 for ; Thu, 8 Sep 2022 09:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbiIHJol (ORCPT ); Thu, 8 Sep 2022 05:44:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbiIHJoh (ORCPT ); Thu, 8 Sep 2022 05:44:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3DCC14008; Thu, 8 Sep 2022 02:44:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04B1A61C30; Thu, 8 Sep 2022 09:44:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F410DC433D7; Thu, 8 Sep 2022 09:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662630274; bh=I3kuzLPKhDYkB44Kbq3Ba0qHby0mCUZxIRVbEQXEPyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hB6x9UYDzP88wUBio5ktCkyq2xTk8jx/SoHt1nTnq9DkjLrlmtjZjNjDl1SRSfjZY cZhY80i34wCcNXFp/b/ApMeVRH3Qx0hOLkKKj0j9/1A4JtVylswYI55Zz8SLXWDyVK BBMrJU4nxKoCieqifcvTXQ0JwDHC/Y1IT+sFghMLAld6ZIboFioVe0vvjo/sgKSqoy MTXf75DznbzCkQKbNdZbKYxj2cJ+gzpfbSnjCBEJdfpFxKRuqsaKrjzvXnpx/rBb8C 9wxmaUe/9P1BwYFYVqeIJGXhQ9b53LtP+32BR9PWvzl0CLTRJFAa/C5ooAaVSFKgiA WbAn5uFHHEusw== Date: Thu, 8 Sep 2022 10:44:25 +0100 From: Lee Jones To: Colin Foster Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Terry Bowman , Vladimir Oltean , Greg Kroah-Hartman , Andy Shevchenko , Dan Williams , Jonathan Cameron , UNGLinuxDriver@microchip.com, Steen Hegelund , Lars Povlsen , Linus Walleij , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , katie.morris@in-advantage.com Subject: Re: [RESEND PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: References: <20220905162132.2943088-1-colin.foster@in-advantage.com> <20220905162132.2943088-9-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220905162132.2943088-9-colin.foster@in-advantage.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 05 Sep 2022, Colin Foster wrote: > The VSC7512 is a networking chip that contains several peripherals. Many of > these peripherals are currently supported by the VSC7513 and VSC7514 chips, > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be > controlled externally. > > Utilize the existing drivers by referencing the chip as an MFD. Add support > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO. > > Signed-off-by: Colin Foster > Reviewed-by: Vladimir Oltean > --- > > v16 > * Includes fixups: > * ocelot-core.c add includes device.h, export.h, iopoll.h, ioport,h > * ocelot-spi.c add includes device.h, err.h, errno.h, export.h, > mod_devicetable.h, types.h > * Move kconfig.h from ocelot-spi.c to ocelot.h > * Remove unnecessary byteorder.h > * Utilize resource_size() function > > v15 > * Add missed include bits.h > * Clean _SIZE macros to make them all the same width (e.g. 0x004) > * Remove unnecessary ret = ...; return ret; calls > * Utilize spi_message_init_with_transfers() instead of > spi_message_add_tail() calls in the bus_read routine > * Utilize HZ_PER_MHZ from units.h instead of a magic number > * Remove unnecessary err < 0 checks > * Fix typos in comments > > v14 > * Add Reviewed tag > * Copyright ranges are now "2021-2022" > * 100-char width applied instead of 80 > * Remove invalid dev_err_probe return > * Remove "spi" and "dev" elements from ocelot_ddata struct. > Since "dev" is available throughout, determine "ddata" and "spi" from > there instead of keeping separate references. > * Add header guard in drivers/mfd/ocelot.h > * Document ocelot_ddata struct > > --- > MAINTAINERS | 1 + > drivers/mfd/Kconfig | 21 +++ > drivers/mfd/Makefile | 3 + > drivers/mfd/ocelot-core.c | 161 ++++++++++++++++++++ > drivers/mfd/ocelot-spi.c | 299 ++++++++++++++++++++++++++++++++++++++ > drivers/mfd/ocelot.h | 49 +++++++ > 6 files changed, 534 insertions(+) > create mode 100644 drivers/mfd/ocelot-core.c > create mode 100644 drivers/mfd/ocelot-spi.c > create mode 100644 drivers/mfd/ocelot.h Applied, thanks. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00A53C38145 for ; Thu, 8 Sep 2022 09:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d94w5CJvdX9TfZnp+tiY6DNTpRuumJwz0VYhv3Yp5zw=; b=rgHLersKMBHkoU 7rXVw4WZGB6jBVUHSa4l+ftO6wdBc0yuxUIEg1mY9dsmq5Ujkru9cxx0DmMh0ZyEDLRo2jKq199Bw 5DfU7KmgOvjCg8JzHHZ5fNNPY7qrncr7U1W4Gi9V8JnHCnsAXJs7FdzUJBQYj3eqYH9yIGgHxuVsx gz60Y4aFivpKB+zRuwL8ilvUYtLr9189f8Nyi3glbRx1pRBAiJJnj41+OmE1CQYR7FKfn+rKV6yEE M4QfCt65fC6MDoUlCFNknoyEqu/XYFlNiQauzIEvZv3F8+8/gj7h0Gh1+WqQJCk44/9CUSAd4iocK V/JQQPO2ljTUgGrPD3Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWE5Y-001lbr-QE; Thu, 08 Sep 2022 09:44:48 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWE5U-001lWZ-5C for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 09:44:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 7374DCE1ECE; Thu, 8 Sep 2022 09:44:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F410DC433D7; Thu, 8 Sep 2022 09:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662630274; bh=I3kuzLPKhDYkB44Kbq3Ba0qHby0mCUZxIRVbEQXEPyw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hB6x9UYDzP88wUBio5ktCkyq2xTk8jx/SoHt1nTnq9DkjLrlmtjZjNjDl1SRSfjZY cZhY80i34wCcNXFp/b/ApMeVRH3Qx0hOLkKKj0j9/1A4JtVylswYI55Zz8SLXWDyVK BBMrJU4nxKoCieqifcvTXQ0JwDHC/Y1IT+sFghMLAld6ZIboFioVe0vvjo/sgKSqoy MTXf75DznbzCkQKbNdZbKYxj2cJ+gzpfbSnjCBEJdfpFxKRuqsaKrjzvXnpx/rBb8C 9wxmaUe/9P1BwYFYVqeIJGXhQ9b53LtP+32BR9PWvzl0CLTRJFAa/C5ooAaVSFKgiA WbAn5uFHHEusw== Date: Thu, 8 Sep 2022 10:44:25 +0100 From: Lee Jones To: Colin Foster Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Terry Bowman , Vladimir Oltean , Greg Kroah-Hartman , Andy Shevchenko , Dan Williams , Jonathan Cameron , UNGLinuxDriver@microchip.com, Steen Hegelund , Lars Povlsen , Linus Walleij , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Krzysztof Kozlowski , Rob Herring , katie.morris@in-advantage.com Subject: Re: [RESEND PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: References: <20220905162132.2943088-1-colin.foster@in-advantage.com> <20220905162132.2943088-9-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220905162132.2943088-9-colin.foster@in-advantage.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_024445_233428_005CB0B6 X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwNSBTZXAgMjAyMiwgQ29saW4gRm9zdGVyIHdyb3RlOgoKPiBUaGUgVlNDNzUxMiBp cyBhIG5ldHdvcmtpbmcgY2hpcCB0aGF0IGNvbnRhaW5zIHNldmVyYWwgcGVyaXBoZXJhbHMuIE1h bnkgb2YKPiB0aGVzZSBwZXJpcGhlcmFscyBhcmUgY3VycmVudGx5IHN1cHBvcnRlZCBieSB0aGUg VlNDNzUxMyBhbmQgVlNDNzUxNCBjaGlwcywKPiBidXQgdGhvc2UgcnVuIG9uIGFuIGludGVybmFs IENQVS4gVGhlIFZTQzc1MTIgbGFja3MgdGhpcyBDUFUsIGFuZCBtdXN0IGJlCj4gY29udHJvbGxl ZCBleHRlcm5hbGx5Lgo+IAo+IFV0aWxpemUgdGhlIGV4aXN0aW5nIGRyaXZlcnMgYnkgcmVmZXJl bmNpbmcgdGhlIGNoaXAgYXMgYW4gTUZELiBBZGQgc3VwcG9ydAo+IGZvciB0aGUgdHdvIE1ESU8g YnVzZXMsIHRoZSBpbnRlcm5hbCBwaHlzLCBwaW5jdHJsLCBhbmQgc2VyaWFsIEdQSU8uCj4gCj4g U2lnbmVkLW9mZi1ieTogQ29saW4gRm9zdGVyIDxjb2xpbi5mb3N0ZXJAaW4tYWR2YW50YWdlLmNv bT4KPiBSZXZpZXdlZC1ieTogVmxhZGltaXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNv bT4KPiAtLS0KPiAKPiB2MTYKPiAgICAgKiBJbmNsdWRlcyBmaXh1cHM6Cj4gICAgICogIG9jZWxv dC1jb3JlLmMgYWRkIGluY2x1ZGVzIGRldmljZS5oLCBleHBvcnQuaCwgaW9wb2xsLmgsIGlvcG9y dCxoCj4gICAgICogIG9jZWxvdC1zcGkuYyBhZGQgaW5jbHVkZXMgZGV2aWNlLmgsIGVyci5oLCBl cnJuby5oLCBleHBvcnQuaCwgCj4gICAgICAgIG1vZF9kZXZpY2V0YWJsZS5oLCB0eXBlcy5oCj4g ICAgICogIE1vdmUga2NvbmZpZy5oIGZyb20gb2NlbG90LXNwaS5jIHRvIG9jZWxvdC5oCj4gICAg ICogIFJlbW92ZSB1bm5lY2Vzc2FyeSBieXRlb3JkZXIuaAo+ICAgICAqIFV0aWxpemUgcmVzb3Vy Y2Vfc2l6ZSgpIGZ1bmN0aW9uCj4gCj4gdjE1Cj4gICAgICogQWRkIG1pc3NlZCBpbmNsdWRlIGJp dHMuaAo+ICAgICAqIENsZWFuIF9TSVpFIG1hY3JvcyB0byBtYWtlIHRoZW0gYWxsIHRoZSBzYW1l IHdpZHRoIChlLmcuIDB4MDA0KQo+ICAgICAqIFJlbW92ZSB1bm5lY2Vzc2FyeSByZXQgPSAuLi47 IHJldHVybiByZXQ7IGNhbGxzCj4gICAgICogVXRpbGl6ZSBzcGlfbWVzc2FnZV9pbml0X3dpdGhf dHJhbnNmZXJzKCkgaW5zdGVhZCBvZgo+ICAgICAgIHNwaV9tZXNzYWdlX2FkZF90YWlsKCkgY2Fs bHMgaW4gdGhlIGJ1c19yZWFkIHJvdXRpbmUKPiAgICAgKiBVdGlsaXplIEhaX1BFUl9NSFogZnJv bSB1bml0cy5oIGluc3RlYWQgb2YgYSBtYWdpYyBudW1iZXIKPiAgICAgKiBSZW1vdmUgdW5uZWNl c3NhcnkgZXJyIDwgMCBjaGVja3MKPiAgICAgKiBGaXggdHlwb3MgaW4gY29tbWVudHMKPiAKPiB2 MTQKPiAgICAgKiBBZGQgUmV2aWV3ZWQgdGFnCj4gICAgICogQ29weXJpZ2h0IHJhbmdlcyBhcmUg bm93ICIyMDIxLTIwMjIiCj4gICAgICogMTAwLWNoYXIgd2lkdGggYXBwbGllZCBpbnN0ZWFkIG9m IDgwCj4gICAgICogUmVtb3ZlIGludmFsaWQgZGV2X2Vycl9wcm9iZSByZXR1cm4KPiAgICAgKiBS ZW1vdmUgInNwaSIgYW5kICJkZXYiIGVsZW1lbnRzIGZyb20gb2NlbG90X2RkYXRhIHN0cnVjdC4K PiAgICAgU2luY2UgImRldiIgaXMgYXZhaWxhYmxlIHRocm91Z2hvdXQsIGRldGVybWluZSAiZGRh dGEiIGFuZCAic3BpIiBmcm9tCj4gICAgIHRoZXJlIGluc3RlYWQgb2Yga2VlcGluZyBzZXBhcmF0 ZSByZWZlcmVuY2VzLgo+ICAgICAqIEFkZCBoZWFkZXIgZ3VhcmQgaW4gZHJpdmVycy9tZmQvb2Nl bG90LmgKPiAgICAgKiBEb2N1bWVudCBvY2Vsb3RfZGRhdGEgc3RydWN0Cj4gCj4gLS0tCj4gIE1B SU5UQUlORVJTICAgICAgICAgICAgICAgfCAgIDEgKwo+ICBkcml2ZXJzL21mZC9LY29uZmlnICAg ICAgIHwgIDIxICsrKwo+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAgIHwgICAzICsKPiAgZHJp dmVycy9tZmQvb2NlbG90LWNvcmUuYyB8IDE2MSArKysrKysrKysrKysrKysrKysrKwo+ICBkcml2 ZXJzL21mZC9vY2Vsb3Qtc3BpLmMgIHwgMjk5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gIGRyaXZlcnMvbWZkL29jZWxvdC5oICAgICAgfCAgNDkgKysrKysrKwo+ICA2 IGZpbGVzIGNoYW5nZWQsIDUzNCBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL21mZC9vY2Vsb3QtY29yZS5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL21m ZC9vY2Vsb3Qtc3BpLmMKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWZkL29jZWxvdC5o CgpBcHBsaWVkLCB0aGFua3MuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==