From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFA473222 for ; Thu, 8 Sep 2022 13:36:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2412C433C1; Thu, 8 Sep 2022 13:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662644192; bh=jNYWcMJTxd9I6mwuzcAiobhdY14ilM+Fu6mCeOacPks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wwi5zw+Td0dhT/rAp3NbqBmoiLPsF132s7eZ25qXpttdfakMm2iZAPzjt+tbDXlry 0xypQmNisF/a5Ky1S7NVqX9xIGHTJnUfSrylXJ6HO0sl8oKin1XXRTFgVMbE3MqZwf FaIrw6oy0uBdDTtkwQnHj5Ikdvfv9ESzOPys3dTQ8zuSzE1hhN8itoLb4z/zN6aTk3 OmfC1/mgqY/z8h9cqhxws2KIq/Qex4MhVi6dEeN5apuJk9BWkl2qStNzmuXMnHhwYz 8bby+has6UFuxVYOFJ6KBMvhbqbjepknNg+fUju70QJDuaIpCN9PVZwGw/rbsXH7kD iP1imfkt7TTgg== Date: Thu, 8 Sep 2022 14:36:26 +0100 From: Lee Jones To: Hector Martin Cc: Russell King , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter Subject: Re: [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Message-ID: References: <45ed0a37-60ac-3a06-92d1-6b30e18261ff@marcan.st> <8f30a490-f970-6605-20cb-c2256daab9de@marcan.st> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f30a490-f970-6605-20cb-c2256daab9de@marcan.st> On Thu, 08 Sep 2022, Hector Martin wrote: > On 08/09/2022 21.31, Lee Jones wrote: > > On Thu, 08 Sep 2022, Hector Martin wrote: > >> But it's not exactly your > >> typical MFD device (it's not even a separate chip, it's part of the main > >> SoC), so I'm not sure if it really belongs in mfd/ from an > >> organizational standpoint? > > > > There is a strong argument for all SoCs to be classed as (massive) > > MFDs. However seeing as they represent more of a whole platform, > > rather than an add-on chip, we have had the sense to represent them > > differently. Some such submissions I have made explicit requests to be > > moved form drivers/mfd *into* drivers/platform in the past. > > > > Most SoCs are solely represented in DT, omitting the requirement for > > subsequent device registration. Have you considered this? If so, why > > does this not suit your use-case? > > This driver and a subset of its sub-drivers are intended to generalize > (via different backends, but no changes to sub-drivers) to legacy and T2 > Mac platforms, eventually superseding applesmc (which is in hwmon/ > because it started out as that, but has now grown random features and is > quite a mess). Those are are Intel/UEFI machines and not DT platforms, > and on those the SMC is actually a separate chip in some form (much like > an EC). Understood. Fair point. > > The long and the short of it is; if you wish to treat this device, or > > at least a section of it, as a type of MFD, then please draft that > > part of it as an MFD driver, residing in drivers/mfd. If it's "not > > really an MFD", then find another way to represent the conglomeration > > please. > > > > If the MFD route is the best, then you can register each of the > > devices, including the *-core from drivers/mfd. Grep for "cross-ec" > > as a relatively recently good example. > > I think cros-ec is similar enough, yeah. As long as you don't mind > having the core codebase in mfd/ (4 files: core, rtkit backend, and > future T2 and legacy backends) we can do that. That's actually not what I'm suggesting. You *only* need to move the subsequent-device-registration handling into drivers/mfd. The remainder really should be treated as Platform (not to be confused with Arch Platform) code and should reside in drivers/platform. Just as we do with cros-ec. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B343AC38145 for ; Thu, 8 Sep 2022 13:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bXK4/cjS75+u2PMCZNzg+kMO3oNvc+Rm4FMJ+q0pxt8=; b=j2eoJUcHdrqaTp fr35h0CrwcyGonySqust/iRM3/v7wvwOVvaDwjbRFv6eyBAKzn622LqS/6CvSjT6r94/AXj4jBWdy UhUU9Vlt4fY2muUiAdk3Vy106a0Y8luM80HAMvqEUyouV8dDqdwv/SZVA9V4tCpz/EINF5kgWTiVO FzzmgoH52kMvlvxaJ2W/d7FrmuNIcNdToffp0+q+xOLBLYJkRCZa+jkhlq5lNqVf2zVw2O2vte6LF R/SvJ/gDu4p9uTNH/qQ5rEdfaqQBBhC/bOjBC64yTUIfaqsIsWpp9gJzwM8SKE5MG4NiyBz4TsLmO py4ZiY4Q/IcSLBdYDs7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWHjA-003xUQ-Uu; Thu, 08 Sep 2022 13:37:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWHhp-003wLD-HD for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 13:36:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0BD1461CF6; Thu, 8 Sep 2022 13:36:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2412C433C1; Thu, 8 Sep 2022 13:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662644192; bh=jNYWcMJTxd9I6mwuzcAiobhdY14ilM+Fu6mCeOacPks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wwi5zw+Td0dhT/rAp3NbqBmoiLPsF132s7eZ25qXpttdfakMm2iZAPzjt+tbDXlry 0xypQmNisF/a5Ky1S7NVqX9xIGHTJnUfSrylXJ6HO0sl8oKin1XXRTFgVMbE3MqZwf FaIrw6oy0uBdDTtkwQnHj5Ikdvfv9ESzOPys3dTQ8zuSzE1hhN8itoLb4z/zN6aTk3 OmfC1/mgqY/z8h9cqhxws2KIq/Qex4MhVi6dEeN5apuJk9BWkl2qStNzmuXMnHhwYz 8bby+has6UFuxVYOFJ6KBMvhbqbjepknNg+fUju70QJDuaIpCN9PVZwGw/rbsXH7kD iP1imfkt7TTgg== Date: Thu, 8 Sep 2022 14:36:26 +0100 From: Lee Jones To: Hector Martin Cc: Russell King , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter Subject: Re: [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Message-ID: References: <45ed0a37-60ac-3a06-92d1-6b30e18261ff@marcan.st> <8f30a490-f970-6605-20cb-c2256daab9de@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8f30a490-f970-6605-20cb-c2256daab9de@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_063633_713055_C221203C X-CRM114-Status: GOOD ( 26.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwOCBTZXAgMjAyMiwgSGVjdG9yIE1hcnRpbiB3cm90ZToKCj4gT24gMDgvMDkvMjAy MiAyMS4zMSwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVGh1LCAwOCBTZXAgMjAyMiwgSGVjdG9y IE1hcnRpbiB3cm90ZToKPiA+PiBCdXQgaXQncyBub3QgZXhhY3RseSB5b3VyCj4gPj4gdHlwaWNh bCBNRkQgZGV2aWNlIChpdCdzIG5vdCBldmVuIGEgc2VwYXJhdGUgY2hpcCwgaXQncyBwYXJ0IG9m IHRoZSBtYWluCj4gPj4gU29DKSwgc28gSSdtIG5vdCBzdXJlIGlmIGl0IHJlYWxseSBiZWxvbmdz IGluIG1mZC8gZnJvbSBhbgo+ID4+IG9yZ2FuaXphdGlvbmFsIHN0YW5kcG9pbnQ/Cj4gPiAKPiA+ IFRoZXJlIGlzIGEgc3Ryb25nIGFyZ3VtZW50IGZvciBhbGwgU29DcyB0byBiZSBjbGFzc2VkIGFz IChtYXNzaXZlKQo+ID4gTUZEcy4gIEhvd2V2ZXIgc2VlaW5nIGFzIHRoZXkgcmVwcmVzZW50IG1v cmUgb2YgYSB3aG9sZSBwbGF0Zm9ybSwKPiA+IHJhdGhlciB0aGFuIGFuIGFkZC1vbiBjaGlwLCB3 ZSBoYXZlIGhhZCB0aGUgc2Vuc2UgdG8gcmVwcmVzZW50IHRoZW0KPiA+IGRpZmZlcmVudGx5LiAg U29tZSBzdWNoIHN1Ym1pc3Npb25zIEkgaGF2ZSBtYWRlIGV4cGxpY2l0IHJlcXVlc3RzIHRvIGJl Cj4gPiBtb3ZlZCBmb3JtIGRyaXZlcnMvbWZkICppbnRvKiBkcml2ZXJzL3BsYXRmb3JtIGluIHRo ZSBwYXN0Lgo+ID4gCj4gPiBNb3N0IFNvQ3MgYXJlIHNvbGVseSByZXByZXNlbnRlZCBpbiBEVCwg b21pdHRpbmcgdGhlIHJlcXVpcmVtZW50IGZvcgo+ID4gc3Vic2VxdWVudCBkZXZpY2UgcmVnaXN0 cmF0aW9uLiAgSGF2ZSB5b3UgY29uc2lkZXJlZCB0aGlzPyAgSWYgc28sIHdoeQo+ID4gZG9lcyB0 aGlzIG5vdCBzdWl0IHlvdXIgdXNlLWNhc2U/Cj4gCj4gVGhpcyBkcml2ZXIgYW5kIGEgc3Vic2V0 IG9mIGl0cyBzdWItZHJpdmVycyBhcmUgaW50ZW5kZWQgdG8gZ2VuZXJhbGl6ZQo+ICh2aWEgZGlm ZmVyZW50IGJhY2tlbmRzLCBidXQgbm8gY2hhbmdlcyB0byBzdWItZHJpdmVycykgdG8gbGVnYWN5 IGFuZCBUMgo+IE1hYyBwbGF0Zm9ybXMsIGV2ZW50dWFsbHkgc3VwZXJzZWRpbmcgYXBwbGVzbWMg KHdoaWNoIGlzIGluIGh3bW9uLwo+IGJlY2F1c2UgaXQgc3RhcnRlZCBvdXQgYXMgdGhhdCwgYnV0 IGhhcyBub3cgZ3Jvd24gcmFuZG9tIGZlYXR1cmVzIGFuZCBpcwo+IHF1aXRlIGEgbWVzcykuIFRo b3NlIGFyZSBhcmUgSW50ZWwvVUVGSSBtYWNoaW5lcyBhbmQgbm90IERUIHBsYXRmb3JtcywKPiBh bmQgb24gdGhvc2UgdGhlIFNNQyBpcyBhY3R1YWxseSBhIHNlcGFyYXRlIGNoaXAgaW4gc29tZSBm b3JtIChtdWNoIGxpa2UKPiBhbiBFQykuCgpVbmRlcnN0b29kLiAgRmFpciBwb2ludC4KCj4gPiBU aGUgbG9uZyBhbmQgdGhlIHNob3J0IG9mIGl0IGlzOyBpZiB5b3Ugd2lzaCB0byB0cmVhdCB0aGlz IGRldmljZSwgb3IKPiA+IGF0IGxlYXN0IGEgc2VjdGlvbiBvZiBpdCwgYXMgYSB0eXBlIG9mIE1G RCwgdGhlbiBwbGVhc2UgZHJhZnQgdGhhdAo+ID4gcGFydCBvZiBpdCBhcyBhbiBNRkQgZHJpdmVy LCByZXNpZGluZyBpbiBkcml2ZXJzL21mZC4gIElmIGl0J3MgIm5vdAo+ID4gcmVhbGx5IGFuIE1G RCIsIHRoZW4gZmluZCBhbm90aGVyIHdheSB0byByZXByZXNlbnQgdGhlIGNvbmdsb21lcmF0aW9u Cj4gPiBwbGVhc2UuCj4gPiAKPiA+IElmIHRoZSBNRkQgcm91dGUgaXMgdGhlIGJlc3QsIHRoZW4g eW91IGNhbiByZWdpc3RlciBlYWNoIG9mIHRoZQo+ID4gZGV2aWNlcywgaW5jbHVkaW5nIHRoZSAq LWNvcmUgZnJvbSBkcml2ZXJzL21mZC4gIEdyZXAgZm9yICJjcm9zcy1lYyIKPiA+IGFzIGEgcmVs YXRpdmVseSByZWNlbnRseSBnb29kIGV4YW1wbGUuCj4gCj4gSSB0aGluayBjcm9zLWVjIGlzIHNp bWlsYXIgZW5vdWdoLCB5ZWFoLiBBcyBsb25nIGFzIHlvdSBkb24ndCBtaW5kCj4gaGF2aW5nIHRo ZSBjb3JlIGNvZGViYXNlIGluIG1mZC8gKDQgZmlsZXM6IGNvcmUsIHJ0a2l0IGJhY2tlbmQsIGFu ZAo+IGZ1dHVyZSBUMiBhbmQgbGVnYWN5IGJhY2tlbmRzKSB3ZSBjYW4gZG8gdGhhdC4KClRoYXQn cyBhY3R1YWxseSBub3Qgd2hhdCBJJ20gc3VnZ2VzdGluZy4KCllvdSAqb25seSogbmVlZCB0byBt b3ZlIHRoZSBzdWJzZXF1ZW50LWRldmljZS1yZWdpc3RyYXRpb24gaGFuZGxpbmcKaW50byBkcml2 ZXJzL21mZC4gIFRoZSByZW1haW5kZXIgcmVhbGx5IHNob3VsZCBiZSB0cmVhdGVkIGFzIFBsYXRm b3JtCihub3QgdG8gYmUgY29uZnVzZWQgd2l0aCBBcmNoIFBsYXRmb3JtKSBjb2RlIGFuZCBzaG91 bGQgcmVzaWRlIGluCmRyaXZlcnMvcGxhdGZvcm0uICBKdXN0IGFzIHdlIGRvIHdpdGggY3Jvcy1l Yy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK