All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jingyu Wang <jingyuwang_vip@163.com>
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv4: Fix some coding style in ah4.c file
Date: Thu, 8 Sep 2022 22:25:34 +0200	[thread overview]
Message-ID: <YxpPvoejMMNliCrg@lunn.ch> (raw)
In-Reply-To: <20220908022118.57973-1-jingyuwang_vip@163.com>

> @@ -165,7 +165,8 @@ static int ah_output(struct xfrm_state *x, struct sk_buff *skb)
>  	ahp = x->data;
>  	ahash = ahp->ahash;
>  
> -	if ((err = skb_cow_data(skb, 0, &trailer)) < 0)
> +	err = skb_cow_data(skb, 0, &trailer));

I prefer the coding style issue over it not compiling at all.

I suggest you don't embarrass yourself any more by compile testing
your changes.

     Andrew

  parent reply	other threads:[~2022-09-08 20:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  2:21 [PATCH] net: ipv4: Fix some coding style in ah4.c file Jingyu Wang
2022-09-08  6:45 ` kernel test robot
2022-09-08  7:41 ` kernel test robot
2022-09-08 20:25 ` Andrew Lunn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-09-08 11:12 Jingyu Wang
2022-09-08 20:34 ` Andrew Lunn
2022-09-19 19:16 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxpPvoejMMNliCrg@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jingyuwang_vip@163.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steffen.klassert@secunet.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.