From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90747C6FA8A for ; Fri, 9 Sep 2022 07:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbiIIG77 (ORCPT ); Fri, 9 Sep 2022 02:59:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbiIIG76 (ORCPT ); Fri, 9 Sep 2022 02:59:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81F5C31EF3 for ; Thu, 8 Sep 2022 23:59:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 926EBB82350 for ; Fri, 9 Sep 2022 06:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D411C433C1; Fri, 9 Sep 2022 06:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662706794; bh=NjnETBEQovFTHW/atuk0epV1j9ubAlRp1T2wsPCQGs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzGQZ/+Gnbsqio4Xxee9bwn59GpYnV3pdfpVRBm2cSnqmKIoo7JDr7OOZ6dP2bQmw IPbykM6K+kGdeTnfLY5R8h9H+ZhTSlpjJreTuebeComEykTksfLnTJPdmOrMoZLcQm vvtDtC/NgLjctJJFd4m4J2vx1syQ9LsiU24DqYsnlOyDocLTVndtuE9G2gR9utto5Y t9od9fsfDx6+48lUujj0CmstVeugcv8OVwg19tW3BhJe82iF25pZROd2nRjCQp2I+M O0+jvYqhtEQ8drg+PISf0P2gGdv1LE3f0EwT+R/SzTSAaPKMaGGryiJrObVD8zn2gY f8clRYqE5CJ8g== Date: Fri, 9 Sep 2022 07:59:49 +0100 From: Lee Jones To: Dan Carpenter Cc: Andy Shevchenko , ChiYuan Huang , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , kernel-janitors Subject: Re: [PATCH] mfd: mt6370: add bounds checking to regmap_read/write functions Message-ID: References: <20220822125705.GD2695@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Thu, 08 Sep 2022, Dan Carpenter wrote: > On Thu, Sep 08, 2022 at 07:57:16AM +0100, Lee Jones wrote: > > On Mon, 22 Aug 2022, Dan Carpenter wrote: > > > > > On Fri, Aug 19, 2022 at 09:27:13AM +0300, Andy Shevchenko wrote: > > > > On Fri, Aug 19, 2022 at 8:25 AM Dan Carpenter wrote: > > > > > > > > > > It looks like there are a potential out of bounds accesses in the > > > > > read/write() functions. Also can "len" be negative? Let's check for > > > > > that too. > > > > > > > > ... > > > > > > > > > Fixes: ab9905c5e38e ("mfd: mt6370: Add MediaTek MT6370 support") > > > > > > > > > From static analysis. This code is obviously harmless however it may > > > > > not be required. The regmap range checking is slightly complicated and > > > > > I haven't remembered where all it's done. > > > > > > > > Exactement! I do not think this Fixes anything, I believe you are > > > > adding a dead code. So, can you do deeper analysis? > > > > > > I spent a long time looking at this code before I sent it and I've > > > spent a long time looking at it today. > > > > > > Smatch said that these values come from the user, but now it seems > > > less clear to me and I have rebuilt the DB so I don't have the same > > > information I was looking at earlier. > > > > > > So I can't see if these come from the user but neither can I find any > > > bounds checking. > > > > What's the consensus please? > > Let's drop it. I think it's not required. Dropped. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A978ECAAA1 for ; Fri, 9 Sep 2022 07:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1L+6yTwMDaAHoOmTt5+oIbCH6+wMxwCDXteKsx5pOH8=; b=p6s0Ir7DdCKYZ2 CKBiO0h4NxzmbG9sEEs2bruqyEAZ1rOHzYC0eq/+jJSW+6F7AwZeX83oeL1mOLNxeaY3Ur3G7Kkhg wf0i5ZHFmnzynGyuqga6LCFoVtkD09FTxT8SOItcsumFExzZSP5HtabZWYU/EvA2G84gkCCXfs7VD 1/romjYS7Yr1jOfn7wchghWro4S9HOSM9OG2E9wnEY6xyvpwAQCjc5QFClCoj+BwiX+/hK5jthl54 qXs7VS4EZirO6AAuA/CzDesgECQkrAfrWOI7nNMVureu2Kro/dm0Dc/Tn6+CTk+JVFcNDSrZUJPBB f948rCggcBNi9hkNmefQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWXzd-00DbNw-39; Fri, 09 Sep 2022 07:00:01 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWXzZ-00DbLu-5P; Fri, 09 Sep 2022 06:59:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B773B8236C; Fri, 9 Sep 2022 06:59:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D411C433C1; Fri, 9 Sep 2022 06:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662706794; bh=NjnETBEQovFTHW/atuk0epV1j9ubAlRp1T2wsPCQGs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FzGQZ/+Gnbsqio4Xxee9bwn59GpYnV3pdfpVRBm2cSnqmKIoo7JDr7OOZ6dP2bQmw IPbykM6K+kGdeTnfLY5R8h9H+ZhTSlpjJreTuebeComEykTksfLnTJPdmOrMoZLcQm vvtDtC/NgLjctJJFd4m4J2vx1syQ9LsiU24DqYsnlOyDocLTVndtuE9G2gR9utto5Y t9od9fsfDx6+48lUujj0CmstVeugcv8OVwg19tW3BhJe82iF25pZROd2nRjCQp2I+M O0+jvYqhtEQ8drg+PISf0P2gGdv1LE3f0EwT+R/SzTSAaPKMaGGryiJrObVD8zn2gY f8clRYqE5CJ8g== Date: Fri, 9 Sep 2022 07:59:49 +0100 From: Lee Jones To: Dan Carpenter Cc: Andy Shevchenko , ChiYuan Huang , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , kernel-janitors Subject: Re: [PATCH] mfd: mt6370: add bounds checking to regmap_read/write functions Message-ID: References: <20220822125705.GD2695@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_235957_367738_933C0E19 X-CRM114-Status: GOOD ( 27.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwOCBTZXAgMjAyMiwgRGFuIENhcnBlbnRlciB3cm90ZToKCj4gT24gVGh1LCBTZXAg MDgsIDIwMjIgYXQgMDc6NTc6MTZBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gTW9u LCAyMiBBdWcgMjAyMiwgRGFuIENhcnBlbnRlciB3cm90ZToKPiA+IAo+ID4gPiBPbiBGcmksIEF1 ZyAxOSwgMjAyMiBhdCAwOToyNzoxM0FNICswMzAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4g PiA+ID4gT24gRnJpLCBBdWcgMTksIDIwMjIgYXQgODoyNSBBTSBEYW4gQ2FycGVudGVyIDxkYW4u Y2FycGVudGVyQG9yYWNsZS5jb20+IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+IEl0IGxvb2tz IGxpa2UgdGhlcmUgYXJlIGEgcG90ZW50aWFsIG91dCBvZiBib3VuZHMgYWNjZXNzZXMgaW4gdGhl Cj4gPiA+ID4gPiByZWFkL3dyaXRlKCkgZnVuY3Rpb25zLiAgQWxzbyBjYW4gImxlbiIgYmUgbmVn YXRpdmU/ICBMZXQncyBjaGVjayBmb3IKPiA+ID4gPiA+IHRoYXQgdG9vLgo+ID4gPiA+IAo+ID4g PiA+IC4uLgo+ID4gPiA+IAo+ID4gPiA+ID4gRml4ZXM6IGFiOTkwNWM1ZTM4ZSAoIm1mZDogbXQ2 MzcwOiBBZGQgTWVkaWFUZWsgTVQ2MzcwIHN1cHBvcnQiKQo+ID4gPiA+IAo+ID4gPiA+ID4gRnJv bSBzdGF0aWMgYW5hbHlzaXMuICBUaGlzIGNvZGUgaXMgb2J2aW91c2x5IGhhcm1sZXNzIGhvd2V2 ZXIgaXQgbWF5Cj4gPiA+ID4gPiBub3QgYmUgcmVxdWlyZWQuICBUaGUgcmVnbWFwIHJhbmdlIGNo ZWNraW5nIGlzIHNsaWdodGx5IGNvbXBsaWNhdGVkIGFuZAo+ID4gPiA+ID4gSSBoYXZlbid0IHJl bWVtYmVyZWQgd2hlcmUgYWxsIGl0J3MgZG9uZS4KPiA+ID4gPiAKPiA+ID4gPiBFeGFjdGVtZW50 ISBJIGRvIG5vdCB0aGluayB0aGlzIEZpeGVzIGFueXRoaW5nLCBJIGJlbGlldmUgeW91IGFyZQo+ ID4gPiA+IGFkZGluZyBhIGRlYWQgY29kZS4gU28sIGNhbiB5b3UgZG8gZGVlcGVyIGFuYWx5c2lz Pwo+ID4gPiAKPiA+ID4gSSBzcGVudCBhIGxvbmcgdGltZSBsb29raW5nIGF0IHRoaXMgY29kZSBi ZWZvcmUgSSBzZW50IGl0IGFuZCBJJ3ZlCj4gPiA+IHNwZW50IGEgbG9uZyB0aW1lIGxvb2tpbmcg YXQgaXQgdG9kYXkuCj4gPiA+IAo+ID4gPiBTbWF0Y2ggc2FpZCB0aGF0IHRoZXNlIHZhbHVlcyBj b21lIGZyb20gdGhlIHVzZXIsIGJ1dCBub3cgaXQgc2VlbXMKPiA+ID4gbGVzcyBjbGVhciB0byBt ZSBhbmQgSSBoYXZlIHJlYnVpbHQgdGhlIERCIHNvIEkgZG9uJ3QgaGF2ZSB0aGUgc2FtZQo+ID4g PiBpbmZvcm1hdGlvbiBJIHdhcyBsb29raW5nIGF0IGVhcmxpZXIuCj4gPiA+IAo+ID4gPiBTbyBJ IGNhbid0IHNlZSBpZiB0aGVzZSBjb21lIGZyb20gdGhlIHVzZXIgYnV0IG5laXRoZXIgY2FuIEkg ZmluZCBhbnkKPiA+ID4gYm91bmRzIGNoZWNraW5nLgo+ID4gCj4gPiBXaGF0J3MgdGhlIGNvbnNl bnN1cyBwbGVhc2U/Cj4gCj4gTGV0J3MgZHJvcCBpdC4gIEkgdGhpbmsgaXQncyBub3QgcmVxdWly ZWQuCgpEcm9wcGVkLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=