From: Greg KH <gregkh@linuxfoundation.org>
To: Hongling Zeng <zenghongling@kylinos.cn>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com
Subject: Re: [PATCH v3 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS
Date: Fri, 9 Sep 2022 09:26:15 +0200 [thread overview]
Message-ID: <YxrqlzXNHmeIR0Uw@kroah.com> (raw)
In-Reply-To: <1662695451-28270-1-git-send-email-zenghongling@kylinos.cn>
On Fri, Sep 09, 2022 at 11:50:51AM +0800, Hongling Zeng wrote:
> The UAS mode of Hiksemi USB_HDD is reported to fail to work on several
> platforms with the following error message, then after re-connecting the
> device will be offlined and not working at all.
>
> [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18
> inflight: CMD
> [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00
> 04 00 00
> [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1
> inflight: CMD
> [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00
> 00 08 00
>
> These disks have a broken uas implementation, the tag field of the status
> iu-s is not set properly,so we need to fall-back to usb-storage.
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
> ---
> Change for v1
> - Change the email real name and the code worng place.
>
> Change for v2
> -Change spelling error.
>
> Change for v3
> -Add acked-by
You sent 2 different emails with patch 2/3, yet no patch 3/3 at all.
Also the patch series is not properly linked together, please use 'git
send-email' to do that.
Please fix all of this up and resend a v4 of the whole series.
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-09 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 3:50 [PATCH v3 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS Hongling Zeng
2022-09-09 7:26 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-09 3:47 Hongling Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxrqlzXNHmeIR0Uw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.