From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, atrajeev@linux.vnet.ibm.com,
eranian@google.com
Subject: Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration
Date: Fri, 9 Sep 2022 10:46:00 -0300 [thread overview]
Message-ID: <YxtDmJWVx05Pmwwl@kernel.org> (raw)
In-Reply-To: <YxtDGLZwi2Cu2U+p@kernel.org>
Em Fri, Sep 09, 2022 at 10:43:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> >
> >
> > On 09/09/2022 05:45, Gaosheng Cui wrote:
> > > perf_pmu_lex has been removed since
> > > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > > so remove it.
> >
> > Not 100% sure if that is the right commit to reference because it didn't
> > touch pmu.y.
>
> Yeah, indeed, unsure if at that time the declaration was needed.
>
> > perf_pmu_lex is still used and there are plenty of references to it, but
> > maybe the extern declaration isn't needed anymore because it still
> > builds for me with this change.
>
> Ditto here, I'll remove the reference and rewrite the cset log a bit.
I left it as:
perf pmu: Remove perf_pmu_lex() needless declaration
It builds without it, perhaps with some older combination of flex/bison
we needed this, clean it up a bit removing this.
next prev parent reply other threads:[~2022-09-09 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 4:45 [PATCH 0/2] Remove unused declarations Gaosheng Cui
2022-09-09 4:45 ` [PATCH 1/2] perf sort: remove hist_entry__sort_list and sort__first_dimension declaration Gaosheng Cui
2022-09-09 4:45 ` [PATCH 2/2] perf tools: remove perf_pmu_lex declaration Gaosheng Cui
2022-09-09 10:29 ` James Clark
2022-09-09 13:43 ` Arnaldo Carvalho de Melo
2022-09-09 13:46 ` Arnaldo Carvalho de Melo [this message]
2022-09-09 13:30 ` [PATCH 0/2] Remove unused declarations Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxtDmJWVx05Pmwwl@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=cuigaosheng1@huawei.com \
--cc=eranian@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.