Re: [LTP] [PATCH 1/3 v2] tst_supported_fs: Unify messaging

[Petr Vorel <pvorel@suse.cz>]

Hi Li, all,

> > I'm not sure about this myself. Shouldn't we rather use tst_brk() and
> > tst_res() instead? It's show tst_supported_fs as command.


> Not exactly, looking at testcase/lib/* tools, most of them are not written
> by LTP standard API, some even do not include tst_test.h.
FYI I meant tst_{brk,res} message starts with filename and line, which is kind of handy.

> I personally think if we want more flexibility for those small programs
> as auxiliary tool, we should not apply API as dogmatism for everything.
Sure

> Btw, there is patch confliction when performing git-am, if you can
> rebase accordingly for solving that, the whole patchset will be
> great for me.
I'm sorry, indeed git-am does not work. I remember rebasing it (and my remote
branch is rebased), I obviously must have run git format-patch before rebasing.

In case of anybody want to actually run it, it's in my fork:
https://github.com/pevik/ltp/commits/fix/TST_ALL_FILESYSTEMS.v2

> Reviewed-by: Li Wang <liwang@redhat.com>

Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp