From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] tst_test.sh: cd to $LTPROOT before umount
Date: Fri, 23 Sep 2022 14:27:16 +0200 [thread overview]
Message-ID: <Yy2mJCM79G1uRlhM@pevik> (raw)
In-Reply-To: <Yy2g9mGQJcc9d4oN@yuki>
> Hi!
> > It's safer not to expect tests go away from the mountpoint
> > before trying to unmount it, because tests can cd to $TST_MNTPOINT
> > if they use TST_MOUNT_DEVICE=1. Also better to handle it in the library
> > than in all tests which may need it.
> > This fix ima_keys.sh and other following IMA/EVM tests which fail on
> > systems with tmpfs on $TMPDIR since 1f6bd6e66:
> > ima_keys 1 TCONF: IMA policy does not specify '^measure.*func=KEY_CHECK'
> > tst_device.c:255: TWARN: ioctl(/dev/loop0, LOOP_CLR_FD, 0) no ENXIO for too long
> > Usage:
> > tst_device acquire [size [filename]]
> > tst_device release /path/to/device
> > tst_device clear /path/to/device
> > ima_keys 1 TWARN: Failed to release device '/dev/loop0'
> > rm: cannot remove '/tmp/LTP_ima_keys.YArl935DCg/mntpoint': Device or resource busy
> > Fixme: 1f6bd6e66 ("tst_test.sh: Add $TST_ALL_FILESYSTEMS")
> ^
> Fixes?
Lol, thanks for spotting this.
> Otherwise:
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-23 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:55 [LTP] [PATCH 0/3] IMA + shell API fixes on umount Petr Vorel
2022-09-23 10:55 ` [LTP] [PATCH 1/3] tst_test.sh: cd to $LTPROOT before umount Petr Vorel
2022-09-23 12:05 ` Cyril Hrubis
2022-09-23 12:27 ` Petr Vorel [this message]
2022-09-23 10:55 ` [LTP] [PATCH 2/3] ima_setup.sh: Use TST_MOUNT_DEVICE Petr Vorel
2022-09-23 13:37 ` Cyril Hrubis
2022-09-23 16:38 ` Petr Vorel
2022-09-23 10:55 ` [LTP] [PATCH 3/3] ima_setup.sh: Use tst_supported_fs instead of df Petr Vorel
2022-09-23 12:21 ` Cyril Hrubis
2022-09-26 9:52 ` Petr Vorel
2022-09-26 9:52 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy2mJCM79G1uRlhM@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.