From: Kevin Wolf <kwolf@redhat.com>
To: luzhipeng <luzhipeng@cestc.cn>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH] block: unmap (discard) blocks only if discard_zeros flag is true
Date: Fri, 23 Sep 2022 16:28:14 +0200 [thread overview]
Message-ID: <Yy3Cfovcpq3OrOP1@redhat.com> (raw)
In-Reply-To: <20220923100224.537-1-luzhipeng@cestc.cn>
Am 23.09.2022 um 12:02 hat luzhipeng geschrieben:
> From: lu zhipeng <luzhipeng@cestc.cn>
>
> we can unmap(discard) blocks for block devices of supporting discard zeros
> or regular file.
>
> Signed-off-by: lu zhipeng <luzhipeng@cestc.cn>
This more or less restores the state before commit 34fa110e. The commit
message there explains that s->discard_zeroes is unreliable (in
particular, it is false on block devices on recent kernels even though
they may support zeroing by discard just fine).
We should instead remove s->discard_zeroes because it is currently
unused. I'll send a patch.
Kevin
next prev parent reply other threads:[~2022-09-23 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:02 [PATCH] block: unmap (discard) blocks only if discard_zeros flag is true luzhipeng
2022-09-23 14:28 ` Kevin Wolf [this message]
2022-09-23 14:33 ` luzhipeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy3Cfovcpq3OrOP1@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=luzhipeng@cestc.cn \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.