From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 352F3C6FA82 for ; Tue, 13 Sep 2022 08:29:35 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EA6CF3CAAF5 for ; Tue, 13 Sep 2022 10:29:32 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 16F823CA900 for ; Tue, 13 Sep 2022 10:29:23 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 75FD41A00F32 for ; Tue, 13 Sep 2022 10:29:22 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 73EFD5BFED; Tue, 13 Sep 2022 08:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663057762; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WQKE6VatuS/gQxhAq7naOC2hIqjwNKuL9WjlPkBOpQI=; b=ofkaPU4WvSmP3bY4XkjigU49ImDLFSY+7TeqmViDrBpw47HWltSTMV0z9fFlKTH/nsmCxp IfFsw9A7+3hkgW2IVlocQqFFcxTVzhRIk/c4jaAFrFslMSTfTFgpN018yPZ1Rq0bB+j7Yp Aw4GjNCjDB4Nx0pz2has4tmEaVfo+pw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663057762; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WQKE6VatuS/gQxhAq7naOC2hIqjwNKuL9WjlPkBOpQI=; b=5jbmQATLXvSGD7m9lS6+T8OLnypEFwuh4DgHOcyAUrtZRjj662fqcRjm9sq862kwIaJNcQ ijwPkPXjNAiOveAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4B3F0139B3; Tue, 13 Sep 2022 08:29:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S64gEWI/IGMOGQAAMHmgww (envelope-from ); Tue, 13 Sep 2022 08:29:22 +0000 Date: Tue, 13 Sep 2022 10:29:20 +0200 From: Petr Vorel To: Li Wang Message-ID: References: <20220905061425.22852-1-luoxiaoyu9@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] pty04.c/pidfd_send_signal03.c: Drop redundant tst_reap_children() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On Tue, Sep 13, 2022 at 2:42 PM Petr Vorel wrote: > > Hi Luo, > > > Drop redundant calling of tst_reap_children() in cleanup() since > > > it has been called in the API (run_tests()). > > LGTM, I suppose that was a mistake. > Hmm, I slightly think that reflact a cautious thought from the author, > in case of test hit tst_brk unexpectly with invoke cleanup it can also > do reap children. > So, it's probably no harmful to keep tst_reap_children there. Ah, thx for info. I set status rejected in patchwork. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp