From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Baruch Siach <baruch@tkos.co.il>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Baruch Siach <baruch.siach@siklu.com>
Subject: Re: [PATCH] net: sfp: workaround GPIO input signals bounce
Date: Tue, 13 Sep 2022 08:48:01 +0100 [thread overview]
Message-ID: <YyA1sfZRuoka8yhl@shell.armlinux.org.uk> (raw)
In-Reply-To: <5934427dadd3065b125b80c38a111320677fa723.1663055018.git.baruch@tkos.co.il>
On Tue, Sep 13, 2022 at 10:43:38AM +0300, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
>
> Add a trivial debounce to avoid miss of state changes when there is no
> proper hardware debounce on the input signals. Otherwise a GPIO might
> randomly indicate high level when the signal is actually going down,
> and vice versa.
>
> This fixes observed miss of link up event when LOS signal goes down on
> Armada 8040 based system with an optical SFP module.
NAK. This needs more inteligent handling. For systems where we poll,
your code introduces a 100us delay each time we poll and there has
been no change.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-09-13 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 7:43 [PATCH] net: sfp: workaround GPIO input signals bounce Baruch Siach
2022-09-13 7:48 ` Russell King (Oracle) [this message]
2022-09-13 9:54 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyA1sfZRuoka8yhl@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=baruch.siach@siklu.com \
--cc=baruch@tkos.co.il \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.