From: Petr Vorel <pvorel@suse.cz>
To: Luo xiaoyu <luoxiaoyu9@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] pty04.c/pidfd_send_signal03.c: Drop redundant tst_reap_children()
Date: Tue, 13 Sep 2022 08:42:05 +0200 [thread overview]
Message-ID: <YyAmPYZ2iaraxraN@pevik> (raw)
In-Reply-To: <20220905061425.22852-1-luoxiaoyu9@huawei.com>
Hi Luo,
> Drop redundant calling of tst_reap_children() in cleanup() since
> it has been called in the API (run_tests()).
LGTM, I suppose that was a mistake.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
NOTE: this patch is broken:
patch: **** malformed patch at line 100:
Please be careful next time.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-13 6:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 6:14 [LTP] [PATCH] pty04.c/pidfd_send_signal03.c: Drop redundant tst_reap_children() Luo xiaoyu via ltp
2022-09-13 6:42 ` Petr Vorel [this message]
2022-09-13 7:33 ` Li Wang
2022-09-13 8:29 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2022-09-13 9:14 luoxiaoyu (C) via ltp
2022-09-13 10:10 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyAmPYZ2iaraxraN@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=luoxiaoyu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.