From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF87ECAAD3 for ; Wed, 14 Sep 2022 11:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbiINLrq (ORCPT ); Wed, 14 Sep 2022 07:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229869AbiINLro (ORCPT ); Wed, 14 Sep 2022 07:47:44 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAE207AC24 for ; Wed, 14 Sep 2022 04:47:42 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id n35-20020a05600c502300b003b4924c6868so2138879wmr.1 for ; Wed, 14 Sep 2022 04:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=gNw8KIHA1akV3WAIG3mTyAM9FwwfR45IWHpt7v8NJ/D3h8AuPnRAR4Fr9l6bY4Z+l+ yBth3uvMnFhQguK7OFTCFEvob15XvvYYkQE6d5COR/F3dEL9EtIxWGeLd3Ti+huvh2AS UBiZdvfDAe2ffljdOWuaI7kc+tuNrsOiJfuhmKifgcExmxx2CxBo4QEmKguep2CjcgBi Mp80NzZ2QTsl+f2ooHri9mIxl/A9EFiJh010AdjbJ9RG0BFdICtooF0X4b+3YpOiUcxo PiaQDy5iGBG39jXagGb5CLj0tueVl6vvcptlPqe1xaYjbhuQ/GbIW0ZWRwxqmB33Cc8w iz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=S9I2fEbdT9LFJFZ7fjuuGxlpckSvWmH3zWRsZ6CpBcJm3TGFsTy45KNq/6MzoNY47E Yo5+uIsLYOAhuurznmhdF3nyKrYo6GEBbT5ptKEVDJ0zZsqvNLpLHer+X8oLLhzfEEwY FcIL7myjZYWpRYIEm8zcL4U1ZO8EIZCXv6HTx1HYaF05X7WOR3W2klM56RnCbBJoq0pJ 9dNJ8f8zS0e/GH60DwqDhNvU5M022aOGJOpYT7DC7ViRh1P/k7XW3WX4WA2SdJEu5wjT ZZC0pzHKzjVj1xmsDrfRu6epDcjpAbcOB5Nldze2p5OGca3+bISdh1b75vOitWW/Dmr7 fFbA== X-Gm-Message-State: ACgBeo3xM68kdysHLZCKnZ9nnKlTRJz7eUennbaikSxfSDtnE3lq6ojh cNUcedu8SMXRr52LR1bosHLcJQ== X-Google-Smtp-Source: AA6agR6aSV3jXyKXuS6Lp8ysxs2qtNOBdPRNKt7wbfiui0ec8Ug1sA6v6mmiNfrSa5l3/MzmVoabgw== X-Received: by 2002:a7b:c84c:0:b0:3b3:3faa:10c3 with SMTP id c12-20020a7bc84c000000b003b33faa10c3mr2800743wml.94.1663156061281; Wed, 14 Sep 2022 04:47:41 -0700 (PDT) Received: from localhost ([185.122.133.20]) by smtp.gmail.com with ESMTPSA id n9-20020a5d6609000000b0021e51c039c5sm13066031wru.80.2022.09.14.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 04:47:40 -0700 (PDT) Date: Wed, 14 Sep 2022 12:47:40 +0100 From: Johannes Weiner To: Christoph Hellwig Cc: Jens Axboe , Matthew Wilcox , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Message-ID: References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220910065058.3303831-5-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Sep 10, 2022 at 08:50:57AM +0200, Christoph Hellwig wrote: > erofs uses an additional address space for compressed data read from disk > in addition to the one directly associated with the inode. Reading into > the lower address space is open coded using add_to_page_cache_lru instead > of using the filemap.c helper for page allocation micro-optimizations, > which means it is not covered by the MM PSI annotations for ->read_folio > and ->readahead, so add manual ones instead. > > Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01583C6FA8A for ; Wed, 14 Sep 2022 11:47:49 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MSJVX3qr9z3bc3 for ; Wed, 14 Sep 2022 21:47:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=cmpxchg-org.20210112.gappssmtp.com header.i=@cmpxchg-org.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=gNw8KIHA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=cmpxchg.org (client-ip=2a00:1450:4864:20::32b; helo=mail-wm1-x32b.google.com; envelope-from=hannes@cmpxchg.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cmpxchg-org.20210112.gappssmtp.com header.i=@cmpxchg-org.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=gNw8KIHA; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MSJVS6n2Jz2yMk for ; Wed, 14 Sep 2022 21:47:44 +1000 (AEST) Received: by mail-wm1-x32b.google.com with SMTP id ay7-20020a05600c1e0700b003b49861bf48so2143702wmb.0 for ; Wed, 14 Sep 2022 04:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=gNw8KIHA1akV3WAIG3mTyAM9FwwfR45IWHpt7v8NJ/D3h8AuPnRAR4Fr9l6bY4Z+l+ yBth3uvMnFhQguK7OFTCFEvob15XvvYYkQE6d5COR/F3dEL9EtIxWGeLd3Ti+huvh2AS UBiZdvfDAe2ffljdOWuaI7kc+tuNrsOiJfuhmKifgcExmxx2CxBo4QEmKguep2CjcgBi Mp80NzZ2QTsl+f2ooHri9mIxl/A9EFiJh010AdjbJ9RG0BFdICtooF0X4b+3YpOiUcxo PiaQDy5iGBG39jXagGb5CLj0tueVl6vvcptlPqe1xaYjbhuQ/GbIW0ZWRwxqmB33Cc8w iz1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=jkjInFA4v6207rYNR9PZy7GQsLdw9JOAYyp4dYZPwKo=; b=PPzTs85UxT4miVxr/7cjrnP2FseX0FQrTaRMw8R+ttD8TofKtKo2Enx/3jWCyYiqr8 cpenQc1EW+aS8gyGZI1vk9vZwqXn6nkw9NLkpz/34Sy7kszOvJO5A1Cv49aIAZVhEZf9 1bs5Kh2TmhKgWQr6nh0XyFsa5EN3a1n6XKSRawP+jEq2C4fgDiEq9h/ls9qnNwOC+EBx fB5F1MTwrBBalNN9SmH6pWHed4ACB5EzY0N4WFLM/iAz04biPtMVeY4X5qYdf5FNly2d tq5ukLc5d5DhbfddhkqSqOVCnRTiU4/YNnrJ0XUeBJjc5E6xhACAkt8KuEU3ky//LXYe PkDw== X-Gm-Message-State: ACgBeo0qp06f6E657Gp2EtX9JivZp/AEG3nda8QxkewGB35rqlVHEPXv KDlIq9DqiPL6kkY6Jj7ugvVhgA== X-Google-Smtp-Source: AA6agR6aSV3jXyKXuS6Lp8ysxs2qtNOBdPRNKt7wbfiui0ec8Ug1sA6v6mmiNfrSa5l3/MzmVoabgw== X-Received: by 2002:a7b:c84c:0:b0:3b3:3faa:10c3 with SMTP id c12-20020a7bc84c000000b003b33faa10c3mr2800743wml.94.1663156061281; Wed, 14 Sep 2022 04:47:41 -0700 (PDT) Received: from localhost ([185.122.133.20]) by smtp.gmail.com with ESMTPSA id n9-20020a5d6609000000b0021e51c039c5sm13066031wru.80.2022.09.14.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 04:47:40 -0700 (PDT) Date: Wed, 14 Sep 2022 12:47:40 +0100 From: Johannes Weiner To: Christoph Hellwig Subject: Re: [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Message-ID: References: <20220910065058.3303831-1-hch@lst.de> <20220910065058.3303831-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220910065058.3303831-5-hch@lst.de> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-mm@kvack.org, linux-erofs@lists.ozlabs.org, Josef Bacik , Matthew Wilcox , linux-block@vger.kernel.org, Chris Mason , David Sterba , linux-fsdevel@vger.kernel.org, Andrew Morton , Suren Baghdasaryan , linux-btrfs@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Sat, Sep 10, 2022 at 08:50:57AM +0200, Christoph Hellwig wrote: > erofs uses an additional address space for compressed data read from disk > in addition to the one directly associated with the inode. Reading into > the lower address space is open coded using add_to_page_cache_lru instead > of using the filemap.c helper for page allocation micro-optimizations, > which means it is not covered by the MM PSI annotations for ->read_folio > and ->readahead, so add manual ones instead. > > Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner