From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EF1EECAAD8 for ; Fri, 16 Sep 2022 13:09:53 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 281E03CACA3 for ; Fri, 16 Sep 2022 15:09:51 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id B98493CACA3 for ; Fri, 16 Sep 2022 15:09:39 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D192E201DA6 for ; Fri, 16 Sep 2022 15:09:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 369C61FBA0; Fri, 16 Sep 2022 13:09:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663333778; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4cPYsCCfpxB5/Jz7ArOiMefBXMMcnhnYmyTcJpqlDls=; b=lIQbnBurajzJ1vwTnYcd/NDZBVFkSZ7KKxKD4E7RD5rbEpEXs37W7bh7bw84B7EinKXmbM MYegHlThqhzFTPbiMvZciDaMW4OwVgerSGbgZrag0ipdaWsx5uY4Zcs1Li9jy9c886U5z7 NTFJcfw+Z9ndxDj7K0bNefnIVGayfmA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663333778; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4cPYsCCfpxB5/Jz7ArOiMefBXMMcnhnYmyTcJpqlDls=; b=4CJngMMCIPXAZkEVGXe+/t8SyPyhNyTs0XJjXNDsQ+63MyDsLThOpp2TKAQ/TwblmEpj21 Iw+zNOpymoLLbRDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D4A021346B; Fri, 16 Sep 2022 13:09:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t/8GMJF1JGNrOQAAMHmgww (envelope-from ); Fri, 16 Sep 2022 13:09:37 +0000 Date: Fri, 16 Sep 2022 15:09:35 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20220915093639.2261-1-pvorel@suse.cz> <20220915093639.2261-6-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v6 5/8] tst_test.sh: Add $TST_ALL_FILESYSTEMS X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > + if [ "$TST_ALL_FILESYSTEMS" != 1 ]; then > > + if ! tst_supported_fs -s "$TST_SKIP_FILESYSTEMS" $TST_FS_TYPE > /dev/null; then > Whatever the API ends up I guess that we should check the support and > mkfs here as well in order to TCONF early before we create a device and > attempt to format/mount it. I was worried to add mkfs.foo dependency unless there is a requirement for it (i.e. TST_NEEDS_DEVICE=1). Do you really want to add this dependency for *all* tests? (I'd prefer no, i.e. to keep here check only for test not being skipped, because check for mkfs.foo is in tst_mkfs which does the job, thus not only we'd add an extra unneeded dependency but also duplicity in the check). But if you want it, i.e. if we require mkfs.$TST_FS_TYPE (unless tmpfs of course, which is handled properly) here, then we don't need to separate checks for mkfs.foo and skip list in testcases/lib/tst_supported_fs.c. Kind regards, Petr > Otherwise: > Reviewed-by: Cyril Hrubis -- Mailing list info: https://lists.linux.it/listinfo/ltp