From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BC2C54EE9 for ; Fri, 16 Sep 2022 12:08:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231268AbiIPMIZ (ORCPT ); Fri, 16 Sep 2022 08:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230438AbiIPMIS (ORCPT ); Fri, 16 Sep 2022 08:08:18 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193F6AFADC; Fri, 16 Sep 2022 05:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=3sBrLZszBTwXrdkhDhI3TRiPwHJ3gCGVkiN5akonAyA=; b=add+KNbUGfKNimygvqrNno44qk JAtUswvhSwRGSGk1A+1xsjn30E600n9BXMwKkznbrl0TrecSeFh+bbaFOphmXi2CguVh0GDFRBPfi uakL1RO/3UJorlpZpyyaQxjazWqmOrnzeoTZ9MVqd5/Hm3dc4DmRPyW22ygushzxKZWE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oZA8W-00GuiQ-N4; Fri, 16 Sep 2022 14:08:00 +0200 Date: Fri, 16 Sep 2022 14:08:00 +0200 From: Andrew Lunn To: Divya Koppera Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [patch net-next] net: phy: micrel: PEROUT support in lan8814 Message-ID: References: <20220916112042.16501-1-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916112042.16501-1-Divya.Koppera@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 04:50:42PM +0530, Divya Koppera wrote: > Support Periodic output from lan8814 gpio > > Signed-off-by: Divya Koppera Please Cc: the PTP Maintainer. > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_5MS_ 9 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_1MS_ 8 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_500US_ 7 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_100US_ 6 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_50US_ 5 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_10US_ 4 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_5US_ 3 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_1US_ 2 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_500NS_ 1 > +#define LAN88XX_PTP_GENERAL_CONFIG_LTC_EVENT_100NS_ 0 > +static int lan88xx_get_pulsewidth(struct phy_device *phydev, > + struct ptp_perout_request *perout_request, > + int *pulse_width) > +{ A blank line between the #defines and the function would be good. Andrew