From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v6 3/8] tst_supported_fs: Support skip list when query single fs
Date: Fri, 16 Sep 2022 14:39:40 +0200 [thread overview]
Message-ID: <YyRujPRK3cNHQpfa@pevik> (raw)
In-Reply-To: <YyRr4a9/oLNHd0ZK@yuki>
> Hi!
> > Shouldn't there be an getopt option to decide?
> > e.g. by default both skip list and mkfs (no matter if -s is passed) and with
> > option (e.g. -o) check only for a list? This is not needed when checking all
> > filesystems, only for testing single filesystem, so I wonder if I should
> > implement it for all filesystems mode.
> > But as this is not needed I'm ok to implement what you suggest:
> > tst_supported_fs -s skiplist foo would check only if the used filesystem is not
> > filtered by skip list (used in tst_test.sh).
> > tst_supported_fs foo would check only for mkfs.foo (used in prepare_lvm.sh).
> > What do you prefer?
> I guess that I do not care that much what exact API we do have here as
> long was we can check for just skiplist or just support separatelly.
OK, atm we don't need the third option (skip list + both), so that I will not
care about it.
I might do this only for mode when single fs is being queried (haven't decided
yet) as that's IMHO not needed atm.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-16 12:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 9:36 [LTP] [PATCH v6 0/8] shell: df01.sh: $TST_ALL_FILESYSTEMS Petr Vorel
2022-09-15 9:36 ` [LTP] [PATCH v6 1/8] tst_supported_fs: Implement skip list Petr Vorel
2022-09-15 9:36 ` [LTP] [PATCH v6 2/8] zram01.sh: Use tst_supported_fs -s tmpfs Petr Vorel
2022-09-16 11:33 ` Cyril Hrubis
2022-09-15 9:36 ` [LTP] [PATCH v6 3/8] tst_supported_fs: Support skip list when query single fs Petr Vorel
2022-09-16 11:45 ` Cyril Hrubis
2022-09-16 12:09 ` Petr Vorel
2022-09-16 12:28 ` Cyril Hrubis
2022-09-16 12:39 ` Petr Vorel [this message]
2022-09-16 12:10 ` Petr Vorel
2022-09-15 9:36 ` [LTP] [PATCH v6 4/8] shell: Add $TST_SKIP_FILESYSTEMS + tests Petr Vorel
2022-09-16 11:50 ` Cyril Hrubis
2022-09-15 9:36 ` [LTP] [PATCH v6 5/8] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-09-16 12:45 ` Cyril Hrubis
2022-09-16 13:09 ` Petr Vorel
2022-09-16 13:17 ` Cyril Hrubis
2022-09-16 20:27 ` Petr Vorel
2022-09-15 9:36 ` [LTP] [PATCH v6 6/8] tst_test.sh: Allow | after whitelisted variable Petr Vorel
2022-09-16 13:02 ` Cyril Hrubis
2022-09-15 9:36 ` [LTP] [PATCH v6 7/8] shell: Add tests for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-15 9:36 ` [LTP] [PATCH v6 8/8] df01.sh: Convert to TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-16 13:10 ` Cyril Hrubis
2022-09-16 13:11 ` Cyril Hrubis
2022-09-16 20:39 ` Petr Vorel
2022-09-16 13:12 ` Petr Vorel
2022-09-16 21:22 ` [LTP] [PATCH v6 0/8] shell: df01.sh: $TST_ALL_FILESYSTEMS Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyRujPRK3cNHQpfa@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.