From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>,
Alex Williamson <alex.williamson@hp.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Lennert Buytenhek <buytenh@arista.com>
Subject: Re: [PATCH v2 1/1] serial: 8250: Turn IER bits on only after irq has been set up
Date: Mon, 19 Sep 2022 16:56:13 +0300 [thread overview]
Message-ID: <YySZ8M5OQqAaaT1b@smile.fi.intel.com> (raw)
In-Reply-To: <YySX8E3PjAvRr/ld@smile.fi.intel.com>
On Fri, Sep 16, 2022 at 06:36:16PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 16, 2022 at 04:38:04PM +0300, Ilpo Järvinen wrote:
Side note:
$ git grep -n -w setup_irq -- drivers/tty/
drivers/tty/serial/8250/8250_core.c:382: .setup_irq = univ8250_setup_irq,
drivers/tty/serial/8250/8250_port.c:2341: retval = up->ops->setup_irq(up);
which rises a question of whether we need the setup_irq member in the
respective structure.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-19 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:38 [PATCH v2 1/1] serial: 8250: Turn IER bits on only after irq has been set up Ilpo Järvinen
2022-09-19 13:56 ` Andy Shevchenko
2022-09-19 13:56 ` Andy Shevchenko [this message]
2022-09-19 13:56 ` Andy Shevchenko
2022-09-19 14:06 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YySZ8M5OQqAaaT1b@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@hp.com \
--cc=aris@cathedrallabs.org \
--cc=buytenh@arista.com \
--cc=buytenh@wantstofly.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.