From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C70B1378 for ; Sat, 17 Sep 2022 11:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=d0vZLrwUx+iXcTh2m2nDJabIHtGdWf25vyT9nVB6hBs=; b=G2xuteUgz9d49f6Of+fdYOZP6U uLTc9ACj9mPEaSHAeK76Kl3PQow/YIg0B0frdNKRPhlwLF/xeurL2bLJdAxfEZA7Fs3Uhloy2wU2I d0SqU6Bpp2U8hr/bbhiQt8kMvN/dghSQ9wSDs3By805zSFd9IXhqXJeLh5FwPcU6FDnsrP2xw7hSg B1ovbRknIm2bD+dmmZ2uFhXNXuKFwFS+PzACtgv5Q+7d/no5KU9Kl3KFeAZOT67jbyCgkH8IS9XC+ H5KDepZb92RzUWk77uswQ68E8yplmYf7oUGWekHrXB6iIN1uEPVxJoChRlbYfI9zmrEzQpLt50alD 4QpgG2Zw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34374) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oZVtT-0007h3-5F; Sat, 17 Sep 2022 12:21:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oZVtP-0004Sw-52; Sat, 17 Sep 2022 12:21:51 +0100 Date: Sat, 17 Sep 2022 12:21:51 +0100 From: "Russell King (Oracle)" To: Sven Peter Cc: Jassi Brar , Alyssa Rosenzweig , asahi@lists.linux.dev, Hector Martin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] apple rtkit: add support for atomic operations Message-ID: References: <19191d4d-e8a8-4319-bf7b-d5301a792a21@www.fastmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19191d4d-e8a8-4319-bf7b-d5301a792a21@www.fastmail.com> Sender: Russell King (Oracle) On Sat, Sep 17, 2022 at 12:42:30PM +0200, Sven Peter wrote: > Hi, > > On Wed, Sep 14, 2022, at 10:34, Russell King (Oracle) wrote: > > Hi, > > > > This series adds support to the Apple rtkit for atomic messaging, > > which will be necessary for SMC support on these platforms. > > > > SMC support requires a bit of rework after recent review comments, > > so I'm sending this separately in the hope that we can move forward > > with upstream kernels. > > Maybe I misremember or maybe you forgot to pick up my reviewed-by tags > for the mailbox commits. It's the first time I've sent the mailbox commits after Hector mentioned them. > Either way, for the entire series: > > Reviewed-by: Sven Peter > > > We'd usually take the last soc/rtkit commit through the Asahi platform and then the > soc tree. Taking it through the mailbox tree will make things more complicated > if SMC (which is the only driver that uses the poll API and hard depends on it) is > also ready for this merge window. I don't think that's very likely so taking it > through mailbox is also fine. I'm sending these seperately because I don't think the platform/mfd issues will be sorted before the merge window. We've fallen into the trap where I have a load of updates to the patches in my git tree that aren't in the Asahi tree, but Lee wants some substantial changes to the way the MFD part is handled which I think Hector needs to do. So somehow I need to get my changes back to Hector (I don't do github) which basically means digging out the original patches from the Asahi kernel tree and supplying diffs to Hector for those - along with all the acks/reviewed-bys etc. This *really* isn't nice. I didn't follow that discussion very well - with about 130 messages in total in that thread, it just became too much for me to keep track of, as I explained as the discussion drew to a close. That was the whole reason for me sending v2, which essentially mostly got ignored and discussion continued on v1. So, basically, trying to get these patches into mainline has created a hell of a lot of extra work and difficulty - and at this point I'm wondering whether it really is a good idea to continue with this. It's fine if the comments are all minor issues that can be quickly resolved, but a major restructuring is a completely different matter. So, to at least get some progress, I decided to send what would be possible to hopefully merge during the remainder of this window. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42615ECAAD3 for ; Sat, 17 Sep 2022 11:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tsgwDwoJBJc9EyugtgCGdKo/3m3N20MKfSXVslIx4kk=; b=vZHl9M1mLISRKw YMsnnZOLsbxcXT9TgM3vI2eZbAehll185tKqEXpORVOAKCVYEatCBOpad0L45K/+8+cL7ZjSDg3wf o7rCIrw3TFveLG8QzBTwjSYL9adqaHoWFUeum0AGzMU5M+FuJp5/sLC4x9fMefZ1OElWU9NGzE77z AGy5DhN+EADc16DJtPTX/KTtjBT5E194WzdaRjwKoL8KJe11Rc/8nZ6ioGFmWDSClh3gMWh/A9oCj VUZT4VYpFn9dX5/rtn5TK6vtp8EREj+iB+6t+mwc9fOhkTH8cWddirCNFROpQznaHAewXoTPSvdBV fthCrvdZUrCIHO9NVtpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZVti-005R05-Qo; Sat, 17 Sep 2022 11:22:10 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZVtf-005QxZ-Lx for linux-arm-kernel@lists.infradead.org; Sat, 17 Sep 2022 11:22:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=d0vZLrwUx+iXcTh2m2nDJabIHtGdWf25vyT9nVB6hBs=; b=G2xuteUgz9d49f6Of+fdYOZP6U uLTc9ACj9mPEaSHAeK76Kl3PQow/YIg0B0frdNKRPhlwLF/xeurL2bLJdAxfEZA7Fs3Uhloy2wU2I d0SqU6Bpp2U8hr/bbhiQt8kMvN/dghSQ9wSDs3By805zSFd9IXhqXJeLh5FwPcU6FDnsrP2xw7hSg B1ovbRknIm2bD+dmmZ2uFhXNXuKFwFS+PzACtgv5Q+7d/no5KU9Kl3KFeAZOT67jbyCgkH8IS9XC+ H5KDepZb92RzUWk77uswQ68E8yplmYf7oUGWekHrXB6iIN1uEPVxJoChRlbYfI9zmrEzQpLt50alD 4QpgG2Zw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34374) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oZVtT-0007h3-5F; Sat, 17 Sep 2022 12:21:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oZVtP-0004Sw-52; Sat, 17 Sep 2022 12:21:51 +0100 Date: Sat, 17 Sep 2022 12:21:51 +0100 From: "Russell King (Oracle)" To: Sven Peter Cc: Jassi Brar , Alyssa Rosenzweig , asahi@lists.linux.dev, Hector Martin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] apple rtkit: add support for atomic operations Message-ID: References: <19191d4d-e8a8-4319-bf7b-d5301a792a21@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19191d4d-e8a8-4319-bf7b-d5301a792a21@www.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220917_042207_740402_FB5CAD67 X-CRM114-Status: GOOD ( 29.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 17, 2022 at 12:42:30PM +0200, Sven Peter wrote: > Hi, > > On Wed, Sep 14, 2022, at 10:34, Russell King (Oracle) wrote: > > Hi, > > > > This series adds support to the Apple rtkit for atomic messaging, > > which will be necessary for SMC support on these platforms. > > > > SMC support requires a bit of rework after recent review comments, > > so I'm sending this separately in the hope that we can move forward > > with upstream kernels. > > Maybe I misremember or maybe you forgot to pick up my reviewed-by tags > for the mailbox commits. It's the first time I've sent the mailbox commits after Hector mentioned them. > Either way, for the entire series: > > Reviewed-by: Sven Peter > > > We'd usually take the last soc/rtkit commit through the Asahi platform and then the > soc tree. Taking it through the mailbox tree will make things more complicated > if SMC (which is the only driver that uses the poll API and hard depends on it) is > also ready for this merge window. I don't think that's very likely so taking it > through mailbox is also fine. I'm sending these seperately because I don't think the platform/mfd issues will be sorted before the merge window. We've fallen into the trap where I have a load of updates to the patches in my git tree that aren't in the Asahi tree, but Lee wants some substantial changes to the way the MFD part is handled which I think Hector needs to do. So somehow I need to get my changes back to Hector (I don't do github) which basically means digging out the original patches from the Asahi kernel tree and supplying diffs to Hector for those - along with all the acks/reviewed-bys etc. This *really* isn't nice. I didn't follow that discussion very well - with about 130 messages in total in that thread, it just became too much for me to keep track of, as I explained as the discussion drew to a close. That was the whole reason for me sending v2, which essentially mostly got ignored and discussion continued on v1. So, basically, trying to get these patches into mainline has created a hell of a lot of extra work and difficulty - and at this point I'm wondering whether it really is a good idea to continue with this. It's fine if the comments are all minor issues that can be quickly resolved, but a major restructuring is a completely different matter. So, to at least get some progress, I decided to send what would be possible to hopefully merge during the remainder of this window. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel